Video Autoplay works in M66 but not in M68
Reported by
prabhu.d...@turner.com,
Apr 24 2018
|
|||||||||||
Issue descriptionChrome Version : M68- 68.0.3405.0 URLs (if applicable) : https://www.cnn.com/videos Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: Firefox: Edge: What steps will reproduce the problem? (1) Go to https://www.cnn.com/videos (2) If necessary, clear browsing data so that MEI for www.cnn.com is reset (3) Set MEI for www.cnn.com to allow autoplay by repeating the following steps (3a)-(3d) at least 6 times: (3a) Confirm that all cnn.com tabs are closed (3b) Open https://www.cnn.com/videos (3c) Play the video for at least 7 sec. (3d) Close the tab (4) Now visit the same site - autoplay should work but isn't. Confirm that MEI has enabled autoplay for www.cnn.com What is the expected result? When MEI is high, site should autoplay What happens instead? Autoplay is blocked Note: On M66, after turning on MEI, videos autoplay on cnn.com/videos. [Based on the recommendations from https://bugs.chromium.org/p/chromium/issues/detail?id=835842I --enable-features=MediaEngagementBypassAutoplayPolicies,UnifiedAutoplay was turned on in M66]
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
I can replicate this in 68. It looks like the AutoplayFlags are being cleared on the main frame for some reason.
,
Apr 24 2018
Pending CL to fix: https://chromium-review.googlesource.com/c/chromium/src/+/1026798
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db5279797b05deffef36dc9796df5305e1894d86 commit db5279797b05deffef36dc9796df5305e1894d86 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Apr 26 17:09:31 2018 Autoplay: Clear flags on top frame navigation Some subframe navigations were temporarily clearing the AutoplayFlags at the same time the top frame was checking them. This changes it so we only clear AutoplayFlags on a top frame navigation. BUG= 836369 Change-Id: Iffe51b8267009aaf0e53d56d18ce505a74cb761f Reviewed-on: https://chromium-review.googlesource.com/1026798 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#554058} [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/content/renderer/render_frame_impl.cc [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/third_party/blink/public/web/web_view.h [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/third_party/blink/renderer/core/exported/web_view_impl.h [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/third_party/blink/renderer/core/page/page.cc [modify] https://crrev.com/db5279797b05deffef36dc9796df5305e1894d86/third_party/blink/renderer/core/page/page.h
,
Apr 26 2018
,
Apr 26 2018
,
Apr 26 2018
Pls update the bug with canary result tomorrow.
,
Apr 27 2018
Tested the issue using #68.0.3410.0 on Win 10, Mac 10.13.3 and Linux Debian Rodete as per the steps mentioned below. Steps: 1. Launched Browser 2. Navigated to https://www.cnn.com/videos 3. Set MEI for www.cnn.com 4. Played video at https://www.cnn.com/videos for more than 7 seconds 5. Closed the tab 6. Reopened https://www.cnn.com/ @Prabhu: Could you please find the attached screencast and help us in verifying the issue? Thanks!!
,
Apr 27 2018
The NextAction date has arrived: 2018-04-27
,
Apr 27 2018
I can confirm that #68.0.3410.0 looks to have fixed this issue. Unmuted media autoplay is working as expected with both high & low MEI scores.
,
Apr 27 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 27 2018
Pls merge the change to M67 branch 3396 ASAP so we can pick it up for next M67 beta release. Thank you.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1 commit d7ce57cd755e6e2b73419ea8176a9000ba24c7f1 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Apr 27 21:56:01 2018 Autoplay: Clear flags on top frame navigation Some subframe navigations were temporarily clearing the AutoplayFlags at the same time the top frame was checking them. This changes it so we only clear AutoplayFlags on a top frame navigation. BUG= 836369 Change-Id: Iffe51b8267009aaf0e53d56d18ce505a74cb761f Reviewed-on: https://chromium-review.googlesource.com/1026798 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#554058}(cherry picked from commit db5279797b05deffef36dc9796df5305e1894d86) Reviewed-on: https://chromium-review.googlesource.com/1033794 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#362} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/content/renderer/render_frame_impl.cc [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/content/renderer/render_frame_impl_browsertest.cc [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/third_party/blink/public/web/web_view.h [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/third_party/blink/renderer/core/exported/web_view_impl.h [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/third_party/blink/renderer/core/page/page.cc [modify] https://crrev.com/d7ce57cd755e6e2b73419ea8176a9000ba24c7f1/third_party/blink/renderer/core/page/page.h
,
Apr 27 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by prabhu.d...@turner.com
, Apr 24 2018