New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836367 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Surface synchronization: WasResized => SynchronizeVisualProperties, ResizeParams => VisualProperties

Project Member Reported by fsam...@chromium.org, Apr 24 2018

Issue description

I'd like to rename a bunch of methods to better match how they're used
now:

WasResized() => SynchronizeVisualProperties()
ResizeParams => VisualProperties
ViewMsg_Resize => ViewMsg_SynchronizeVisualProperties
ViewHostMsg_ResizeOrRepaint_ACK => ViewHostMsg_SynchronizeVisualPropertiesOrRepaint_ACK

etc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b91182640b1969abe4808e110f99b29a090a059

commit 0b91182640b1969abe4808e110f99b29a090a059
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Apr 25 13:22:16 2018

Surface synchronization: WasResized => SynchronizeVisualProperties

WasResized is a misnomer. This is one of many CLs to change the
language in a post-surface-sync world.

Change-Id: I546e914e98e9746894a9dae7b1bf65a894cb6fe7
Bug:  836367 ,  672962 
Reviewed-on: https://chromium-review.googlesource.com/1026468
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553528}
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/android_webview/browser/aw_web_contents_delegate.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/android/content_view_core.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/delegated_frame_host_client_aura.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/public/browser/render_widget_host.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/content/shell/browser/shell.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/0b91182640b1969abe4808e110f99b29a090a059/ui/android/delegated_frame_host_android.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/799e72196268789140e9c230bfaea81a3381a718

commit 799e72196268789140e9c230bfaea81a3381a718
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Apr 25 21:16:57 2018

Surface Synchronization: ResizeParams => VisualProperties

ResizeParams is a misnomer. VisualProperties is better although
perhaps confusing because changing the LocalSurfaceId can cause
a new CompositorFrame to be generated without any change in visuals.

I can't really think of a better name and VisualProperties can also
be interpreted as properties that affect the visuals (compositing)
system so it still works. It's definitely an improvement from
ResizeParams which is totally wrong.

Change-Id: Ie8e1f5e8c354851e4efdf3aa5d975f1edfe77f5d
Bug:  836367 ,  672962 
TBR: tsepez@chromium.org for IPC rename.
Reviewed-on: https://chromium-review.googlesource.com/1028460
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553747}
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/BUILD.gn
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/frame_messages.h
[delete] https://crrev.com/c432775b685a52d429bb6004fb7bce08dbc3d686/content/common/frame_resize_params.cc
[add] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/frame_visual_properties.cc
[rename] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/frame_visual_properties.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/native_types.mojom
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/native_types.typemap
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/renderer.mojom
[delete] https://crrev.com/c432775b685a52d429bb6004fb7bce08dbc3d686/content/common/resize_params.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/view_messages.h
[add] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/visual_properties.cc
[rename] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/common/visual_properties.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/public/test/browser_test_utils.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/public/test/render_view_test.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/public/test/render_view_test.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/devtools/render_widget_screen_metrics_emulator.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/devtools/render_widget_screen_metrics_emulator_delegate.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_view_impl.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_view_impl.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_widget.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_widget.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_widget_browsertest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_widget_fullscreen_pepper.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/resizing_mode_selector.cc
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/renderer/resizing_mode_selector.h
[modify] https://crrev.com/799e72196268789140e9c230bfaea81a3381a718/content/test/content_browser_test_utils_internal.cc

Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)

Sign in to add a comment