New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836366 link

Starred by 4 users
Status: Fixed
Owner:
█ asimjour@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
ftirelo@chromium.org
dennishu@google.com
█ durgapandey@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Update CardUnmaskPrompt to use ModalDialogView

Project Member Reported by asimjour@chromium.org, Apr 24 2018 
AlertDialog in CardUnmaskPrompt should be replaced with ModalDialogView.

As a result CardUnmaskPrompt will look like other modal dialogs, moreover, CardUnmaskPrompt will work in VR.

Comment 1 by ma...@chromium.org, Apr 26 2018

Cc: ftirelo@chromium.org
Can you post a screenshot of before/after? thanks

Comment 2 by asimjour@chromium.org, Apr 26 2018

Labels: -Pri-2 Pri-1

Comment 3 by asimjour@chromium.org, Apr 26 2018 

I don't have a working demo right now, but I'll update this bug with screenshots as soon as I can.

Comment 4 by asimjour@chromium.org, May 2 2018 

I attached two screenshots. One with the current implementation (using AlertDialogs) and the other one is using the new CardUnmaskPrompt based on ModalDialogView.
ModalDialogView.png
176 KB View Download
AlertDialog.png
209 KB View Download

Comment 5 by ma...@chromium.org, May 2 2018 

Seems like the CONFIRM button is disabled in one, and enabled in the other?

Comment 6 by asimjour@chromium.org, May 2 2018 

This is WIP that still has some issues. I just did a quick implementation to show how it looks when we replace AlertDialogs with ModalDialogView.

Comment 7 by ma...@chromium.org, May 2 2018

Cc: dennishu@google.com durgapandey@chromium.org
Cool thanks. Adding the relevant PMs so that they are aware. If you are targeting M68, be mindful of feature freeze which is kind of soon.

Comment 8 by asimjour@chromium.org, May 15 2018

Labels: -M-68 M-69
Screenshots from the implementation based on ModalDialogView
Screenshot_20180515-124904.png
182 KB View Download
Screenshot_20180515-124840.png
177 KB View Download
Screenshot_20180515-124715.png
177 KB View Download
Screenshot_20180515-124829.png
199 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9a371b136b7d7611ea923e5e5328ead7b727602

commit e9a371b136b7d7611ea923e5e5328ead7b727602
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Mon Jun 11 14:44:44 2018

Update CardUnmaskPrompt to use ModalDialogView instead of AlertDialogs

CardUnmaskPrompt is modified to use ModalDialogView instead of
AlertDialogs. This is part of an afford to convert all instances of
modal dialogs to use ModalDialogView.

Bug:  836366 
Change-Id: I3a0b785f89b1e49768578529ba2c4a8302e8e83e
Reviewed-on: https://chromium-review.googlesource.com/1059709
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565998}
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskBridge.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/java/src/org/chromium/chrome/browser/modaldialog/ModalDialogView.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressWithoutPhoneTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExpiredLocalCardTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestExtraShippingOptionsTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFailCompleteTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIdTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoUpdateWithTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentMethodIdentifierTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRemoveBillingAddressTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServerCardTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestUseStatsTest.java
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc
[modify] https://crrev.com/e9a371b136b7d7611ea923e5e5328ead7b727602/components/test/data/payments/render_tests/PaymentRequestFreeShippingTest.unmask.Nexus_5-19.png

Comment 10 by asimjour@chromium.org, Jun 11 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment