PDF XFA: Enter key inserts a line break incorrectly in text edits |
||
Issue descriptionOn an XFA enabled build: 1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf 2. On a text edit, for example, the one under "1. Full name" "* Family name", type "abcdef". 3. Press Enter on the keyboard Expected: Either nothing or move caret to next line. Actual: All the text is moved to next line, first line is left blank.
,
Apr 26 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/051e837e08f52251de5932d90268d504060d12f1 commit 051e837e08f52251de5932d90268d504060d12f1 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Apr 26 20:07:20 2018 Fix caret moving to next line upon click on line break in XFA edit. Bug: chromium:836361 Change-Id: I40739a21a60610bd5ab0143629f87562ba834a0d Reviewed-on: https://pdfium-review.googlesource.com/31410 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> [modify] https://crrev.com/051e837e08f52251de5932d90268d504060d12f1/xfa/fde/cfde_texteditengine.cpp [modify] https://crrev.com/051e837e08f52251de5932d90268d504060d12f1/xfa/fde/cfde_texteditengine_unittest.cpp
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7953f3b0dbadc80a3cfab5e16bcef23eec838cd4 commit 7953f3b0dbadc80a3cfab5e16bcef23eec838cd4 Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 27 00:42:27 2018 Roll src/third_party/pdfium/ 789a227a6..52ab95aa3 (5 commits) https://pdfium.googlesource.com/pdfium.git/+log/789a227a635b..52ab95aa3edb $ git log 789a227a6..52ab95aa3 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 dsinclair Reset entity start when clearing text 2018-04-26 hnakashima Fix caret moving to next line upon click on line break in XFA edit. 2018-04-26 tsepez Replace some c-style cast with static_cast<> 2018-04-26 hnakashima Enter key inserts a line break correctly in XFA edits. 2018-04-26 hnakashima Improve diffing and regeneration of expected pngs. Created with: roll-dep src/third_party/pdfium BUG= chromium:836661 , chromium:836361 , chromium:836361 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ieeae5930c87aaac8c7f6ac258d9e9a1f8002d1ac Reviewed-on: https://chromium-review.googlesource.com/1031555 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554226} [modify] https://crrev.com/7953f3b0dbadc80a3cfab5e16bcef23eec838cd4/DEPS
,
Apr 27 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/f54ea0f44d53a6b1b3c4cb2c3a3285149510cccc commit f54ea0f44d53a6b1b3c4cb2c3a3285149510cccc Author: Henrique Nakashima <hnakashima@chromium.org> Date: Fri Apr 27 20:09:09 2018 Fix backspace on 1st character of a line erases the line break. Bug: chromium:836361 Change-Id: I39a0a3f9cb59ceb81f944dd5d0d4fd38a2e18a6b Reviewed-on: https://pdfium-review.googlesource.com/31411 Reviewed-by: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> [modify] https://crrev.com/f54ea0f44d53a6b1b3c4cb2c3a3285149510cccc/xfa/fwl/cfwl_edit_embeddertest.cpp [add] https://crrev.com/f54ea0f44d53a6b1b3c4cb2c3a3285149510cccc/testing/resources/xfa/xfa_multiline_textfield.in [add] https://crrev.com/f54ea0f44d53a6b1b3c4cb2c3a3285149510cccc/testing/resources/xfa/xfa_multiline_textfield.pdf [modify] https://crrev.com/f54ea0f44d53a6b1b3c4cb2c3a3285149510cccc/xfa/fwl/cfwl_edit.cpp
,
Apr 27 2018
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium/+/5ee10423d237c5bd22b8db6fe6d7b53edd0906dc commit 5ee10423d237c5bd22b8db6fe6d7b53edd0906dc Author: Henrique Nakashima <hnakashima@chromium.org> Date: Fri Apr 27 21:10:57 2018 Update caret after changes that could move lines in XFA edit. This fixes issues when a line break is deleted and the caret remains where it was, now between two lines. Bug: chromium:836361 Change-Id: I6cd40402a97348bcfc4c9291e7acb044a1e68113 Reviewed-on: https://pdfium-review.googlesource.com/31391 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> [modify] https://crrev.com/5ee10423d237c5bd22b8db6fe6d7b53edd0906dc/xfa/fwl/cfwl_edit.cpp
,
Apr 27 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a49f5c8b664b17643020fb17acf79052e743099b commit a49f5c8b664b17643020fb17acf79052e743099b Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 27 23:32:10 2018 Roll src/third_party/pdfium/ 3241bb3e9..65c255ad2 (18 commits) https://pdfium.googlesource.com/pdfium.git/+log/3241bb3e98c0..65c255ad2076 $ git log 3241bb3e9..65c255ad2 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 tsepez Fix illegal cast in core/fxge/win32/fx_win32_gdipext.cpp 2018-04-27 thestig Remove CJBig2_HuffmanTable::InitCodes(). 2018-04-27 tsepez Replace void* with CFX_GifPalette* in fxcodec 2018-04-27 hnakashima Fix focused day disappears in XFA MonthCalendar. 2018-04-27 hnakashima Update caret after changes that could move lines in XFA edit. 2018-04-27 thestig Change CJBig2_HuffmanTable to use struct JBig2HuffmanCode. 2018-04-27 thestig Adjust CJBig2_Context::HuffmanAssignCode(). 2018-04-27 tsepez Remove arguments from CPDFSDK_FormFillEnvironment methods (part 2) 2018-04-27 thestig Simplify CJBig2_Context::DecodeSymbolIDHuffmanTable(). 2018-04-27 thestig Use std::function in CJBig2_GRDProc. 2018-04-27 hnakashima Fix backspace on 1st character of a line erases the line break. 2018-04-27 thestig Disambiguate methods in CJBig2_GRDProc. 2018-04-27 thestig Simplify CJBig2_Context::FindReferredSegmentByTypeAndIndex(). 2018-04-27 tsepez Avoid potential duplicate unique_ptr to CPDF_Document from CPDFXA_Context. 2018-04-27 tsepez Remove argument from CPDFSDK_FormFillEnvironment::GetCurrentPage 2018-04-27 thestig Add DEPS include_rules for xfa/fwl. 2018-04-27 thestig Fix undefined behavior in AGG. 2018-04-27 thestig Do validation earlier in CPDF_SampledFunc::v_Init(). (try 2) Created with: roll-dep src/third_party/pdfium BUG= chromium:836361 , chromium:709781 , chromium:836361 ,chromium:746232 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3f93d2671a6cc6f854854c61eea6104ae84cc21e Reviewed-on: https://chromium-review.googlesource.com/1033831 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554557} [modify] https://crrev.com/a49f5c8b664b17643020fb17acf79052e743099b/DEPS
,
May 2 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Apr 26 2018