Incorrect auto-revert |
||||
Issue descriptionPage URL: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlNWEyYTM4Yjg3N2NkNzk3YzJlNjJjMzcxOTQ2Nzg5Y2RkMTU0YzMM Description: This commit couldn't possibly affect a compile step on a buildbot. The change was for an experimental iOS LUCI builder, which is failing now because of the revert, so FindIt effectively made things worse.
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
Relanding the original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1025183
,
Apr 24 2018
Thanks for relanding the CL! Quick UX feedback: I found it a bit hard to figure out how to file this feedback (had to click through a couple of pages and look really hard for the "?!" icon) - it would be great to have a more visible button to report incorrect reverts, and possibly a button for auto-relanding the CL (could be the same button that does both). In my case, I couldn't revert from the Gerrit UI - possibly because I don't have some permissions in that repo (?), so relanding through FindIt would've helped. Thanks!
,
Apr 24 2018
Thank you for your feedback. In the revert CL (https://chromium-review.googlesource.com/c/chromium/src/+/1025284), there is a comment from Findit with a guidance on how to handle false positives and a link to report false results. Could you take a look and let us know if that's the information can serve your need? Thanks.
,
Apr 24 2018
Sorry, I didn't find the link... I saw this text: Findit (https://goo.gl/kROfz5) identified CL at revision 553160 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlNWEyYTM4Yjg3N2NkNzk3YzJlNjJjMzcxOTQ2Nzg5Y2RkMTU0YzMM Neither of the two links seems to have info on false positives... It's possible I'm missing something obvious, but I just looked again, and I still can't see it.
,
Apr 24 2018
Oh the text you saw is from the CL description, right. What I meant is a comment from Findit instead. I also attached a screenshot of the comment.
,
Apr 24 2018
Ohh... Right! I didn't see the comment - was looking at the revert CL in a hurry. Thanks for pointing that out!
,
May 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by st...@chromium.org
, Apr 24 2018