Informtaional pfqs failing BuildPackages |
|||||||||
Issue descriptionhttps://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8948345473588148432 chromeos-chrome-68.0.3406.0_alpha-r1: [0m * GN_ARGS = is_debug=false use_v4l2_codec=true use_v4lplugin=false use_vaapi=true use_ozone=true use_evdev_gestures=true use_xkbcommon=true linux_use_bundled_binutils=false use_debug_fission=false enable_remoting=true enable_nacl=true icu_use_data_file=true use_cras=true use_system_harfbuzz=true use_system_freetype=true use_system_libsync=true use_cups=true use_jumbo_build=false use_bundled_fontconfig=false is_asan=false is_clang=true cros_host_is_clang=true clang_use_chrome_plugins=false use_thin_lto=false use_lld=false is_cfi=false use_cfi_cast=false ozone_auto_platforms=false ozone_platform_gbm=true use_system_minigbm=true use_system_libdrm=true treat_warnings_as_errors=false use_goma=true use_debug_fission=true symbol_level=2 target_sysroot="/build/amd64-generic" system_libdir="lib64" pkg_config="/build/amd64-generic/build/bin/pkg-config" target_os="chromeos" host_pkg_config="x86_64-pc-linux-gnu-pkg-config" ozone_platform="gbm" target_cpu="x64" goma_dir="/home/chrome-bot/goma" cros_target_ar="llvm-ar" cros_target_cc="x86_64-cros-linux-gnu-clang -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold" cros_target_cxx="x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold" host_toolchain="//build/toolchain/cros:host" custom_toolchain="//build/toolchain/cros:target" v8_snapshot_toolchain="//build/toolchain/cros:v8_snapshot" cros_target_ld="x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold" cros_target_extra_cflags="-pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -fdebug-info-for-profiling -Wno-unknown-warning-option " cros_target_extra_cppflags="" cros_target_extra_cxxflags="-pipe -pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++ " cros_target_extra_ldflags="-Wl,-O1 -Wl,-O2 -Wl,--as-needed -stdlib=libc++ " cros_host_cc="x86_64-pc-linux-gnu-clang -B/usr/bin" cros_host_cxx="x86_64-pc-linux-gnu-clang++ -B/usr/bin" cros_host_ar="llvm-ar" cros_host_ld="x86_64-pc-linux-gnu-clang++" cros_host_extra_cflags=" -Wno-unknown-warning-option" cros_host_extra_cxxflags=" -Wno-unknown-warning-option" cros_host_extra_cppflags="" cros_host_extra_ldflags="" cros_v8_snapshot_cc="x86_64-pc-linux-gnu-clang -B/usr/bin" cros_v8_snapshot_cxx="x86_64-pc-linux-gnu-clang++ -B/usr/bin" cros_v8_snapshot_ar="llvm-ar" cros_v8_snapshot_ld="x86_64-pc-linux-gnu-clang++" cros_v8_snapshot_extra_cflags=" -Wno-unknown-warning-option" cros_v8_snapshot_extra_cxxflags=" -Wno-unknown-warning-option" cros_v8_snapshot_extra_cppflags="" cros_v8_snapshot_extra_ldflags="" chromeos-chrome-68.0.3406.0_alpha-r1: [31m[1mERROR [0mat //components/nacl/features.gni:13:7: Undefined identifier chromeos-chrome-68.0.3406.0_alpha-r1: [2m checkout_nacl && !is_ios && !is_android && !is_fuchsia && chromeos-chrome-68.0.3406.0_alpha-r1: [0m[34m[1m ^------------ chromeos-chrome-68.0.3406.0_alpha-r1: [0mSee //BUILD.gn:15:1: whence it was imported. chromeos-chrome-68.0.3406.0_alpha-r1: [2mimport("//components/nacl/features.gni") chromeos-chrome-68.0.3406.0_alpha-r1: [0m[34m[1m^-------------------------------------- chromeos-chrome-68.0.3406.0_alpha-r1: [0m * ERROR: chromeos-base/chromeos-chrome-68.0.3406.0_alpha-r1::chromiumos failed (configure phase): chromeos-chrome-68.0.3406.0_alpha-r1: * (no error message) chromeos-chrome-68.0.3406.0_alpha-r1: * chromeos-chrome-68.0.3406.0_alpha-r1: * Call stack: chromeos-chrome-68.0.3406.0_alpha-r1: * ebuild.sh, line 133: Called src_configure chromeos-chrome-68.0.3406.0_alpha-r1: * environment, line 4308: Called die chromeos-chrome-68.0.3406.0_alpha-r1: * The specific snippet of code: chromeos-chrome-68.0.3406.0_alpha-r1: * ${EGN} gen "${CHROME_ROOT}/src/${BUILD_OUT_SYM}/${BUILDTYPE}" --args="${GN_ARGS}" --root="${CHROME_ROOT}/src" || die;
,
Apr 25 2018
,
Apr 25 2018
Yes, that could be the cause. I had to land https://webrtc-review.googlesource.com/72040 because https://chromium-review.googlesource.com/c/chromium/src/+/1022741 was breaking the Chromium Roll into WebRTC. I tried to add checkout_nacl to the WebRTC DEPS file but that doesn't work. Adding jbudorick@ who worked on this in crbug.com/834964 . To temporarily fix we could wrap https://cs.chromium.org/chromium/src/build/config/android/config.gni?l=13 (and the import of //build/config/gclient_args.gni) into a "if (build_with_chromium)". But this seems an interesting feature that we in WebRTC would like to use. The long term fix would be avoid to overwrite the content of //build/config/gclient_args.gni and just merge it.
,
Apr 25 2018
,
Apr 25 2018
,
Apr 25 2018
Please don't leave things as started when reassigning them. My inclination is that this is something we should fix on the webrtc side. Looking further.
,
Apr 25 2018
Need to think about what a better fix looks like here, but I guess I'm ok w/ the workaround suggested in #3 + reverting the webrtc CL to fix cros.
,
Apr 25 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1028571 will revert https://webrtc-review.googlesource.com/72040 once that lands & rolls into webrtc
,
Apr 25 2018
Thanks! :)
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4a580dfaca15a8824d1f0ddfdd233ae660587ce commit c4a580dfaca15a8824d1f0ddfdd233ae660587ce Author: John Budorick <jbudorick@chromium.org> Date: Wed Apr 25 23:32:06 2018 Guard checkout_android gclient check w/ build_with_chromiuim. Un-breaking WebRTC to let them revert a CL to un-break CrOS. TBR=agrieve@chromium.org Bug: 836344 Change-Id: I48abc7353825571873f63f37af54026db6c429c8 Reviewed-on: https://chromium-review.googlesource.com/1028571 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553822} [modify] https://crrev.com/c4a580dfaca15a8824d1f0ddfdd233ae660587ce/build/config/android/config.gni
,
Apr 26 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/f364cd7541b7b688afe48db60709850ad11e2a41 commit f364cd7541b7b688afe48db60709850ad11e2a41 Author: Mirko Bonadei <mbonadei@webrtc.org> Date: Thu Apr 26 14:52:15 2018 Revert "Adding gclient_gn_args_file to WebRTC DEPS." This reverts commit f0e88d4601a7cdbb97359dae18bb1f01ee18e99f. Reason for revert: This should not be needed after: https://chromium-review.googlesource.com/1028571 Original change's description: > Adding gclient_gn_args_file to WebRTC DEPS. > > In order to unblock the Chromium Roll into WebRTC this CL tells gclient > to generate build/config/gclient_args.gni with the value of > checkout_android. > > Bug: None > Change-Id: Iaca047ab5886545d0c9f3228099d8e8a914842e4 > Reviewed-on: https://webrtc-review.googlesource.com/72040 > Reviewed-by: Oleh Prypin <oprypin@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22996} No-Try: True Bug: chromium:836344 Change-Id: Ief0ca65b63e80bcb1d379f667d1e55e7d665d546 Reviewed-on: https://webrtc-review.googlesource.com/72680 Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23033} [modify] https://crrev.com/f364cd7541b7b688afe48db60709850ad11e2a41/DEPS
,
Apr 26 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bb157b379b5695efd06b22d78746195a7d16630 commit 5bb157b379b5695efd06b22d78746195a7d16630 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Apr 27 00:59:53 2018 Roll src/third_party/webrtc/ 775d07e27..e782abab1 (13 commits) https://webrtc.googlesource.com/src.git/+log/775d07e27769..e782abab190e $ git log 775d07e27..e782abab1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG= chromium:835281 ,chromium:None,chromium:none,chromium:833801,chromium:None,chromium:836344 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I13862900de88f1441e209ddca59dd0a2984d7810 Reviewed-on: https://chromium-review.googlesource.com/1031110 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554243} [modify] https://crrev.com/5bb157b379b5695efd06b22d78746195a7d16630/DEPS
,
Apr 27 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tbarzic@chromium.org
, Apr 25 2018Owner: mbonadei@chromium.org
Status: Assigned (was: Untriaged)