This is mostly complete at https://chromium-review.googlesource.com/c/chromium/src/+/1012575

 Issue 837850  has been merged into this issue.

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Colin, this is RBB so is pretty high priority. Assigning to you while Jacob is OOO.

+elizabethchiu@, zalcorn@, 

This CL [1] adds the functionality. Will need another CL to update the string/spec if necessary.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1036800

Colin are there any changes from the functionality on webview sign-in? If not, no string/spec changes necessary.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/767a9f354685c28fae8251ee93643d0673dd60a2

commit 767a9f354685c28fae8251ee93643d0673dd60a2
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed May 02 21:20:55 2018

cros: Add re-auth support for views-based login (Part I)

1) Added a new auth method |AUTH_ONLINE_SIGN_IN|. There's no transition
   between this auth method and others (except for AUTH_NONE).

2) Because the existing code in |LoginAuthUserView| accesses
   |LoginScreenController| directly, think there's no need to add
   the click callback to |LoginAuthUserView::Callbacks|.

3) The //chrome portion of this CL is borrowed from
   https://chromium-review.googlesource.com/c/chromium/src/+/1012575
   which is on a slightly different issue.

4) Will need a follow-up CL to update the spec.

Bug:  836336 
Change-Id: Ic604c6c0f5f53533f824b5c0089f44dfdbeb7f73
Reviewed-on: https://chromium-review.googlesource.com/1036800
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555548}
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/login_screen_controller.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/login_screen_controller.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/login_auth_user_view_unittest.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/screens/gaia_view.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/767a9f354685c28fae8251ee93643d0673dd60a2/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

Re #10, there's no functionality change, but the current message is not informative enough and there was discussion for changing that this long time ago.

We'll use the same message for now and will update it if a new message is available.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d61bda19d1f0883accf841e5f0e280fead3f48aa

commit d61bda19d1f0883accf841e5f0e280fead3f48aa
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri May 04 20:23:04 2018

cros: Update re-auth message UI

1) Update the UI to be the same with the web-ui implementation.

2) Add a button to lock_debug_view.cc|h for easy debugging.

Bug:  836336 
Change-Id: I89143c7db149dea31bc6848de18e6ecc6386f98b
Reviewed-on: https://chromium-review.googlesource.com/1044746
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556174}
[modify] https://crrev.com/d61bda19d1f0883accf841e5f0e280fead3f48aa/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/d61bda19d1f0883accf841e5f0e280fead3f48aa/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/d61bda19d1f0883accf841e5f0e280fead3f48aa/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/d61bda19d1f0883accf841e5f0e280fead3f48aa/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/d61bda19d1f0883accf841e5f0e280fead3f48aa/ash/login/ui/login_auth_user_view_unittest.cc