New issue
Advanced search Search tips

Issue 836327 link

Starred by 4 users
Status: Assigned
Owner:
robliao@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Implement NativeWidgetMac::Maximize() and IsMaximized()

Project Member Reported by robliao@chromium.org, Apr 24 2018 
Discovered by the following interactive_ui_test tests:
DevToolsManagerDelegateTest.MaximizedToMinimizedWindow
DevToolsManagerDelegateTest.NormalToMaximizedWindow
DevToolsManagerDelegateTest.RestoreMaximizedWindow

A quick implementation is available at
https://chromium-review.googlesource.com/c/chromium/src/+/1022958

and breaks the following tests

interactive_ui_tests:
WidgetTestInteractive.ShowInactiveAfterShow
WidgetTestInteractive.ShowAfterShowInactive
WidgetTestInteractive.ShowInactive
WidgetTestInteractive.InactiveWidgetDoesNotGrabActivation
WidgetTestInteractive.ShowCreatesActiveWindow

views_unittests:
CustomFrameViewTest.MaximizeRevealsRestoreButton
NativeWidgetMacTest.MiniaturizeExternally
CustomFrameViewTest.LargerEdgeButtonsWhenMaximized
WidgetTest.GetRestoredBounds

CustomFrameViewTest.MaximizeRevealsRestoreButton and CustomFrameViewTest.LargerEdgeButtonsWhenMaximized are fixed after updating the test expectations to account for the new maximization support in Mac (removing the defined(OS_MACOSX) changes)
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a37e38a995162b843f7f45fcfcb09f7ac7c8b9

commit a8a37e38a995162b843f7f45fcfcb09f7ac7c8b9
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Apr 25 17:09:11 2018

extensions: disable ExtensionWindowCreateTest AcceptState on Mac

This test needs the not-yet-implemented fullscreen behavior described
in the linked bug.

TBR=rdevlin.cronin@chromium.org

Bug: 836327
Change-Id: Id383aa9e5092cf707119f1940978965027479853
Reviewed-on: https://chromium-review.googlesource.com/1028176
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553604}
[modify] https://crrev.com/a8a37e38a995162b843f7f45fcfcb09f7ac7c8b9/chrome/browser/extensions/api/tabs/tabs_test.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28e33c40d42bdabd4f0f525b05d9afe0cce48f38

commit 28e33c40d42bdabd4f0f525b05d9afe0cce48f38
Author: Robert Liao <robliao@chromium.org>
Date: Wed Apr 25 18:28:17 2018

Disable DevToolsManagerDelegateTest Tests That Rely on Maximization for Mac

MacViews does not yet implement maximized windows and a trivial
implementation doesn't seem to work.

BUG=834754,836327

Change-Id: I4fd6fbd4295134053cc58d028d0c2397088150a8
Reviewed-on: https://chromium-review.googlesource.com/1026350
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553668}
[modify] https://crrev.com/28e33c40d42bdabd4f0f525b05d9afe0cce48f38/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc

Comment 3 by ellyjo...@chromium.org, Apr 26 2018

Labels: M-68 MacViews-Browser Target-68
Status: Assigned (was: Available)

Comment 4 by gov...@chromium.org, May 22 2018 

M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.

Comment 5 by robliao@chromium.org, May 23 2018

Labels: -Pri-1 Pri-2
This primarily has test impact. Adjusting to P2.

Comment 6 by robliao@chromium.org, Jun 20 2018

Labels: -Target-68 Target-69

Comment 7 by robliao@chromium.org, Jul 12

Labels: -M-68 Group-MacOS_Platform_Integration_and_Participation

Comment 8 by robliao@chromium.org, Jul 12

Labels: M-68

Comment 9 by robliao@chromium.org, Jul 26

Labels: -M-68 M-69

Comment 10 by robliao@chromium.org, Jul 27

Labels: -M-69 -Target-69 Target-70 M-70
►

Sign in to add a comment