New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836310 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Implement shouldYield behind a flag

Project Member Reported by npm@chromium.org, Apr 24 2018

Issue description

Per feedback from Facebook at BlinkOn, we'd like to implement a shouldYield() method which returns a bool indicating to the frame whether it should pause its current task so that the browser can perform some high priority tasks (coming from user input). For now, this should be under a experimental flag, as it will be used by them to experiment potential benefits from having such a flag.
 

Comment 1 by npm@chromium.org, Apr 24 2018

Labels: -Type-Bug Type-Feature
Cc: n...@fb.com skyos...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b0b3e86563ff59e357bdf0c4eed1c79b509f301

commit 9b0b3e86563ff59e357bdf0c4eed1c79b509f301
Author: Nicolas Pena <npm@chromium.org>
Date: Fri May 25 21:59:22 2018

Add experimental performance.shouldYield()

Bug:  836310 
Change-Id: Ib2d8796129e34c22c922e21b492e474130ea4420
Reviewed-on: https://chromium-review.googlesource.com/1057434
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562029}
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/WebKit/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/manual_tests/performance-shouldYield.html
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/renderer/core/timing/performance.h
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/renderer/core/timing/performance.idl
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/renderer/core/timing/window_performance.cc
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/9b0b3e86563ff59e357bdf0c4eed1c79b509f301/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 4 by npm@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment