New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836303 link

Starred by 5 users
Status: Fixed
Owner:
aee@chromium.org
Closed: May 2018
Cc:
aee@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ scottchen@chromium.org
█ msrchandra@chromium.org
█ vamshi.k...@techmahindra.com
█ dschuyler@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[MD-Settings] Scroll position after delete in a long list

Project Member Reported by namratakannan@chromium.org, Apr 24 2018 
Chrome Version: 65.0.3325.181 
OS: Mac OS

What steps will reproduce the problem?
(1) Go to Settings->Passwords and Forms->Manage passwords 
(2) Try deleting a password from the Never saved list 
(3) After removing an item from the list, the list scrolls to the top.

This behavior is also found in:     
chrome://settings/siteData

What is the expected result?
The list should maintain Scroll position

Comment 1 by dpa...@chromium.org, Apr 24 2018

Cc: scottchen@chromium.org
Components: UI>Settings
Labels: OS-Chrome OS-Linux OS-Windows
Status: Available (was: Untriaged)
I am guessing this is an artifact of using iron-list.

@Scott: Have we solved this elsewhere? Maybe we need to add preserve-focus attribute here? Or is this happening because the entire list is being re-rendered?

Comment 2 by aee@chromium.org, May 1 2018

Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 3 by aee@chromium.org, May 3 2018

Cc: nyerramilli@chromium.org dschuyler@chromium.org aee@chromium.org rbasuvula@chromium.org
 Issue 839264  has been merged into this issue.

Comment 4 by aee@chromium.org, May 9 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79911889545c81db13572295c2dff37120c7da1d

commit 79911889545c81db13572295c2dff37120c7da1d
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed May 09 22:03:07 2018

Settings: update a list property with splices and use notifySplices to notify once

Bug:  836303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia90801ff9d33b92d31abea4b3f65ad189d8cb72c
Reviewed-on: https://chromium-review.googlesource.com/1044764
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557337}
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/BUILD.gn
[add] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/list_property_update_behavior.html
[add] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/list_property_update_behavior.js
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.js
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/79911889545c81db13572295c2dff37120c7da1d/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Comment 6 by aee@chromium.org, May 9 2018

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36974ec901ce4d41289aa2306fbecb101e9d8019

commit 36974ec901ce4d41289aa2306fbecb101e9d8019
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Mon May 14 20:05:22 2018

Settings: moving ListPropertyUpdateBehavior to webui so bookmark and other pages can use it

Bug:  836303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iecad80fe56c5cd92721a5ae5408e0cef3da22d36
Reviewed-on: https://chromium-review.googlesource.com/1055807
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558429}
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/md_bookmarks/BUILD.gn
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/md_bookmarks/list.html
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/settings/BUILD.gn
[delete] https://crrev.com/e1f94ae515f601ac803f3db579b8eae7f456c213/chrome/browser/resources/settings/list_property_update_behavior.html
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/settings/site_settings/BUILD.gn
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/ui/webui/resources/cr_polymer_resources.grdp
[add] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/ui/webui/resources/html/list_property_update_behavior.html
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/ui/webui/resources/js/BUILD.gn
[modify] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/ui/webui/resources/js/compiled_resources2.gyp
[rename] https://crrev.com/36974ec901ce4d41289aa2306fbecb101e9d8019/ui/webui/resources/js/list_property_update_behavior.js

Comment 8 by vamshi.kommuri@chromium.org, May 15 2018 

Verified the fix on Mac 10.13.1 and Ubuntu 14.04 using Chrome version #68.0.3431.0 as per the comment #0.
Note: Unable to test on Windows 32 & 64 due to issue crbug/843012
Attaching screen cast for reference.
Observed that the page didn't scroll after deleting an entry/item.
Hence, the fix is working as expected. 
Note: Able to reproduce the issue on chrome version 65.0.3325.181.
Thanks...!!

Comment 9 by vamshi.kommuri@chromium.org, May 15 2018

836303 CL Verification.mp4
929 KB View Download

Comment 10 by aee@chromium.org, Jul 26

Cc: vamshi.k...@techmahindra.com
 Issue 774832  has been merged into this issue.

Comment 11 by aee@chromium.org, Jul 26

Cc: jmukthavaram@chromium.org hcarmona@chromium.org msrchandra@chromium.org ranjitkan@chromium.org
 Issue 727279  has been merged into this issue.
►

Sign in to add a comment