reinserting-svg-into-document.html flaky on win |
||||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=svg%2Fanimations%2Freinserting-svg-into-document.html smcgruer@: could you take a quick look as it is put under animation.
,
Apr 24 2018
Looks like an old test that still uses setTimeout (actually, looks like a *lot* of the svg tests still do :(...) and on Windows the timeout was delayed. I will attempt to figure out a way to fix the test.
,
Apr 24 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c2d1550cb8ace4b6511679dc1a8f8b4c67d8484 commit 3c2d1550cb8ace4b6511679dc1a8f8b4c67d8484 Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Apr 26 15:02:20 2018 Fix flake in svg/animations/reinserting-svg-into-document.html This test was very old, and appeared to rely on setTimeout(func, 1) taking close enough to 1ms for the following to hold: setCurrentTime(1); // Note this is seconds. setTimeout(function() { getCurrentTime() ~= 1 }, 1); This is not guaranteed by setTimeout, however, and occasionally in LayoutTest runs the setTimeout took long enough that the behavior didn't hold. This CL updates the test to only require that the currentTime is >= what was previously set, which will hold. Alongside this, I also: * Converted the test to the modern jsharness style, * Removed the outer setTimeout which didn't seem required at all, and * Replaced the inner setTimeout with a requestAnimationFrame Bug: 836295 Change-Id: I8d5fc2b3ed544b3085b999efeb37979e8d070a5b Reviewed-on: https://chromium-review.googlesource.com/1025855 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#554031} [modify] https://crrev.com/3c2d1550cb8ace4b6511679dc1a8f8b4c67d8484/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/544122c6009ae3e632e9346223716df3e83ee68d/third_party/WebKit/LayoutTests/svg/animations/reinserting-svg-into-document-expected.txt [modify] https://crrev.com/3c2d1550cb8ace4b6511679dc1a8f8b4c67d8484/third_party/WebKit/LayoutTests/svg/animations/reinserting-svg-into-document.html
,
Apr 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 24 2018