New issue
Advanced search Search tips

Issue 836294 link

Starred by 2 users
Status: Assigned
Owner:
fdoray@chromium.org
Cc:
ellyjo...@chromium.org
erikc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

TabStripControllerTest always fails on first pass, then apsses on retry.

Project Member Reported by erikc...@chromium.org, Apr 24 2018 
unit_tests log from 10.13 waterfall:
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8948355173773264208%2F%2B%2Fsteps%2Funit_tests%2F0%2Fstdout

"""
[84202:775:0424/074401.093309:19803102688845:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.SelectTab
[84202:775:0424/074401.093390:19803102766831:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.RearrangeTabs
[84202:775:0424/074401.093450:19803102826140:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.CorrectMouseHoverBehavior
[84202:775:0424/074401.093490:19803102866585:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.CorrectTitleAndToolTipTextFromSetTabTitle
[84202:775:0424/074401.093532:19803102908661:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.TabCloseDuringDrag
[84202:775:0424/074401.093571:19803102946340:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.ViewAccessibility_Contents
[84202:775:0424/074401.093607:19803102982861:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.ViewAccessibility_Value
[84202:775:0424/074401.093644:19803103020360:ERROR:unit_test_launcher.cc(338)] no test result for TabStripControllerTest.CorrectWindowFromUpdateWindowAlertState
[84202:775:0424/074401.093688:19803103064886:ERROR:unit_test_launcher.cc(338)] no test result for TabStripViewTest.TabStripViewTest_TestViewMacroAddRemove
[7364/8905] TabStripControllerTest.DeselectInactiveTab (321 ms)
[ RUN      ] TabStripControllerTest.SelectTab
[85011:775:0424/074400.863880:19802873248045:FATAL:sequenced_task_runner_handle.cc(33)] Check failed: ThreadTaskRunnerHandle::IsSet(). Error: This caller requires a sequenced context (i.e. the current task needs to run from a SequencedTaskRunner).
0   unit_tests                          0x0000000112d963ac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   unit_tests                          0x0000000112d0330f logging::LogMessage::~LogMessage() + 223
2   unit_tests                          0x0000000112d66925 base::SequencedTaskRunnerHandle::Get() + 213
3   unit_tests                          0x0000000112529895 mojo::internal::GetTaskRunnerToUseFromUserProvidedTaskRunner(scoped_refptr<base::SingleThreadTaskRunner>) + 37
4   unit_tests                          0x0000000112520d12 mojo::internal::InterfacePtrStateBase::Bind(mojo::ScopedHandleBase<mojo::MessagePipeHandle>, unsigned int, scoped_refptr<base::SingleThreadTaskRunner>) + 98
5   unit_tests                          0x000000011311ecba mojo::InterfacePtr<resource_coordinator::mojom::PageSignalGenerator>::Bind(mojo::InterfacePtrInfo<resource_coordinator::mojom::PageSignalGenerator>, scoped_refptr<base::SingleThreadTaskRunner>) + 154
6   unit_tests                          0x000000011311e3a4 resource_coordinator::PageSignalReceiver::AddObserver(resource_coordinator::PageSignalObserver*) + 292
7   unit_tests                          0x00000001131d323f resource_coordinator::TabManager::TabManager() + 527
8   unit_tests                          0x00000001123ed00f TestingBrowserProcess::GetTabManager() + 47
9   unit_tests                          0x000000011072a34d testing::internal::TestEventRepeater::OnTestStart(testing::TestInfo const&) + 61
10  unit_tests                          0x0000000110726dd1 testing::TestInfo::Run() + 81
11  unit_tests                          0x0000000110727427 testing::TestCase::Run() + 279
12  unit_tests                          0x0000000110732a67 testing::internal::UnitTestImpl::RunAllTests() + 855
13  unit_tests                          0x00000001107326ee testing::UnitTest::Run() + 110
14  unit_tests                          0x00000001123fc317 base::TestSuite::Run() + 167
15  unit_tests                          0x0000000112409b2c base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 284
16  unit_tests                          0x00000001124099e0 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 160
17  unit_tests                          0x00000001123f2c5d main + 285
18  libdyld.dylib                       0x00007fff7e0d3115 start + 1
19  ???                                 0x0000000000000008 0x0 + 8
[7365/8905] TabStripControllerTest.SelectTab (UNKNOWN)
[7366/8905] TabStripControllerTest.RearrangeTabs (UNKNOWN)
[7367/8905] TabStripControllerTest.CorrectMouseHoverBehavior (UNKNOWN)
[7368/8905] TabStripControllerTest.CorrectTitleAndToolTipTextFromSetTabTitle (UNKNOWN)
[7369/8905] TabStripControllerTest.TabCloseDuringDrag (UNKNOWN)
[7370/8905] TabStripControllerTest.ViewAccessibility_Contents (UNKNOWN)
[7371/8905] TabStripControllerTest.ViewAccessibility_Value (UNKNOWN)
[7372/8905] TabStripControllerTest.CorrectWindowFromUpdateWindowAlertState (UNKNOWN)
"""

This repros on ToT

Comment 1 by erikc...@chromium.org, Apr 24 2018

Cc: erikc...@chromium.org
Owner: fdoray@chromium.org
It looks like there are other test suites that have the same problem, e.g.

"""
[84202:775:0424/074316.221978:19758229355796:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.AddRemoveObserversDisallowJavascript
[84202:775:0424/074316.222061:19758229436190:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.AddRemoveObserversSyncDisabled
[84202:775:0424/074316.222104:19758229477812:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.RepeatedHandleRegisterForPerTypeCounters
[84202:775:0424/074316.222147:19758229521160:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.HandleGetAllNodes
[84202:775:0424/074316.222183:19758229556716:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.SendAboutInfo
[84202:775:0424/074316.222217:19758229590803:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.SendAboutInfoSyncDisabled
[84202:775:0424/074316.222255:19758229628665:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.WriteUserEvent
[84202:775:0424/074316.222303:19758229676510:ERROR:unit_test_launcher.cc(338)] no test result for SyncInternalsMessageHandlerTest.WriteUserEventBadParse
[3761/8905] SiteSettingsHelperTest.ContentSettingSource (96 ms)
[3762/8905] SyncInternalsMessageHandlerTest.AddRemoveObservers (17 ms)
[ RUN      ] SyncInternalsMessageHandlerTest.AddRemoveObserversDisallowJavascript
[84597:775:0424/074316.076006:19758083386319:FATAL:sequenced_task_runner_handle.cc(33)] Check failed: ThreadTaskRunnerHandle::IsSet(). Error: This caller requires a sequenced context (i.e. the current task needs to run from a SequencedTaskRunner).
0   unit_tests                          0x00000001097533ac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   unit_tests                          0x00000001096c030f logging::LogMessage::~LogMessage() + 223
2   unit_tests                          0x0000000109723925 base::SequencedTaskRunnerHandle::Get() + 213
3   unit_tests                          0x0000000108ee6895 mojo::internal::GetTaskRunnerToUseFromUserProvidedTaskRunner(scoped_refptr<base::SingleThreadTaskRunner>) + 37
4   unit_tests                          0x0000000108eddd12 mojo::internal::InterfacePtrStateBase::Bind(mojo::ScopedHandleBase<mojo::MessagePipeHandle>, unsigned int, scoped_refptr<base::SingleThreadTaskRunner>) + 98
5   unit_tests                          0x0000000109adbcba mojo::InterfacePtr<resource_coordinator::mojom::PageSignalGenerator>::Bind(mojo::InterfacePtrInfo<resource_coordinator::mojom::PageSignalGenerator>, scoped_refptr<base::SingleThreadTaskRunner>) + 154
6   unit_tests                          0x0000000109adb3a4 resource_coordinator::PageSignalReceiver::AddObserver(resource_coordinator::PageSignalObserver*) + 292
7   unit_tests                          0x0000000109b9023f resource_coordinator::TabManager::TabManager() + 527
8   unit_tests                          0x0000000108daa00f TestingBrowserProcess::GetTabManager() + 47
9   unit_tests                          0x00000001070e734d testing::internal::TestEventRepeater::OnTestStart(testing::TestInfo const&) + 61
10  unit_tests                          0x00000001070e3dd1 testing::TestInfo::Run() + 81
11  unit_tests                          0x00000001070e4427 testing::TestCase::Run() + 279
12  unit_tests                          0x00000001070efa67 testing::internal::UnitTestImpl::RunAllTests() + 855
13  unit_tests                          0x00000001070ef6ee testing::UnitTest::Run() + 110
14  unit_tests                          0x0000000108db9317 base::TestSuite::Run() + 167
15  unit_tests                          0x0000000108dc6b2c base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 284
16  unit_tests                          0x0000000108dc69e0 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 160
17  unit_tests                          0x0000000108dafc5d main + 285
18  libdyld.dylib                       0x00007fff7e0d3115 start + 1
19  ???                                 0x0000000000000008 0x0 + 8
[3763/8905] SyncInternalsMessageHandlerTest.AddRemoveObserversDisallowJavascript (UNKNOWN)
[3764/8905] SyncInternalsMessageHandlerTest.AddRemoveObserversSyncDisabled (UNKNOWN)
[3765/8905] SyncInternalsMessageHandlerTest.RepeatedHandleRegisterForPerTypeCounters (UNKNOWN)
[3766/8905] SyncInternalsMessageHandlerTest.HandleGetAllNodes (UNKNOWN)
[3767/8905] SyncInternalsMessageHandlerTest.SendAboutInfo (UNKNOWN)
[3768/8905] SyncInternalsMessageHandlerTest.SendAboutInfoSyncDisabled (UNKNOWN)
[3769/8905] SyncInternalsMessageHandlerTest.WriteUserEvent (UNKNOWN)
[3770/8905] SyncInternalsMessageHandlerTest.WriteUserEventBadParse (UNKNOWN)
"""

Over to OWNER of this class/code.
►

Sign in to add a comment