New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836292 link

Starred by 2 users
Status: Verified
Owner:
█ asimjour@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
dougman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR Browsing] <select> lists are not scroll-able

Project Member Reported by dbbrooks@chromium.org, Apr 24 2018 
Chrome Version: 68.0.3404.0
OS: Android O
Device: Pixel XL


(1) Navigate to https://rsolomakhin.github.io/autofill/
(2) Enter VR Browsing
(3) Open the State list. 
(4) Try to scroll to select one of the states further in the list. 

What is the expected result? Should be able to scroll to select items at end of list.

What happens instead? I can't scroll in the <select> list popups.

Comment 1 by ericde@google.com, Apr 24 2018

Labels: M-67

Comment 2 by asimjour@chromium.org, Apr 25 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/480d1516022c82afad0696259a94dee364a61890

commit 480d1516022c82afad0696259a94dee364a61890
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Wed May 02 17:30:21 2018

Scroll support for hosted dialogs in VR

Now that VR supports html <select>, we should send scroll events
to dialogs.

Bug:  836292 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288
Reviewed-on: https://chromium-review.googlesource.com/1028584
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555454}
[modify] https://crrev.com/480d1516022c82afad0696259a94dee364a61890/chrome/browser/android/vr/vr_dialog.cc
[modify] https://crrev.com/480d1516022c82afad0696259a94dee364a61890/chrome/browser/android/vr/vr_dialog.h
[modify] https://crrev.com/480d1516022c82afad0696259a94dee364a61890/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/480d1516022c82afad0696259a94dee364a61890/chrome/browser/vr/content_input_delegate.h
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8195de59fc533997e9f692530a03c9c5f9b3aa4

commit d8195de59fc533997e9f692530a03c9c5f9b3aa4
Author: Matthew Jones <mdjones@chromium.org>
Date: Wed May 02 23:02:17 2018

Revert "Scroll support for hosted dialogs in VR"

This reverts commit 480d1516022c82afad0696259a94dee364a61890.

Reason for revert: Suspected cause of Nougat Phone Tester failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6164

Original change's description:
> Scroll support for hosted dialogs in VR
> 
> Now that VR supports html <select>, we should send scroll events
> to dialogs.
> 
> Bug:  836292 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
> Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288
> Reviewed-on: https://chromium-review.googlesource.com/1028584
> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555454}

TBR=vollick@chromium.org,bshe@chromium.org,asimjour@chromium.org

Change-Id: I09843e204345ef1d42a17320e5bc05c386fc8eaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  836292 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Reviewed-on: https://chromium-review.googlesource.com/1041048
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555595}
[modify] https://crrev.com/d8195de59fc533997e9f692530a03c9c5f9b3aa4/chrome/browser/android/vr/vr_dialog.cc
[modify] https://crrev.com/d8195de59fc533997e9f692530a03c9c5f9b3aa4/chrome/browser/android/vr/vr_dialog.h
[modify] https://crrev.com/d8195de59fc533997e9f692530a03c9c5f9b3aa4/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/d8195de59fc533997e9f692530a03c9c5f9b3aa4/chrome/browser/vr/content_input_delegate.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b44bf7897c3a4cd00fda4fa9eaf3c4a0f5bb7a11

commit b44bf7897c3a4cd00fda4fa9eaf3c4a0f5bb7a11
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Thu May 03 16:00:48 2018

Reland "Scroll support for hosted dialogs in VR"

This is a reland of 480d1516022c82afad0696259a94dee364a61890. Patch was not responsible for bot failures.

Original change's description:
> Scroll support for hosted dialogs in VR
>
> Now that VR supports html <select>, we should send scroll events
> to dialogs.
>
> Bug:  836292 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
> Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288
> Reviewed-on: https://chromium-review.googlesource.com/1028584
> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555454}

TBR=vollick@chromium.org, asimjour@chromium.org

Bug:  836292 
Change-Id: I8391daee7a1908273d5349106237e2177ad3c293
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Reviewed-on: https://chromium-review.googlesource.com/1042546
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555749}
[modify] https://crrev.com/b44bf7897c3a4cd00fda4fa9eaf3c4a0f5bb7a11/chrome/browser/android/vr/vr_dialog.cc
[modify] https://crrev.com/b44bf7897c3a4cd00fda4fa9eaf3c4a0f5bb7a11/chrome/browser/android/vr/vr_dialog.h
[modify] https://crrev.com/b44bf7897c3a4cd00fda4fa9eaf3c4a0f5bb7a11/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/b44bf7897c3a4cd00fda4fa9eaf3c4a0f5bb7a11/chrome/browser/vr/content_input_delegate.h

Comment 6 by asimjour@chromium.org, May 7 2018

Labels: Merge-Request-67
Project Member

Comment 7 by sheriffbot@chromium.org, May 7 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by cma...@chromium.org, May 8 2018 

How safe is it to merge this change into M67? Has it been verified in canary?

Comment 9 by asimjour@chromium.org, May 9 2018 

I verified it on Canary. It is safe. It was reverted by mistake in the first place, which delayed the test

Comment 10 by cmasso@google.com, May 9 2018

Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Project Member

Comment 11 by bugdroid1@chromium.org, May 10 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c436a2fcd6c7e4f5f96f45efe5445ed634ebced4

commit c436a2fcd6c7e4f5f96f45efe5445ed634ebced4
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Thu May 10 20:38:24 2018

Scroll support for hosted dialogs in VR

Now that VR supports html <select>, we should send scroll events
to dialogs.

TBR=asimjour@chromium.org

(cherry picked from commit 480d1516022c82afad0696259a94dee364a61890)

Bug:  836292 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288
Reviewed-on: https://chromium-review.googlesource.com/1028584
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555454}
Reviewed-on: https://chromium-review.googlesource.com/1054490
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#556}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/c436a2fcd6c7e4f5f96f45efe5445ed634ebced4/chrome/browser/android/vr/vr_dialog.cc
[modify] https://crrev.com/c436a2fcd6c7e4f5f96f45efe5445ed634ebced4/chrome/browser/android/vr/vr_dialog.h
[modify] https://crrev.com/c436a2fcd6c7e4f5f96f45efe5445ed634ebced4/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/c436a2fcd6c7e4f5f96f45efe5445ed634ebced4/chrome/browser/vr/content_input_delegate.h

Comment 12 by asimjour@chromium.org, May 10 2018

Status: Fixed (was: Started)

Comment 13 by dougman@chromium.org, May 14 2018

Labels: Test-Complete
Verified in build 67.0.3396.46 Beta.  The fix is in .43+ builds.
Looks good in .46, .46+ will be released to beta soon.

Comment 14 by dougman@chromium.org, May 14 2018

Status: Verified (was: Fixed)
►

Sign in to add a comment