USS/TwoClientSessionsSyncTest.DeleteActiveSession/1 times out |
|||||
Issue description
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1cba3793d8e9008fa903316203517e0f64297f3 commit d1cba3793d8e9008fa903316203517e0f64297f3 Author: Xida Chen <xidachen@chromium.org> Date: Tue Apr 24 17:19:39 2018 Revert "Disable DeleteActiveSession on Win" This reverts commit 0b61ff47226c5f98ea22902c75914b27235789ea. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable DeleteActiveSession on Win > > TBR=thestig@chromium.org > NOTRY=true > > Bug: 836289 > Change-Id: I669edb4d3ec8af8e144e5fac812ed0b1422e5e55 > Reviewed-on: https://chromium-review.googlesource.com/1026155 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553165} TBR=thestig@chromium.org,xidachen@chromium.org Change-Id: I6b1f989a749c7cbda554d5d8b4ccee735ded64e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836289 Reviewed-on: https://chromium-review.googlesource.com/1026132 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553185} [modify] https://crrev.com/d1cba3793d8e9008fa903316203517e0f64297f3/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
,
Apr 24 2018
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_7_Tests_x64__1_%2F37482%2F%2B%2Frecipes%2Fsteps%2Fsync_integration_tests%2F0%2Flogs%2FUSS__x2f_TwoClientSessionsSyncTest.DeleteActiveSession__x2f_1%2F0 [ RUN ] USS/TwoClientSessionsSyncTest.DeleteActiveSession/1 [5936:2772:0424/101331.816:18492686:WARNING:loopback_server.cc(638)] Loopback sync persistent state file does not exist. [5936:2772:0424/101331.856:ERROR:install_util.cc(589)] Unable to create registry key HKLM\SOFTWARE\Policies\Chromium for reading result=2 [5936:5876:0424/101331.891:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [5936:2772:0424/101331.928:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=USS/TwoClientSessionsSyncTest.DeleteActiveSession/1 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3976_21428\results3976_10300\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iombsh1s\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3976_21428\d3976_31269" --disable-offline-auto-reload --disable-background-networking --sync-short-initial-retry-override --sync-short-nudge-delay-for-test --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=SyncUSSSessions,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [5936:6248:0424/101332.284:WARNING:sync_encryption_handler_impl.cc(970)] Nigori had empty encryption keybag. [5936:6248:0424/101332.285:WARNING:sync_encryption_handler_impl.cc(970)] Nigori had empty encryption keybag. [5936:6248:0424/101332.291:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [5936:7092:0424/101332.315:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [5936:2772:0424/101332.444:ERROR:sessions_helper.cc(399)] Cannot get session data [5936:2772:0424/101332.448:ERROR:sessions_helper.cc(399)] Cannot get session data [5936:2772:0424/101332.452:ERROR:sessions_helper.cc(399)] Cannot get session data [5936:2772:0424/101332.742:ERROR:sessions_helper.cc(399)] Cannot get session data [5936:2772:0424/101332.745:ERROR:sessions_helper.cc(399)] Cannot get session data [5936:2772:0424/101332.754:ERROR:sessions_helper.cc(399)] Cannot get session data [5936:2772:0424/101332.997:ERROR:sessions_helper.cc(417)] Cannot find window #0
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/463bf383fe329ce3a8d9c1f22285e5edfc51f4f7 commit 463bf383fe329ce3a8d9c1f22285e5edfc51f4f7 Author: Xida Chen <xidachen@chromium.org> Date: Tue Apr 24 18:31:40 2018 Disable DeleteActiveSession on Win In my previous attemp to disable this here: https://chromium-review.googlesource.com/c/chromium/src/+/1026155, there was a typo and causes compile failure. I have a full build with this CL and it works fine. TBR=thestig@chromium.org NOTRY=true Bug: 836289 Change-Id: I92df34158b417b87adf48e9b8460d10171594a3e Reviewed-on: https://chromium-review.googlesource.com/1024603 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553209} [modify] https://crrev.com/463bf383fe329ce3a8d9c1f22285e5edfc51f4f7/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
,
Apr 24 2018
Issue 836425 has been merged into this issue.
,
Apr 25 2018
It's only USS/TwoClientSessionsSyncTest.DeleteActiveSession/1 specifically, but it affects all platforms. It's flaky enough to cause significant CQ pain, so I'm gonna disable the test on all platforms for now. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=TwoClientSessionsSyncTest.DeleteActiveSession
,
Apr 25 2018
CL to disable everywhere is pending: https://chromium-review.googlesource.com/c/chromium/src/+/1027838
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c40b3741cda129a40b2e8ddaf5e13365bb661823 commit c40b3741cda129a40b2e8ddaf5e13365bb661823 Author: Marc Treib <treib@chromium.org> Date: Wed Apr 25 14:08:15 2018 Disable TwoClientSessionsSyncTest.DeleteActiveSession on all platforms It was previously disabled on Windows, but it's flaky everywhere. TBR=mastiz Bug: 836289 Change-Id: I100c69c513118872824fbfdf58a4a7b6cef8ceca Reviewed-on: https://chromium-review.googlesource.com/1027838 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553541} [modify] https://crrev.com/c40b3741cda129a40b2e8ddaf5e13365bb661823/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207d426e0e93a8396a7e94940aebce605bf1089f commit 207d426e0e93a8396a7e94940aebce605bf1089f Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Apr 26 18:05:04 2018 Fix sync test flakiness due to checker races QuiesceStatusChangeChecker and UpdatedProgressMarkerChecker had known and well documented limitations leading to test flakiness, mainly due to HasUnsyncedItemsForTest() being run outside sync thread and hence potentially taking over queued (USS) or ongoing (directory) local changes (and returning false negatives). We solve this by making the function asynchronous and the actual implementation posting a task to the sync thread. This also acts as a logic barrier that provides better semantics to checkers (as newly documented). In line with this, we also report this bit (HasUnsyncedItems) as part of the sync cycle snapshot, because it's often sufficient to verify the value for the last sync cycle, and simple to reason about. Change-Id: I5db9ade11520394f801ab429457357f00ad132b0 Bug: 836289 , 836426 Change-Id: I5db9ade11520394f801ab429457357f00ad132b0 Reviewed-on: https://chromium-review.googlesource.com/1029853 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554080} [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/profile_sync_service_harness.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/profile_sync_service_harness.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/quiesce_status_change_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/single_client_status_change_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/status_change_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/sync_auth_test.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/updated_progress_marker_checker.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/chrome/browser/sync/test/integration/updated_progress_marker_checker.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/autofill/core/browser/test_sync_service.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/browser_sync/profile_sync_service_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/suggestions/suggestions_service_impl_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_core.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_core.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_impl.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/glue/sync_backend_host_impl.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/driver/sync_service_utils_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/cycle/sync_cycle_snapshot.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/cycle/sync_cycle_snapshot.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/fake_sync_engine.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/fake_sync_engine.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine/sync_engine.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/cycle/sync_cycle.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/js_sync_manager_observer_unittest.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/model_type_registry.cc [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/model_type_registry.h [modify] https://crrev.com/207d426e0e93a8396a7e94940aebce605bf1089f/components/sync/engine_impl/sync_manager_impl.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3bd98174e706d793b4175276c75211c9fc4d821 commit c3bd98174e706d793b4175276c75211c9fc4d821 Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Apr 26 20:07:01 2018 Reenable TwoClientSessionsSyncTest.DeleteActiveSession The underlying issue is believed to be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1029853 TBR=treib@chromium.org Bug: 836289 Change-Id: Idde8e1de7c4646c07288f5126bd0c0c9d8ddbcbf Reviewed-on: https://chromium-review.googlesource.com/1030151 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554124} [modify] https://crrev.com/c3bd98174e706d793b4175276c75211c9fc4d821/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4066f3e94c2b1be6ccf5edfe677c5466612a364c commit 4066f3e94c2b1be6ccf5edfe677c5466612a364c Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Apr 26 21:09:23 2018 Revert "Reenable TwoClientSessionsSyncTest.DeleteActiveSession" This reverts commit c3bd98174e706d793b4175276c75211c9fc4d821. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reenable TwoClientSessionsSyncTest.DeleteActiveSession > > The underlying issue is believed to be fixed after > https://chromium-review.googlesource.com/c/chromium/src/+/1029853 > > TBR=treib@chromium.org > > Bug: 836289 > Change-Id: Idde8e1de7c4646c07288f5126bd0c0c9d8ddbcbf > Reviewed-on: https://chromium-review.googlesource.com/1030151 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554124} TBR=mastiz@chromium.org Change-Id: I5a697f9bc5ba4cbf5d3024b7d5c16e209f9679c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836289 Reviewed-on: https://chromium-review.googlesource.com/1031410 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554151} [modify] https://crrev.com/4066f3e94c2b1be6ccf5edfe677c5466612a364c/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
,
Apr 27 2018
USS/TwoClientSessionsSyncTest.DeleteIdleSession/1 is also flaky, though not quite as bad.
,
Apr 27 2018
Correction: DeleteIdleSession *was* flaky, but it seems like the CL from #9 might have improved it. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=sync_integration_tests&tests=USS%2FTwoClientSessionsSyncTest.DeleteIdleSession%2F1
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9423686e5c0c7352e7e53a3d9c2e7a23429b207b commit 9423686e5c0c7352e7e53a3d9c2e7a23429b207b Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Apr 30 09:58:39 2018 Fix ModelNeutralState counters for USS types The counters must be updated analogously to how DirectoryCommitContribution::ProcessCommitResponse() does it. AFAIK, the bug affects tests and debug UIs only. Bug: 836289 Change-Id: I91b519bda573133305f31524a0ecb328f7748a11 Reviewed-on: https://chromium-review.googlesource.com/1033872 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#554716} [modify] https://crrev.com/9423686e5c0c7352e7e53a3d9c2e7a23429b207b/components/sync/engine_impl/model_type_worker_unittest.cc [modify] https://crrev.com/9423686e5c0c7352e7e53a3d9c2e7a23429b207b/components/sync/engine_impl/non_blocking_type_commit_contribution.cc
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80a8d6e54dc8e45fea476567746cdc0910edb38a commit 80a8d6e54dc8e45fea476567746cdc0910edb38a Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Apr 30 13:05:38 2018 Fix sync cycle snapshot progress markers for USS Instead of reading progress markers from the directory, use the UpdateHandler interface, which is supported in USS as well. Some optional but somewhat related test changes are bundled in this patch, although they are not required to pass tests. Bug: 836289 Change-Id: I5a62f27a92aa089a2aa19d4a50aa680c38387c3f Reviewed-on: https://chromium-review.googlesource.com/1033752 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#554730} [modify] https://crrev.com/80a8d6e54dc8e45fea476567746cdc0910edb38a/chrome/browser/sync/test/integration/updated_progress_marker_checker.cc [modify] https://crrev.com/80a8d6e54dc8e45fea476567746cdc0910edb38a/components/sync/engine_impl/cycle/sync_cycle.cc [modify] https://crrev.com/80a8d6e54dc8e45fea476567746cdc0910edb38a/components/sync/engine_impl/model_type_registry.cc [modify] https://crrev.com/80a8d6e54dc8e45fea476567746cdc0910edb38a/components/sync/engine_impl/model_type_registry.h [modify] https://crrev.com/80a8d6e54dc8e45fea476567746cdc0910edb38a/components/sync/syncable/directory.cc [modify] https://crrev.com/80a8d6e54dc8e45fea476567746cdc0910edb38a/components/sync/syncable/directory.h
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9011000ac59e488d508952072f71e9e22159b0e5 commit 9011000ac59e488d508952072f71e9e22159b0e5 Author: Mikel Astiz <mastiz@chromium.org> Date: Tue May 01 06:49:05 2018 Reland "Reenable TwoClientSessionsSyncTest.DeleteActiveSession" This is a reland of c3bd98174e706d793b4175276c75211c9fc4d821 Meanwhile, two underlying issues have been fixed: https://chromium-review.googlesource.com/c/chromium/src/+/1033752 https://chromium-review.googlesource.com/c/chromium/src/+/1033872 Original change's description: > Reenable TwoClientSessionsSyncTest.DeleteActiveSession > > The underlying issue is believed to be fixed after > https://chromium-review.googlesource.com/c/chromium/src/+/1029853 > > TBR=treib@chromium.org > > Bug: 836289 > Change-Id: Idde8e1de7c4646c07288f5126bd0c0c9d8ddbcbf > Reviewed-on: https://chromium-review.googlesource.com/1030151 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554124} TBR=treib@chromium.org Bug: 836289 Change-Id: I6b3f70a1c9c142f34692bf2079e32c6ca9e8f3f6 Reviewed-on: https://chromium-review.googlesource.com/1037003 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555007} [modify] https://crrev.com/9011000ac59e488d508952072f71e9e22159b0e5/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
,
May 1 2018
This looks really good now and test times are identical between USS and directory-based tests. No flakes in either of the two tests referred to above. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 24 2018