New issue
Advanced search Search tips

Issue 836257 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 712248
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MacViews-Browser] Regression: The drag&drop indicator is no longer centered between two items on the BMB

Project Member Reported by meh...@chromium.org, Apr 24 2018

Issue description

Chrome Version: Canary 68.0.3405.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable MacViews-Browser
(2) Open a Window
(3) Drag an BMB item between two other items
(4) Take a look at the position of the drag&drop indicator

What is the expected result?
The drag&drop indicator could be centered between two items.

What happens instead?
After the spacing was changed in  issue 826264 , the position of the drag&drop indicator is no longer centered between two items.

Thanks :-)
Mehmet
 
actual.png
19.5 KB View Download
expected.png
19.7 KB View Download

Comment 1 by meh...@chromium.org, Apr 24 2018

Summary: [MacViews-Browser] Regression: The drag&drop indicator is no longer centered between two items on the BMB (was: [MacViews-Browser] Regression: The drag&drop indicator is no longer centered between two items)
Labels: M-68 MacViews-Browser Target-68
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
Handing bookmark bar stuff over to pbos@ :)

Comment 3 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.

Comment 4 by pbos@chromium.org, May 3 2018

As far as I can tell the drag & drop handler places the indicator to the left of the item (e.g. where the new position would be) rather than inbetween it and the previous item.

This means it's not just off by a constant or similar, so this might be punted if it gets complicated.
drag_drop_position.png
22.3 KB View Download
I think we can live with it if the fix is too complicated. Thanks :)

Comment 6 by pbos@chromium.org, May 10 2018

Mergedinto: 712248
Status: Duplicate (was: Assigned)
The drag/drop indicator will be replaced by instead opening up space between the bookmark (similar to tabs). That obsoletes this bug so I'll mark this as a dup, the canonical bug is the better resolution as it removes the indicator completely.

Comment 7 by meh...@chromium.org, May 10 2018

Okay, thanks your update :)

Sign in to add a comment