The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7686670482374746f10a8e85b7907a7fd8a15a5

commit f7686670482374746f10a8e85b7907a7fd8a15a5
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 07 10:24:39 2018

Re-enable RestoreGeometry/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 836254
Change-Id: Id57af99390197cf17ae5e8feb9820f12cb251620
Reviewed-on: https://chromium-review.googlesource.com/1046705
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556405}
[modify] https://crrev.com/f7686670482374746f10a8e85b7907a7fd8a15a5/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac5f88b397abe3d6d6ccefe4199e1314f0bec3c

commit 0ac5f88b397abe3d6d6ccefe4199e1314f0bec3c
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 07 10:26:43 2018

Re-enable DriveSpecific/FileManagerBrowserTest all bots

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 836254
Change-Id: I55754ed89c069499824d66b0737dbde98e0a119d
Reviewed-on: https://chromium-review.googlesource.com/1046745
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556406}
[modify] https://crrev.com/0ac5f88b397abe3d6d6ccefe4199e1314f0bec3c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ebede76882fac9b113e5e272dbada9f5da423fd

commit 7ebede76882fac9b113e5e272dbada9f5da423fd
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 07 10:34:41 2018

Re-enable FileDisplay/FileManagerBrowserTest all bots

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 836254
Change-Id: I810feee6bd00d881289e12bf9dc328f070a7b125
Reviewed-on: https://chromium-review.googlesource.com/1046727
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556407}
[modify] https://crrev.com/7ebede76882fac9b113e5e272dbada9f5da423fd/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9d3bc4da247a2e2b125399bda45c62f2a9e029

commit 2b9d3bc4da247a2e2b125399bda45c62f2a9e029
Author: Noel Gordon <noel@chromium.org>
Date: Tue May 08 01:48:48 2018

Re-enable GearMenu/FileManagerBrowserTest all bots

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

No-Try: true
Bug: 836254
Change-Id: I61098daed7f056073fb8cdf4afe11888fb452bee
Reviewed-on: https://chromium-review.googlesource.com/1049086
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556638}
[modify] https://crrev.com/2b9d3bc4da247a2e2b125399bda45c62f2a9e029/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c6c043f336d6acbd6827eb82a13f0124348ad5

commit 01c6c043f336d6acbd6827eb82a13f0124348ad5
Author: Noel Gordon <noel@chromium.org>
Date: Wed May 09 22:55:14 2018

Minor comment clean-up for consistency

Format this crbug.com reference the way others are in this file.

Tbr: yamaguchi-san
No-Presubmit: true
No-Try: true
Bug: 836254
Change-Id: I723b4d62f668c1ba805b350eb4e53aca50ab2df7
Reviewed-on: https://chromium-review.googlesource.com/1052048
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557359}
[modify] https://crrev.com/01c6c043f336d6acbd6827eb82a13f0124348ad5/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52c8de92c54cdf8f7afcc2d88ac09024dfb4fede

commit 52c8de92c54cdf8f7afcc2d88ac09024dfb4fede
Author: Noel Gordon <noel@chromium.org>
Date: Wed May 09 23:31:21 2018

FileManagerBrowserTestBase: use fake audio layer in all tests

Move the fake audio layer command-line setup from the AudioPlayer and
VideoPlayer tests to FileManagerBrowserTestBase so it enabled for all
the FileManager browser tests (see  crbug.com/835626#c12 ).

Bug:  835626 , 835642 ,836254,835742
Change-Id: Ib4794a753a4c080fa0544a55c4ead3447c897b68
Reviewed-on: https://chromium-review.googlesource.com/1052047
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557375}
[modify] https://crrev.com/52c8de92c54cdf8f7afcc2d88ac09024dfb4fede/chrome/browser/chromeos/file_manager/audio_player_browsertest.cc
[modify] https://crrev.com/52c8de92c54cdf8f7afcc2d88ac09024dfb4fede/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/52c8de92c54cdf8f7afcc2d88ac09024dfb4fede/chrome/browser/chromeos/file_manager/video_player_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b0b3ae7ea9b294d92e378434a06f76f3772195

commit 11b0b3ae7ea9b294d92e378434a06f76f3772195
Author: Noel Gordon <noel@chromium.org>
Date: Thu May 10 01:10:09 2018

Re-enable KeyboardOperations/FileManagerBrowserTest all bots

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 836254
Change-Id: Ia3a271f7ceb9a61aefc6f34ac75e7b28a6894f5c
Reviewed-on: https://chromium-review.googlesource.com/1051551
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557403}
[modify] https://crrev.com/11b0b3ae7ea9b294d92e378434a06f76f3772195/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2108740c0ae74d1d22fbe74df3393217a1dced9f

commit 2108740c0ae74d1d22fbe74df3393217a1dced9f
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 09:59:42 2018

FileManageBrowserTestBase: disable NaCl loading component extensions

These extensions are not used by the Files.app browser tests and cause
ASAN flakes due to an unrelated NaCl  bug 788671 .

Skirt around that bug here by not loading these NaCl-using extensions.
Side-effect: these browser tests hopefully run a little faster.

Bug:  788671 ,836254
Change-Id: Ie528cad328d76f2ff0ee97c994f2bc539de86a98
Reviewed-on: https://chromium-review.googlesource.com/1055351
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557831}
[modify] https://crrev.com/2108740c0ae74d1d22fbe74df3393217a1dced9f/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Change in #33, suggests there is no coverage in browser test for the Files.app UI w.r.t. the zip packer / unpacker features of the ZipArchiver extension [1].

There is a test plan for this feature https://crbug.com/691001#c30 and some unit tests, so maybe we are covered.  

[1] the change #33 disabled the ZipArchiver with due to  issue 788671  [2]

  command_line->AppendSwitch(chromeos::switches::kDisableZipArchiverUnpacker);
  command_line->AppendSwitch(chromeos::switches::kDisableZipArchiverPacker);

[2]  issue 788671  is an NaCl memory leak that is flaky(CRASH)-detected by ASAN's LEAK_SANTIZER, and hits Files.app browser tests too often, and hence #33 to work around that issue).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7077675c09b24991dcc1c4b240c60d747517a2d

commit f7077675c09b24991dcc1c4b240c60d747517a2d
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 11:18:30 2018

Note that chrome.test.sendMessage expects a reply

Add a note about the need to reply to a chrome.test.sendMessage: it is
imprecise to say that we "just ignore it", we must reply. And an empty
std::string() is a sufficient reply.

Tbr: fukino
Bug: 836254
Change-Id: I969cf4659e415fcd004f0619d9de04a2b2f10c7e
Reviewed-on: https://chromium-review.googlesource.com/1055034
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557842}
[modify] https://crrev.com/f7077675c09b24991dcc1c4b240c60d747517a2d/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/404f825dea4933974d936ac4de0226a14a879b3d

commit 404f825dea4933974d936ac4de0226a14a879b3d
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 12:37:34 2018

FileManagerBrowserTestBase: be explicit about file entry SharedOption

Bare NONE is not great: scope resolve it SharedOption::NONE to make it
somewhat more obvious.

Tbr: fukino
Bug: 836254
Change-Id: If7b2ed65129ab8c6d0ce729037fac90fee3a3999
Reviewed-on: https://chromium-review.googlesource.com/1055352
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557851}
[modify] https://crrev.com/404f825dea4933974d936ac4de0226a14a879b3d/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94baf72b52432d37f6b775b8adb082b50b5d689a

commit 94baf72b52432d37f6b775b8adb082b50b5d689a
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 14:03:09 2018

Re-enable FolderShortcuts/FileManagerBrowserTest all bots

Enabled in RELEASE/MSAN, now re-enable this test in DEBUG/ASAN because
crrev.com/557831 improved our browser test speed.

Tbr: fukino
Bug: 836254, 837106 
Change-Id: I8f0e803901926f37438125174c16b173bbb83f89
Reviewed-on: https://chromium-review.googlesource.com/1055527
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557865}
[modify] https://crrev.com/94baf72b52432d37f6b775b8adb082b50b5d689a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bad347e21520d767eb626db3efa68f94c1d7164

commit 2bad347e21520d767eb626db3efa68f94c1d7164
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 14:50:27 2018

Re-enable TabindexSaveFileDialog/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Tbr: fukino
Bug: 836254
Change-Id: Ib1ac9ed1fcd0b920134460f1d9fe3e9e65103ae5
Reviewed-on: https://chromium-review.googlesource.com/1053934
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557880}
[modify] https://crrev.com/2bad347e21520d767eb626db3efa68f94c1d7164/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a6e52ab8d725032d8075bd68a5c8b65823fba0f

commit 1a6e52ab8d725032d8075bd68a5c8b65823fba0f
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 15:13:46 2018

Re-enable TabindexFocusDownloads/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

No-Presubmit: true
Tbr: fukino
Bug: 836254
Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252
Reviewed-on: https://chromium-review.googlesource.com/1055252
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557884}
[modify] https://crrev.com/1a6e52ab8d725032d8075bd68a5c8b65823fba0f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ec06165e36b5b2c0c272bf873aad5148a37813

commit 27ec06165e36b5b2c0c272bf873aad5148a37813
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 15:22:25 2018

Re-enable MultiProfileFileManagerBrowserTest all bots

Enabled in RELEASE, re-enable these tests (listed below) on all bots:

  MultiProfileFileManagerBrowserTest/PRE_BasicDownloads
  MultiProfileFileManagerBrowserTest/BasicDownloads
  MultiProfileFileManagerBrowserTest/PRE_BasicDrive

MultiProfileFileManagerBrowserTest/BasicDrive is all bots. Remove old
comments about that test. Trim the "normal operations" comments.

Tbr: fukino
Bug: 836254
Change-Id: Ia283400c34cd902514c2caf6e767dd30b0c8743e
Reviewed-on: https://chromium-review.googlesource.com/1055231
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557887}
[modify] https://crrev.com/27ec06165e36b5b2c0c272bf873aad5148a37813/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f62a120cd2f1551f2a726afaa9ba97a35b927eb2

commit f62a120cd2f1551f2a726afaa9ba97a35b927eb2
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 15:57:09 2018

Re-enable OpenFileDialog/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Tbr: fukino
Bug: 836254
Change-Id: I9aa41ba37f9510979cd72f0d91de0705214dfbe4
Reviewed-on: https://chromium-review.googlesource.com/1055035
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557892}
[modify] https://crrev.com/f62a120cd2f1551f2a726afaa9ba97a35b927eb2/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba5ad5c7574c1d12d4c34a6b2c114efd8b58b7c1

commit ba5ad5c7574c1d12d4c34a6b2c114efd8b58b7c1
Author: Devlin <rdevlin.cronin@chromium.org>
Date: Fri May 11 20:26:24 2018

Revert "Re-enable TabindexFocusDownloads/FileManagerBrowserTest"

This reverts commit 1a6e52ab8d725032d8075bd68a5c8b65823fba0f.

Reason for revert: Re-enabled test is failing on Linux CrOS:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27415

[ RUN      ] TabindexFocusDownloads/FileManagerBrowserTestWithLegacyEventDispatch.Test/0
[1570:1570:0511/120258.095371:WARNING:user_policy_manager_factory_chromeos.cc(207)] No policy loaded for known non-enterprise user
[1570:1570:0511/120258.202042:WARNING:user_session_manager.cc(1096)] Attempting to save user password for non enterprise user.
[1570:1570:0511/120300.805728:INFO:file_manager_browsertest_base.cc(632)] FileManagerBrowserTest::StartTest tabindexFocusDownloads
[1570:1570:0511/120306.899468:INFO:CONSOLE(1169)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (1169)
[1570:1570:0511/120306.921159:INFO:CONSOLE(5028)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5028)
[1570:1570:0511/120306.988321:INFO:CONSOLE(4360)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4360)
[1570:1570:0511/120307.027400:INFO:CONSOLE(5030)] "Volume list fetched with: 2 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5030)
[1570:1570:0511/120307.030481:INFO:CONSOLE(5040)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040)
[1570:1570:0511/120307.036408:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443)
[1570:1570:0511/120307.107297:INFO:CONSOLE(5040)] "Initializing volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5040)
[1570:1570:0511/120307.107935:INFO:CONSOLE(5443)] "Requesting file system.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5443)
[1570:1570:0511/120307.497407:INFO:CONSOLE(5491)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491)
[1570:1570:0511/120307.537188:INFO:CONSOLE(5044)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044)
[1570:1570:0511/120307.892689:INFO:CONSOLE(5491)] "File system obtained: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5491)
[1570:1570:0511/120307.896753:INFO:CONSOLE(5044)] "Initialized volume: drive:drive-user", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5044)
[1570:1570:0511/120307.897292:INFO:CONSOLE(5048)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5048)
[1570:1570:0511/120307.965385:INFO:CONSOLE(4357)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4357)
[1570:1570:0511/120312.721349:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[1570:1570:0511/120312.837968:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120315.831155:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120318.719753:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120322.994251:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120324.716075:INFO:CONSOLE(161)] "at /file_manager/background.js:315:27: The number of file is 0. Not changed.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (161)
[1570:1570:0511/120327.609187:INFO:CONSOLE(0)] "[SUCCESS] [tabindexFocusDownloads]", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[1570:1609:0511/120328.005035:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=10
[1570:1570:0511/120328.049612:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 3 in process 8
[1570:1570:0511/120328.049891:ERROR:frame_sink_provider_impl.cc(51)] No RenderWidgetHost exists with id 3 in process 8
[1570:1609:0511/120329.166852:WARNING:audio_sync_reader.cc(193)] AudioSyncReader::Read timed out, audio glitch count=20
[1570:1609:0511/120329.325388:WARNING:audio_sync_reader.cc(175)] ASR: No room in socket buffer.: Broken pipe (32)
[1570:1570:0511/120329.451110:WARNING:event_router.cc(421)] Not all file watchers are removed. This can happen when the Files app is open during shutdown.
[1570:1570:0511/120329.531088:FATAL:frame_sink_manager_impl.cc(58)] Check failed: sink_map_.empty().
#0 0x000000972721 (/b/s/w/ir/out/Release/browser_tests+0x972720)
#1 0x00000f472f9c (/b/s/w/ir/out/Release/browser_tests+0xf472f9b)
#2 0x00000f288153 (/b/s/w/ir/out/Release/browser_tests+0xf288152)
#3 0x00001617a0e7 (/b/s/w/ir/out/Release/browser_tests+0x1617a0e6)
#4 0x00001617a9ce (/b/s/w/ir/out/Release/browser_tests+0x1617a9cd)

Original change's description:
> Re-enable TabindexFocusDownloads/FileManagerBrowserTest
> 
> Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.
> 
> No-Presubmit: true
> Tbr: fukino
> Bug: 836254
> Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252
> Reviewed-on: https://chromium-review.googlesource.com/1055252
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557884}

TBR=noel@chromium.org,fukino@chromium.org,slangley@chromium.org

Change-Id: I8b4ac33592cb5ff61a414416de04dea03f5d89da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836254
Reviewed-on: https://chromium-review.googlesource.com/1055216
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558004}
[modify] https://crrev.com/ba5ad5c7574c1d12d4c34a6b2c114efd8b58b7c1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Revert in #42 was an ASAN flake  issue 837950 . Every subsequent run of the test on the ASAN bots was _green_ before the revert #42 landed [1].

[1] Picture attached: the ASAN flake is the black box.

Deleted: tabindex-focus-download-asan-flake-bug-837954.png 97.0 KB

	tabindex-focus-download-asan-flake-bug-837954.png 97.0 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb7c6fe96d070ef270f456afc078e2ce09d27324

commit eb7c6fe96d070ef270f456afc078e2ce09d27324
Author: Noel Gordon <noel@chromium.org>
Date: Sat May 12 03:45:48 2018

Re-land: Re-enable TabindexFocusDownloads/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Re-land. Was reverted on crrev.com/558004. Actual problem was an ASAN
flake [1] and every subsequent run of this test was green on the ASAN
bots before the revert landed (see image crbug.com/836254#c43).

[1] ASAN flake  crbug.com/837950 

Tbr: slangley, fukino
Bug: 836254
Change-Id: I1f1e60ad80130c5f2d7d92131fe21257f4ffa001
Reviewed-on: https://chromium-review.googlesource.com/1056507
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558110}
[modify] https://crrev.com/eb7c6fe96d070ef270f456afc078e2ce09d27324/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a13a02837f3e9d359cfcee08227265eb9b692b

commit b2a13a02837f3e9d359cfcee08227265eb9b692b
Author: Noel Gordon <noel@chromium.org>
Date: Sat May 12 05:53:18 2018

Re-enable TabindexOpenDialog/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Tbr: fukino
Bug: 836254
Change-Id: I7b6553cf460ee330e50b8dc8a4fa666369affeab
Reviewed-on: https://chromium-review.googlesource.com/1055036
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558115}
[modify] https://crrev.com/b2a13a02837f3e9d359cfcee08227265eb9b692b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cef20d7190378334ad644c0aae572bf01ccff938

commit cef20d7190378334ad644c0aae572bf01ccff938
Author: Noel Gordon <noel@chromium.org>
Date: Sat May 12 05:53:27 2018

Re-enable Tabindex/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Tbr: fukino
Bug: 836254
Change-Id: Ife1c1ccc84b3d25f469da93d69bd334145b8f4b8
Reviewed-on: https://chromium-review.googlesource.com/1055370
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558116}
[modify] https://crrev.com/cef20d7190378334ad644c0aae572bf01ccff938/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11f8b75cf76117c4c07da88d659510bb213bac4

commit a11f8b75cf76117c4c07da88d659510bb213bac4
Author: Noel Gordon <noel@chromium.org>
Date: Sun May 13 23:48:29 2018

FileManagerBrowserTest: removed unused includes

Remove unused #include. Also update to copyright notice per style.

Bug: 836254
Change-Id: Icb7bcec55d20535cdd2f0f5eb49bd1c3e22ca2ca
Reviewed-on: https://chromium-review.googlesource.com/1056747
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558166}
[modify] https://crrev.com/a11f8b75cf76117c4c07da88d659510bb213bac4/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330d58abee0c651df86c3ed8bb3e530423beb56e

commit 330d58abee0c651df86c3ed8bb3e530423beb56e
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 00:00:15 2018

Integration tests transfer.js: Remove TODO

Remove TODOs (found a better way to address this in future changes).

Comment only change.

No-Try: true
Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibfb73d564964afbaca95ac4b1125a084a7939691
Reviewed-on: https://chromium-review.googlesource.com/1056767
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558167}
[modify] https://crrev.com/330d58abee0c651df86c3ed8bb3e530423beb56e/ui/file_manager/integration_tests/file_manager/transfer.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/738768f5f049c256a32e138551bead9f559a7536

commit 738768f5f049c256a32e138551bead9f559a7536
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 00:03:19 2018

Re-enable OpenAudioFiles/FileManagerBrowserTest

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 836254
Change-Id: Ie6ca28f923dcf70be407c8782985195874f47758
Reviewed-on: https://chromium-review.googlesource.com/1056748
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558168}
[modify] https://crrev.com/738768f5f049c256a32e138551bead9f559a7536/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b5b32fb4d9de4d7ea619b2c3de3808b5831d0c

commit 07b5b32fb4d9de4d7ea619b2c3de3808b5831d0c
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 02:23:26 2018

FileManagerBrowserTest: change test name tabindexSearchBoxFocus

Allows use to group "tabindex*" tests together (and eventually get rid
of the FileManagerBrowserTestWithLegacyEventDisapatch class).

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifd4c81458e853799e8a59e1185f8745fb27f8da8
Reviewed-on: https://chromium-review.googlesource.com/1056768
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558176}
[modify] https://crrev.com/07b5b32fb4d9de4d7ea619b2c3de3808b5831d0c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/07b5b32fb4d9de4d7ea619b2c3de3808b5831d0c/ui/file_manager/integration_tests/file_manager/tab_index.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa8d1e4a8bc5fb3aba4c13e9de447bf9eb7de416

commit aa8d1e4a8bc5fb3aba4c13e9de447bf9eb7de416
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 04:42:54 2018

Integration tests restore_geometry.js: document

Document these tests, and remove redundant "State" from then end of a
the geometry maximized test.

No-Presubmit: true
Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I261dc8083e19eae5b6252916b6abecb64eef57e1
Reviewed-on: https://chromium-review.googlesource.com/1056749
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558195}
[modify] https://crrev.com/aa8d1e4a8bc5fb3aba4c13e9de447bf9eb7de416/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/aa8d1e4a8bc5fb3aba4c13e9de447bf9eb7de416/ui/file_manager/integration_tests/file_manager/restore_geometry.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6eac1b827694592986ebc608ea4e0dee2ae642

commit 7b6eac1b827694592986ebc608ea4e0dee2ae642
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 04:43:54 2018

Integration tests keyboard_operations: use Folder

Consistency: other tests use "Folder" instead of "Directory".

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8870cc25a39a54c6c06d2d5a2560652e854b5e99
Reviewed-on: https://chromium-review.googlesource.com/1056769
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558196}
[modify] https://crrev.com/7b6eac1b827694592986ebc608ea4e0dee2ae642/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/7b6eac1b827694592986ebc608ea4e0dee2ae642/ui/file_manager/integration_tests/file_manager/keyboard_operations.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b77e3cc26642e227fe77cd8f300ba1d3345e4d8

commit 1b77e3cc26642e227fe77cd8f300ba1d3345e4d8
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 05:04:37 2018

Fix directory_tree_context_menu.js presubmit warning

122:47 error Missing semicolon
515:52 error Missing semicolon

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id30d0aa122c0a34ac75b921de484ee5d2f376403
Reviewed-on: https://chromium-review.googlesource.com/1056888
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558199}
[modify] https://crrev.com/1b77e3cc26642e227fe77cd8f300ba1d3345e4d8/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2b143c2765b979f9b97ace402dfa60a4242c88e

commit c2b143c2765b979f9b97ace402dfa60a4242c88e
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 05:09:28 2018

Integration tests file_display.js: document these tests

Document these tests. Also change them to have a common prefix.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0c8d37efe4d9f380c17491b30b38c90d31204098
Reviewed-on: https://chromium-review.googlesource.com/1056752
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558201}
[modify] https://crrev.com/c2b143c2765b979f9b97ace402dfa60a4242c88e/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/c2b143c2765b979f9b97ace402dfa60a4242c88e/ui/file_manager/integration_tests/file_manager/file_display.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d861a0462628d975b4856255b21a6ec4dc9c3ebe

commit d861a0462628d975b4856255b21a6ec4dc9c3ebe
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 06:11:46 2018

Integration tests gear_menu.js: use same prefix

Use the same prefix for gear tests. Change test names for consistency
with the rest of the integration test JS files.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6348927f9df141e86fdccf484afae5d432c9b316
Reviewed-on: https://chromium-review.googlesource.com/1056651
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558210}
[modify] https://crrev.com/d861a0462628d975b4856255b21a6ec4dc9c3ebe/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/d861a0462628d975b4856255b21a6ec4dc9c3ebe/ui/file_manager/integration_tests/file_manager/gear_menu.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c4764e1d2cb30839c1889b06d3470bf7732126

commit 97c4764e1d2cb30839c1889b06d3470bf7732126
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 06:12:06 2018

Integration tests file_dialog.js: document these tests

Document the test, change test names to have a common prefix.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id2304840000c7fbe69caa281e31f9f79d0cd1e0a
Reviewed-on: https://chromium-review.googlesource.com/1056753
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558211}
[modify] https://crrev.com/97c4764e1d2cb30839c1889b06d3470bf7732126/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/97c4764e1d2cb30839c1889b06d3470bf7732126/ui/file_manager/integration_tests/file_manager/file_dialog.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b60c46db69e89218ef3933e90e77aa749b827f62

commit b60c46db69e89218ef3933e90e77aa749b827f62
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 06:17:57 2018

Integration tests drive_specific.js: use a common prefix

What it says on the tin, plus minor test comment updates.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iefe801b3167629271826d457cf7b92473c902638
Reviewed-on: https://chromium-review.googlesource.com/1056774
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558212}
[modify] https://crrev.com/b60c46db69e89218ef3933e90e77aa749b827f62/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/b60c46db69e89218ef3933e90e77aa749b827f62/ui/file_manager/integration_tests/file_manager/drive_specific.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/275195e9b896efd751fb37659a37508e3812fc83

commit 275195e9b896efd751fb37659a37508e3812fc83
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 06:48:58 2018

Integration tests directory_tree_context_menu.js: fix redundant test names

The names of these tests is above and beyond. Provide a commomn prefix
and shorten these names to something more sensible.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6a903c3fd8fbe91654b4c6fdf67e8f0474bc24e2
Reviewed-on: https://chromium-review.googlesource.com/1056777
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558216}
[modify] https://crrev.com/275195e9b896efd751fb37659a37508e3812fc83/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/275195e9b896efd751fb37659a37508e3812fc83/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b266790fc57899bc8f57f4cdd6ae435f871b4800

commit b266790fc57899bc8f57f4cdd6ae435f871b4800
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 06:51:21 2018

Integration tests create_new_folder.js: test naming

When you "create" a folder, it is "new". Ditch the "new" in these test
names, make "CreateFolder" the common sub-string.

The first test does some sort of selection before calling CreateFolder
so prefix "select" in that test's name.

No-Presubmit: true
Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie559508c6688d0493ef0866635e35a1944e11cbc
Reviewed-on: https://chromium-review.googlesource.com/1056450
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558217}
[modify] https://crrev.com/b266790fc57899bc8f57f4cdd6ae435f871b4800/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/b266790fc57899bc8f57f4cdd6ae435f871b4800/ui/file_manager/integration_tests/file_manager/create_new_folder.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/583a90db902d7884937a563304d510b4a7348aae

commit 583a90db902d7884937a563304d510b4a7348aae
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 06:53:02 2018

Integration tests delete.js: document these tests

Document these tests, and change test names to match.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I156a6d5823e86d94b48b5706e3be9ba2c07562e0
Reviewed-on: https://chromium-review.googlesource.com/1056656
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558218}
[modify] https://crrev.com/583a90db902d7884937a563304d510b4a7348aae/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/583a90db902d7884937a563304d510b4a7348aae/ui/file_manager/integration_tests/file_manager/delete.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6562496620c6695c2f532e130d46a48686e74362

commit 6562496620c6695c2f532e130d46a48686e74362
Author: Timothy Loh <timloh@chromium.org>
Date: Mon May 14 07:18:14 2018

Revert "Re-enable OpenAudioFiles/FileManagerBrowserTest"

This reverts commit 738768f5f049c256a32e138551bead9f559a7536.

Reason for revert: Times out on MSAN

https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7143

Original change's description:
> Re-enable OpenAudioFiles/FileManagerBrowserTest
> 
> Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.
> 
> Bug: 836254
> Change-Id: Ie6ca28f923dcf70be407c8782985195874f47758
> Reviewed-on: https://chromium-review.googlesource.com/1056748
> Reviewed-by: Stuart Langley <slangley@chromium.org>
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558168}

TBR=noel@chromium.org,fukino@chromium.org,slangley@chromium.org

Change-Id: Ib066688090f770c251b333db4446d92f52951a0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 836254
Reviewed-on: https://chromium-review.googlesource.com/1056657
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558220}
[modify] https://crrev.com/6562496620c6695c2f532e130d46a48686e74362/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8720752489d0d10bafafbf9ec633bfa8a2750e6

commit e8720752489d0d10bafafbf9ec633bfa8a2750e6
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 08:42:54 2018

Re-enable OpenAudioFiles/FileManagerBrowserTest

Enabled in RELEASE, now re-enable in DEBUG/ASAN. Note MSAN is TIMEOUT
so keep it disabled there.

OpenAudioFiles/FileManagerBrowserTest.Test/1 TIMEOUT (3 in a row).

Bug: 836254
Change-Id: I80e32f126d1e5594a863dc170cec399fb46afa12
Reviewed-on: https://chromium-review.googlesource.com/1056897
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558225}
[modify] https://crrev.com/e8720752489d0d10bafafbf9ec633bfa8a2750e6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c3b9ad1650af9935f282384790ae57df4b7cba

commit 32c3b9ad1650af9935f282384790ae57df4b7cba
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 10:18:06 2018

Remove QuickView openQuickViewForFoldersAfterClose test

QuickView/FileManagerBrowserTest/Test0,1,2 (3 tests). The tests do the
following:

  Test/0 open QuickView
  Test/1 open then close QuickView
  Test/2 open then close then open QuickView again

The first two tests have run-time that is already near bot time limits
so Test/2 trying to open QuickView again will likely exceed bot limits
regularly and FAIL even in RELEASE. Remove this test.

Bug: 836254, 808745 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icb91410cd095a305e1d9b189e5139c49c22cd39c
Reviewed-on: https://chromium-review.googlesource.com/1055911
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558247}
[modify] https://crrev.com/32c3b9ad1650af9935f282384790ae57df4b7cba/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/32c3b9ad1650af9935f282384790ae57df4b7cba/ui/file_manager/integration_tests/file_manager/quick_view.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59da55b2d031d949f65093abc471a0994ccf6f00

commit 59da55b2d031d949f65093abc471a0994ccf6f00
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 12:30:20 2018

Integration tests task.js: update test names

Drop the "On" prefixing of the volume type (like all the other tests).

Tbr: fukino
No-Presubmit: true
Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If891b0d4fc5baf1445ca892f6490fe20b44d4d67
Reviewed-on: https://chromium-review.googlesource.com/1057208
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558269}
[modify] https://crrev.com/59da55b2d031d949f65093abc471a0994ccf6f00/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/59da55b2d031d949f65093abc471a0994ccf6f00/ui/file_manager/integration_tests/file_manager/tasks.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3dd13e9a11b1e265543b33525a45718fd057fcb

commit c3dd13e9a11b1e265543b33525a45718fd057fcb
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 14 13:53:48 2018

FileManagerBrowserTest: directly mark CopyBetweenWindows DISABLED

This test fails on bots. Mark is DISABLED directly, rather than by the
DISABLE_SLOW_FILESAPP_TESTS macro used to control DEBUG/MSAN/ASAN (the
CopyBetweenWindows test is the only remaining test using this macro).

Add comment (conjecture about why this test is failing) and retain the
reference to  issue 500966 .

Tbr: fukino
No-Presubmit: true
Bug: 836254
Change-Id: I79aaac465b0fdd255a10d251cd474940c6692eb5
Reviewed-on: https://chromium-review.googlesource.com/1057548
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558288}
[modify] https://crrev.com/c3dd13e9a11b1e265543b33525a45718fd057fcb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13108aa2c15bc8ad6731e3afbb02afc2546071ac

commit 13108aa2c15bc8ad6731e3afbb02afc2546071ac
Author: Noel Gordon <noel@chromium.org>
Date: Wed May 16 12:28:06 2018

Mash exclusion for MultiProfileFileManagerBrowserTest BasicDrive

Mash does not support the BasicDrive tests causing flakes on the CQ in
mash_browser_tests (with patch). Exclude them in Mash.

  MultiProfileFileManagerBrowserTest.BasicDrive
  MultiProfileFileManagerBrowserTest.PRE_BasicDrive

Tbr: fukino
No-Presubmit: true
Bug: 836254, 842442
Change-Id: Ie03fce011bcdb6ba1b20bf2d832aedee0e792feb
Reviewed-on: https://chromium-review.googlesource.com/1061433
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559051}
[modify] https://crrev.com/13108aa2c15bc8ad6731e3afbb02afc2546071ac/testing/buildbot/filters/mash.browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b294d0c43be3ae928447a28746f4ec1d23049643

commit b294d0c43be3ae928447a28746f4ec1d23049643
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 18 08:02:32 2018

Rename FileManagerBrowserTest: add JS test case names

Change test fixture name to FilesAppBrowserTest. Also, add JS testcase
name, plus modes, to the end of GTEST test name (which is shown on the
Flakiness Dashboard). That's all GTEST allows, and it is strict re the
character used to combine string names: '_' only.

FilesAppBrowserTest, the new fixture name, is used to decouple all the
re-named tests from the old fixture name, FileManagerBrowserTest, when
searching the Flakiness Dashboard [1].

Update the Mash bot filter exclusion list for the new fixture name and
add TODO(me): remove the old Mash FileManagerBrowserTest entries.

[1] Keeping FileManagerBrowserTest would cause developer confusion.

Bug:  843030 ,836254
No-presubmit: true
Change-Id: I46318d34ce5132155db6d0e792e54a579b8e5c5c
Reviewed-on: https://chromium-review.googlesource.com/1063952
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559833}
[modify] https://crrev.com/b294d0c43be3ae928447a28746f4ec1d23049643/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/b294d0c43be3ae928447a28746f4ec1d23049643/testing/buildbot/filters/mash.browser_tests.filter

This work is going great - lowering priority to P2.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b01cc1bde4f52886cfd9f20a21c511274ed873d

commit 1b01cc1bde4f52886cfd9f20a21c511274ed873d
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 21 07:37:46 2018

Remove Mash FileManageBrowserTest exclusions

FileManagerBrowserTest was renamed in crrev.com/559833 so there are no
FileManagerBrowserTests anymore. Remove their Mash bot filter excludes
(and group the Files.App-related tests together) in the file.

Bug:  843030 ,836254
Change-Id: I865e22f6e9d762b9766a192ec038860eb591f01c
Reviewed-on: https://chromium-review.googlesource.com/1067317
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560241}
[modify] https://crrev.com/1b01cc1bde4f52886cfd9f20a21c511274ed873d/testing/buildbot/filters/mash.browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc6d0c2423f0cff0e84a22934d3dd8001cd3151f

commit bc6d0c2423f0cff0e84a22934d3dd8001cd3151f
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 21 08:26:50 2018

Add ability to fill test USB or MTP volumes with entries, or not

When mounting a fake removable volume (MTP or USB), allow the test case
to control filling the volume with entries or not.

Add a new file display test for USB. Comment file_display.js some more,
plus minor code and git cl format tweaks.

FileDisplay is not supported on Mash: add Mash filter bot exclusions.

Test=browser_test --gtest_filter="FileDisplay/FilesApp*"

Tbr: fukino-san
Bug:  845087 ,836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I841f21d6b737813fc8a59574bfe10abfdf0b6e0d
Reviewed-on: https://chromium-review.googlesource.com/1067219
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560247}
[modify] https://crrev.com/bc6d0c2423f0cff0e84a22934d3dd8001cd3151f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/bc6d0c2423f0cff0e84a22934d3dd8001cd3151f/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/bc6d0c2423f0cff0e84a22934d3dd8001cd3151f/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/bc6d0c2423f0cff0e84a22934d3dd8001cd3151f/ui/file_manager/integration_tests/file_manager/file_display.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49e6deaf43b6a5dc3788debfcbb5270e8af0256a

commit 49e6deaf43b6a5dc3788debfcbb5270e8af0256a
Author: Noel Gordon <noel@chromium.org>
Date: Tue May 22 01:58:34 2018

FileManagerBrowserTestBase: minor FakeDriveService comment change

Bug: 836254
Change-Id: I84a30d2568cf8cbea3277d71ea4d429f6bb07ff7
Reviewed-on: https://chromium-review.googlesource.com/1067379
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560456}
[modify] https://crrev.com/49e6deaf43b6a5dc3788debfcbb5270e8af0256a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Interesting comment  crbug.com/327719#c3  about DEBUG in chrome-os being much slower than DEBUG on chrome.   My current data agrees with that. 

A largish number of component extensions are loaded when chrome-os starts, and that includes the Files.app component extensions and a whole lot more [1].

My bet is, as the loaded component extensions list has grown in chrome-os, so has start-up time, and hence run-time time, for all the Files.App browser tests.

[1] Code search for AddDefaultComponentExtensions() for chrome-os.  The browser test base class for Files.App calls it before running tests, because yeah, we need to load the Files.App component extensions so we can test them:

  ExtensionService* service =
      extensions::ExtensionSystem::Get(profile())->extension_service();
  service->component_loader()->AddDefaultComponentExtensions(false);

The default loader call does that, and loads many other extensions too, by the looks. Not sure we need them all, but there is no call in extensions:: to say just load the ones needed to support Files.App. 

+rdevlin.cronin: I imagine up I could do something like ^^^ that, then these tests might run faster on the bots.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae6df8a5a816546c2540617a1267b04978b501f

commit dae6df8a5a816546c2540617a1267b04978b501f
Author: Noel Gordon <noel@chromium.org>
Date: Thu May 24 23:44:01 2018

#define DISABLE_SLOW_FILESAPP_TESTS is no longer used: remove

Woohoo, I suppose.

Bug: 836254
Change-Id: Ic5aa72305b0884cfee57f77a66339bf0d83f3cd9
Reviewed-on: https://chromium-review.googlesource.com/1071029
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561695}
[modify] https://crrev.com/dae6df8a5a816546c2540617a1267b04978b501f/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d743f5812fc9a602d3161353926a8c7281d7bdcd

commit d743f5812fc9a602d3161353926a8c7281d7bdcd
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 25 05:38:41 2018

FilesAppBrowserTest: code and document the use of trusted events

Remove the concept of LegacyEvents: irrelevant. Instead change concept
to the use of Trusted JS Events, which are used to force Blink to send
Tab key events to the Files.App page under test (add a comment).

If we don't use trusted Events, Blink consumes Tab key events with its
default handlers and the Tab key never reaches the JS page under test.
This affects the browser tests involving "tabindex" -- they won't work
unless they receive Tab key JS Events [1].

Clean up the TestCase struct: remove the accessors, and access members
directly since all access is const anyway. Add a new struct EventTest,
to specialize TestCase for the few tests that need trusted Events.

No change in behavior, no new tests.

[1] see  crbug.com/482121   crbug.com/480491 

Bug: 836254, 482121 , 480491 
Change-Id: Ic1906c6033ccc65be43b2c8cbe1344e5ffec4655
Reviewed-on: https://chromium-review.googlesource.com/1072220
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561777}
[modify] https://crrev.com/d743f5812fc9a602d3161353926a8c7281d7bdcd/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a06ce4bf9432848a9b7a52dd26dd2fab9787445

commit 8a06ce4bf9432848a9b7a52dd26dd2fab9787445
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 28 05:16:38 2018

FilesAppBrowserTest: add more InGuestMode test variants

Bug: 836254
Change-Id: I530de6d510d6711e0b0ade84fb44d53b2ace1aee
Reviewed-on: https://chromium-review.googlesource.com/1074887
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562183}
[modify] https://crrev.com/8a06ce4bf9432848a9b7a52dd26dd2fab9787445/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0467130d90da9e712c779d619ae340fdb0df35d4

commit 0467130d90da9e712c779d619ae340fdb0df35d4
Author: Noel Gordon <noel@chromium.org>
Date: Mon May 28 07:50:39 2018

Style GearMenu directory_tree_context_menu.js integration test

 - use ES6 const ... no need to closure @const annotate that.
 - use /* Tests ... for consistency with other browser tests.
 - use sentences, try explain more about what these tests do.

No change in behavior, no new tests.

Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ica91a308038ac66de6ca2170e3f99ce97cbe91f8
Reviewed-on: https://chromium-review.googlesource.com/1074947
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562201}
[modify] https://crrev.com/0467130d90da9e712c779d619ae340fdb0df35d4/ui/file_manager/integration_tests/file_manager/gear_menu.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b6aa94a27ca8ae0d38857b9bf8212bdebf7a2c1

commit 2b6aa94a27ca8ae0d38857b9bf8212bdebf7a2c1
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jun 14 01:13:56 2018

Use descendant combinator in copyBetweenWindows browser tests

Use a decendant combinator selector to query for the USB volume: it is
shorter and more idiomatic with other volume selector JS test code.

Test: browser_test --gtest_filter="*FilesApp*copyBetweenWindows*"
Bug: 836254, 851888 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I70b9ecad9e57db6a2d0028ba329707c5574710e8
Reviewed-on: https://chromium-review.googlesource.com/1098908
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567077}
[modify] https://crrev.com/2b6aa94a27ca8ae0d38857b9bf8212bdebf7a2c1/ui/file_manager/integration_tests/file_manager/copy_between_windows.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab508cbb92101f3db0144c0ba727afa35b551330

commit ab508cbb92101f3db0144c0ba727afa35b551330
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jun 14 01:14:10 2018

Use descendant combinator in FileDisplay USB,MTP browser tests

Use a descendant combinator CSS selector to query for USB/MTP volumes:
it is shorter and more idiomatic with volume code selectors.

Other clean-up while here: add a comment for load File app step. Where
an argument in a test step function is unused, remove it.

Test: browser_test --gtest_filter="FileDisplay/FilesApp*"
Bug: 836254, 851888 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I88b04907ed04b355d8de9412ba748ca1ce0ced21
Reviewed-on: https://chromium-review.googlesource.com/1098907
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567078}
[modify] https://crrev.com/ab508cbb92101f3db0144c0ba727afa35b551330/ui/file_manager/integration_tests/file_manager/file_display.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c441dcc29232a665587a4e12fc68f8cf74ec041e

commit c441dcc29232a665587a4e12fc68f8cf74ec041e
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jun 14 12:08:20 2018

Add a QuickView openQuickViewDrive browser test

Add coverage for Drive to the openQuickView<VolumeType> test group.

Test: browser_test --gtest_filter="QuickView/FilesApp*"
Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibf081b03ebcb069274c83d00da1d2703649bb04d
Reviewed-on: https://chromium-review.googlesource.com/1098913
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567228}
[modify] https://crrev.com/c441dcc29232a665587a4e12fc68f8cf74ec041e/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/c441dcc29232a665587a4e12fc68f8cf74ec041e/ui/file_manager/integration_tests/file_manager/quick_view.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2292f91389c3df9494db32941af0194e94826e9b

commit 2292f91389c3df9494db32941af0194e94826e9b
Author: Noel Gordon <noel@chromium.org>
Date: Fri Jun 15 11:03:53 2018

Add a QuickView openQuickViewMtp browser test

Add coverage for MTP to the openQuickView<VolumeType> test group, with
a test variation - the initial ephemeral volume (here MTP) mounts with
non-empty file content (BASIC_FAKE_ENTRY_SET).

Test: browser_test --gtest_filter="QuickView/FilesApp*"
Bug: 836254
Change-Id: I21562e5b4905c3b57609b11bd8f231a137ec8884
Reviewed-on: https://chromium-review.googlesource.com/1099096
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567605}
[modify] https://crrev.com/2292f91389c3df9494db32941af0194e94826e9b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/2292f91389c3df9494db32941af0194e94826e9b/ui/file_manager/integration_tests/file_manager/quick_view.js

Work continues into M-69 I guess.

There are three dependent bugs listed on the left of this bug.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c52f41859ac9d73e41821f939b6bf5fad12d1840

commit c52f41859ac9d73e41821f939b6bf5fad12d1840
Author: Noel Gordon <noel@chromium.org>
Date: Fri Jun 22 03:06:01 2018

Various FileManagerBrowserTestBase clean-up

 - order MapStringToTargetVolume if tests in the same order as the
   enum TargetVolume defines the related volume.
 - commentry: clarify some comments, correct spelling errors.

Bug: 836254
Change-Id: I01bc9df93631c9f7cfa9ae9e72ef117067a6f76c
Reviewed-on: https://chromium-review.googlesource.com/1109802
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569521}
[modify] https://crrev.com/c52f41859ac9d73e41821f939b6bf5fad12d1840/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdeb803988fa32e0e7bf52bcb77b17653e7b9858

commit cdeb803988fa32e0e7bf52bcb77b17653e7b9858
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jun 25 03:57:17 2018

DriveTestVolume: Remove extra CheckForUpdates calls

DriveTestVolume::CreateEntry calls CreateFile|Directory and then calls
CheckForUpdates. CreateFile|Directory also call CheckForUpdates: seems
redundant given that the caller does it for them.

Bug: 836254
Change-Id: Ia778a64d0195925a827c40dc6dfdf3877a6611d3
Reviewed-on: https://chromium-review.googlesource.com/1110077
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569958}
[modify] https://crrev.com/cdeb803988fa32e0e7bf52bcb77b17653e7b9858/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d233389ba66b77db8f6933d201b730d3eba974

commit 67d233389ba66b77db8f6933d201b730d3eba974
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jun 25 14:58:02 2018

Re-enable OpenAudioFiles/FilesAppBrowserTest on MSAN

The MSAN bots are significantly faster in recent days (speed increased
more than 30%). Re-enable the OpenAudioFiles browser test on MSAN.

Tbr: fukino-san, slangley
Bug: 836254
Change-Id: Id5757c7f462c1cd5adb117c46718867ad90916d5
Reviewed-on: https://chromium-review.googlesource.com/1113561
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570038}
[modify] https://crrev.com/67d233389ba66b77db8f6933d201b730d3eba974/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/413ffeb49b317213bb2350da21b19ec4607c50d0

commit 413ffeb49b317213bb2350da21b19ec4607c50d0
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jun 25 15:01:45 2018

Re-enable OpenImageFiles/FilesAppBrowserTest on MSAN

The MSAN bots are significantly faster in recent days (speed increased
more than 30%). Re-enable the OpenImageFiles browser test on MSAN.

Tbr: fukino-san, slangley
Bug: 836254
Change-Id: Id83c665e11ebb65f9dee79e354baba80be8ae52d
Reviewed-on: https://chromium-review.googlesource.com/1113637
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570039}
[modify] https://crrev.com/413ffeb49b317213bb2350da21b19ec4607c50d0/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83c93bb06fb4d5710b3196620bda856742c3b395

commit 83c93bb06fb4d5710b3196620bda856742c3b395
Author: Sam McNally <sammc@chromium.org>
Date: Thu Jul 05 08:11:45 2018

Deflake copyBetweenWindowsLocalToDrive(_DriveFs).

copyBetweenWindowsLocalToDrive doesn't wait for the destination to be
fully-loaded before attempting to paste into it; this can result in the
paste being injected before the event handler is registered, causing the
test to fail. Avoid this by waiting for a file to be visible in the
destination window to ensure its loading is complete.

Bug: 836254
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4198b622a9a7a8eb9c9bbb3484b6c4686ceeaac2
Reviewed-on: https://chromium-review.googlesource.com/1126801
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572734}
[modify] https://crrev.com/83c93bb06fb4d5710b3196620bda856742c3b395/ui/file_manager/integration_tests/file_manager/copy_between_windows.js

KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode
DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateWithContextMenu
KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode
are flaky. Example https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6685

[17658:17658:0706/015520.233465:INFO:CONSOLE(0)] "[FAIL] [dirCreateWithContextMenu]: API Test Error in [dirCreateWithContextMenu]: The error count is not 0.
Actual: 1
Expected: 0
Error
    at extensions::test:243:18
    at chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js:56:17", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[17658:17658:0706/015520.233923:INFO:CONSOLE(0)] "Uncaught (in promise) chrome.test.failure", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:1035: Failure
Failed
Failed 1 of 1 tests
Stack trace:
#0 0x000003f5e660 StackTraceGetter::CurrentStackTrace()
#1 0x000003f7f127 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x000003f7e58d testing::internal::AssertHelper::operator=()
#3 0x000002770f42 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#4 0x000002770ca2 file_manager::FileManagerBrowserTestBase::StartTest()
#5 0x00000275d335 file_manager::FilesAppBrowserTest_Test_Test::RunTestOnMainThread()

Findit filed  issue 860647  renameNewFolderDownloads_GuestMode

The DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateWithContextMenu flake was also caused by the same  issue 860647  "the error count is not 0".

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06141eceaf5bc42a1e36e59ace24b8fb52cf1ad

commit b06141eceaf5bc42a1e36e59ace24b8fb52cf1ad
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jul 16 10:45:45 2018

Style: order in .cc should follow the order in .h

Order the introduction/use of FileManageBrowserTestBase methods, types
etc in the Chromium style. Also fix a comment overflow at 80 columns.

Bug: 836254
Change-Id: Ibb0f0dc10d4ca4191a83d9ec3b0cbd4e1a52fcce
Reviewed-on: https://chromium-review.googlesource.com/1138034
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575219}
[modify] https://crrev.com/b06141eceaf5bc42a1e36e59ace24b8fb52cf1ad/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/b06141eceaf5bc42a1e36e59ace24b8fb52cf1ad/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db22bae6f7dcdfbdbb26007baaee9b44a05277e4

commit db22bae6f7dcdfbdbb26007baaee9b44a05277e4
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jul 16 10:52:39 2018

Add autoStep helper to FileManager integration test extensions

Add autoStep() helper for step-by-step mode. Typing it at the devtools
console (or evaluating it in other remote inspection tools) causes all
the test steps to run automatically in step by step mode [1].

[1] out/Release/browser_tests --enable-file-manager-step-by-step-tests

Tbr: lucmult
Bug:  863800 ,836254
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5923f2ad0cc4fcc98e20e7bdf66e9ad504a4f9cf
Reviewed-on: https://chromium-review.googlesource.com/1137968
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575220}
[modify] https://crrev.com/db22bae6f7dcdfbdbb26007baaee9b44a05277e4/ui/file_manager/integration_tests/remote_call.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fabc87ea47f7376d72810e83a720799d9216bf19

commit fabc87ea47f7376d72810e83a720799d9216bf19
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jul 23 05:49:30 2018

Add GetFullTestCaseName FilesAppBrowserTestBase helper

Add helper to read the "full test case name". Any derived classes that
have testing options (TabletMode, GuestMode, etc) can include those in
the full test case name.

Update FileManagerBrowertestBase to log the "full test case name" when
starting a browser test.

Bug: 836254
Change-Id: I9613a4682a6ae91fb03a842ce20924ceb21c1930
Reviewed-on: https://chromium-review.googlesource.com/1146412
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577111}
[modify] https://crrev.com/fabc87ea47f7376d72810e83a720799d9216bf19/chrome/browser/chromeos/file_manager/audio_player_browsertest.cc
[modify] https://crrev.com/fabc87ea47f7376d72810e83a720799d9216bf19/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/fabc87ea47f7376d72810e83a720799d9216bf19/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/fabc87ea47f7376d72810e83a720799d9216bf19/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
[modify] https://crrev.com/fabc87ea47f7376d72810e83a720799d9216bf19/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
[modify] https://crrev.com/fabc87ea47f7376d72810e83a720799d9216bf19/chrome/browser/chromeos/file_manager/video_player_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/429635004c2ef6e0ffaba1a35c2e7f58ee6f041b

commit 429635004c2ef6e0ffaba1a35c2e7f58ee6f041b
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jul 23 13:40:22 2018

Rename MultiProfileFilesAppBrowserTest

Rename the FileManager part of the test fixture to FilesApp since it's
all FilesApp these days, and it simplifies --gtest-filter.

Bug: 836254
Change-Id: Ibfd29300ced82fec3029864230c4db8f1e3accee
Reviewed-on: https://chromium-review.googlesource.com/1146416
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577162}
[modify] https://crrev.com/429635004c2ef6e0ffaba1a35c2e7f58ee6f041b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/429635004c2ef6e0ffaba1a35c2e7f58ee6f041b/services/identity/public/cpp/identity_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7eb6fc7a52d8d8dc190cf32dc5e5cbcf82f790

commit de7eb6fc7a52d8d8dc190cf32dc5e5cbcf82f790
Author: Noel Gordon <noel@chromium.org>
Date: Tue Jul 31 05:46:25 2018

Add a mainfest decription to integration test extensions

Most test extensions manifest's have a descripton: the Files, Gallery,
Video Player, Audio Player test extension do not (how very odd). Let's
give them a description, for consistency with all test extensions.

Bug: 836254
Change-Id: I43dce817da53f9ae7a584f4b30907c3c0649ee85
Reviewed-on: https://chromium-review.googlesource.com/1156118
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579322}
[modify] https://crrev.com/de7eb6fc7a52d8d8dc190cf32dc5e5cbcf82f790/ui/file_manager/integration_tests/audio_player_test_manifest.json
[modify] https://crrev.com/de7eb6fc7a52d8d8dc190cf32dc5e5cbcf82f790/ui/file_manager/integration_tests/file_manager_test_manifest.json
[modify] https://crrev.com/de7eb6fc7a52d8d8dc190cf32dc5e5cbcf82f790/ui/file_manager/integration_tests/gallery_test_manifest.json
[modify] https://crrev.com/de7eb6fc7a52d8d8dc190cf32dc5e5cbcf82f790/ui/file_manager/integration_tests/video_player_test_manifest.json

Main browser test bots are looking good, but we do notice some TIMEOUT-PASS flake on the Mash browser test MSAN/ASAN bots for any tests that have test-times near the bot time-out limit.

Extensions have an idle time-out: 5 secs in absolute time, and that regardless of the bot a test is being run on.  One idea is that scaling the idle time-out for the test bot type (MSAN/ASAN, etc) might help to move the test-time away from the bot time-out limit, and reduce the TIMEOUT_PASS flake rate.

Worth a quick experiment to find out ...

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39eca9d4b75ed6b9dd00d5347b9447136e1cbf15

commit 39eca9d4b75ed6b9dd00d5347b9447136e1cbf15
Author: Noel Gordon <noel@chromium.org>
Date: Tue Aug 14 02:02:54 2018

Experiment: Apply extensions idle timeout in Files App browser test

On Mash bots in MSAN ASAN, some test times are near the bot's time-out
and sometimes hit the limit causing a flaky timeout (depending on what
other load the bot has at the time).

The extension idle time-out is fixed value, and it is conjectured that
scaling it for the bot type (MSAN/ASAN/etc) will help to keep FilesApp
event pages active longer during tests on those bots, and maybe reduce
overall test-time.

Worth an experiment: set the extensions idle timeout during final test
setup, prior to loading the FilesApp component extensions.

Bug: 836254
Change-Id: I554358d284cb72dc0c55109d015328c51309c45d
Reviewed-on: https://chromium-review.googlesource.com/1172235
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582795}
[modify] https://crrev.com/39eca9d4b75ed6b9dd00d5347b9447136e1cbf15/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Takes days for results to arrive. An example test to watch on MASH would be

FolderShortcuts/FilesAppBrowserTest.Test/addRemoveFolderShortcuts

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=mash_browser_tests&tests=FolderShortcuts%2FFilesAppBrowserTest.Test%2FaddRemoveFolderShortcuts 

Test opens two Files.App windows, test time avg 55 sec on ASAN, bot time-out is 60 secs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab46e1729c3d55c9b167abf9e107a493e506150f

commit ab46e1729c3d55c9b167abf9e107a493e506150f
Author: Noel Gordon <noel@chromium.org>
Date: Thu Aug 16 04:55:24 2018

Revert "Experiment: Apply extensions idle timeout in Files App browser test"

This reverts commit 39eca9d4b75ed6b9dd00d5347b9447136e1cbf15.

Reason for revert: Inclusive results, no strong evidence of flake
rate improvements (reduction). Experiment done, backing this out.

Original change's description:
> Experiment: Apply extensions idle timeout in Files App browser test
> 
> On Mash bots in MSAN ASAN, some test times are near the bot's time-out
> and sometimes hit the limit causing a flaky timeout (depending on what
> other load the bot has at the time).
> 
> The extension idle time-out is fixed value, and it is conjectured that
> scaling it for the bot type (MSAN/ASAN/etc) will help to keep FilesApp
> event pages active longer during tests on those bots, and maybe reduce
> overall test-time.
> 
> Worth an experiment: set the extensions idle timeout during final test
> setup, prior to loading the FilesApp component extensions.
> 
> Bug: 836254
> Change-Id: I554358d284cb72dc0c55109d015328c51309c45d
> Reviewed-on: https://chromium-review.googlesource.com/1172235
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582795}

TBR=rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836254
Change-Id: Ibe663866f538700f9ecb7b29eb513a4b7a699933
Reviewed-on: https://chromium-review.googlesource.com/1176842
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583538}
[modify] https://crrev.com/ab46e1729c3d55c9b167abf9e107a493e506150f/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Removing the milestone as this is an ongoing effort and this bug reflects many independent ongoing fixes.

I noticed that some of these test just recently started being more flaky. 

FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs_MyFilesVolume seems to be failing the most reliably. 

Here's a link to the flakiness dashboard for this test: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs_MyFilesVolume . As far as I can tell this seems to have started around https://chromium.googlesource.com/chromium/src/+/a200e01709849a81d769287bae4069f58797fb9d . I didn't readily see any obvious culprits in that timeframe.

It's https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjM1NDZjZTdlODNjZTQ5ZmE0Y2Y1MmNkOGY1NTkxNDIxYjRhY2U4OQw. https://chromium-review.googlesource.com/c/chromium/src/+/1404541 should fix it.