New issue
Advanced search Search tips

Issue 836251 link

Starred by 2 users
Status: Verified
Owner:
pbos@chromium.org
Closed: May 2018
Cc:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews-Browser] Spacing of the first item on the BMB looks too close to the window border

Project Member Reported by meh...@chromium.org, Apr 24 2018 
Chrome Version: Canary 68.0.3405.0
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable MacViews-Browser
(2) Open a Window
(3) Hover over the first Bookmark Item in the Bookmarks Bar
(4) Compare the spacing from the window border to hover button

What is the expected result?
After the spacing was changed in  issue 826264 , the spacing of the first item could be a bit wider. Maybe it could be also 6px or it could have the same spacing like the "Other Bookmarks" Folder (12px?) on the right side. Actually it looks like 4px.

What happens instead?
The first Item looks too close to the window border now.

Thanks :-)
Mehmet
First Item.png
40.8 KB View Download
Other Bookmarks.png
41.3 KB View Download

Comment 1 by meh...@chromium.org, Apr 24 2018 

Maybe shifting the first item by +2px to the right (to 6px? in total) would be probably sufficent. It would be then nicely aligned with the back arrow hover button :-)

Thanks for looking into it.
shifting BM item by 2px to the right.png
46.7 KB View Download

Comment 2 by ellyjo...@chromium.org, Apr 25 2018

Labels: M-68 MacViews-Browser Target-68
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
Bookmark bar stuff over to pbos@ :)

Comment 3 by gov...@chromium.org, Apr 25 2018 

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4116d5a4121a0e7cc7b0cd4d399838d324d527b0

commit 4116d5a4121a0e7cc7b0cd4d399838d324d527b0
Author: Peter Boström <pbos@chromium.org>
Date: Thu May 10 01:44:42 2018

Align bookmark buttons with toolbar buttons

* Increases horizontal margins for bookmarks bar but removes additional
  margin for the detached bar.
* Uses 8dp margins for toolbar view for all non-touch layouts to align
  with the bookmarks bar.
* Uses corner-radius metric directly for ink-drops, matching toolbar
  buttons.
* Insets bookmark buttons by 2dp for older layouts as they use 24dp
  ink-drops.

Bug:  chromium:822072 ,  chromium:836251 
Change-Id: If7ba788678732be29921e4ef5d90e8e80815efd7
Reviewed-on: https://chromium-review.googlesource.com/1043255
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557414}
[modify] https://crrev.com/4116d5a4121a0e7cc7b0cd4d399838d324d527b0/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/4116d5a4121a0e7cc7b0cd4d399838d324d527b0/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/4116d5a4121a0e7cc7b0cd4d399838d324d527b0/chrome/test/data/extensions/api_test/window_update/sizing/test.js

Comment 5 by meh...@chromium.org, May 10 2018 

Looks great in latest Canary! Thanks pbos@.

Comment 6 by pbos@chromium.org, May 10 2018

Status: Verified (was: Assigned)
Thanks for noticing! I'll take "Looks great" as verified. :)
►

Sign in to add a comment