New issue
Advanced search Search tips

Issue 836250 link

Starred by 2 users
Status: Assigned
Owner: ----
Cc:
bcwh...@chromium.org
isherman@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 836238



Sign in to add a comment

MediaRouter.Cast.Channel.Error Is Instantiated Multiple Ways

Project Member Reported by bcwh...@chromium.org, Apr 24 2018 
Chrome Version: HEAD
OS: ALL

Some of your data is being quietly discarded and may be causing Chrome to crash pre-M68!

The MediaRouter.Cast.Channel.Error histogram (aka -1561887015) is being reported as created with mismatched construction parameters:

https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=Histogram.MismatchedConstructionArguments&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

Codesearch shows only one instantiation here:
https://cs.chromium.org/chromium/src/chrome/browser/media/router/discovery/media_sink_discovery_metrics.cc?rcl=bc529d6ce6384e6d458add61870aa15e41542842&l=103

Added in this CL:
https://chromium-review.googlesource.com/673354

But sometimes the histograms come from outside (like extensions or plugins) and are directly deserialized into the Browser.  If the source of that data differs from what is in the Browser code, this error can occur.

Comment 1 by imch...@chromium.org, Apr 24 2018

Owner: imch...@chromium.org
Status: Assigned (was: Untriaged)
The Media Router extension also record the same metric. I am not sure why there would be a mismatch though. Regardless, since we rolled out in-browser Cast discovery in M64, it's no longer necessary to record the metric on the extension. cl/192204693 removes it as part of cleanup.

Comment 2 by bcwh...@chromium.org, Apr 25 2018 

Perhaps a different number of buckets?

Comment 3 by bcwh...@chromium.org, Sep 6 

Has this rolled out?  There is still a significant number of them.

https://uma.googleplex.com/p/chrome/timeline_v2/?sid=3df55f516d6ad21951208c4079ec2c48

Comment 4 by imch...@chromium.org, Sep 24

Cc: -imch...@chromium.org bcwh...@chromium.org
Components: Internals>Cast
Owner: ----
The code to record the metric from the Media Router extension has been removed from the version that goes out with Chrome 70. It looks like the numbers for 70 and 71 have are not quite yet zero, though I expect the mismatch to no longer occur once the user picks up the updated extension, which happens automatically. Keeping this open in case the mismatch stays unexpectedly.

Comment 5 by bcwh...@chromium.org, Sep 25 

I know it's still happening on M71 because I've had a mismatch CHECK and its crashing on "MediaRouter.Cast.Channel.Error" because it's going from 7 buckets to 9 buckets.

Not too often, though.  15 or so crashes today on Canary.  I just submitted a patch today to not crash for linear histogram mismatches.
►

Sign in to add a comment