New issue
Advanced search Search tips

Issue 836241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

virtual/android/fullscreen/video-controls-timeline.html flaky on linux

Project Member Reported by xidac...@chromium.org, Apr 24 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a97d26c6150766e2a8b073f9d01c1395fe4ace

commit 92a97d26c6150766e2a8b073f9d01c1395fe4ace
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Apr 24 14:52:52 2018

Mark virtual/android/fullscreen/video-controls-timeline.html flaky on linux

TBR=thestig@chromium.org
NOTRY=true

Bug:  836241 
Change-Id: Idfe38c1419121cbf99295d54aa3bf059a84a0359
Reviewed-on: https://chromium-review.googlesource.com/1025957
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553104}
[modify] https://crrev.com/92a97d26c6150766e2a8b073f9d01c1395fe4ace/third_party/WebKit/LayoutTests/TestExpectations

Cc: steimel@chromium.org beccahughes@chromium.org mlamouri@chromium.org
Components: Blink>Media>Controls
Labels: -Pri-3 Pri-2
Owner: ----
Status: Available (was: Assigned)
At first glance, looks like the test is ending before the video updates from the seek. Maybe we should wait for a "seeked" event on the video instead of a "mouseup" on the timeline? Adding to list of P2s for broken layout tests.
Owner: steimel@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a88eebcf319ecfb14cc2b8a788e6e1c7007609e2

commit a88eebcf319ecfb14cc2b8a788e6e1c7007609e2
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed May 02 00:35:52 2018

Fix flaky video-controls-timeline layout test

This CL changes the fullscreen/video-controls-timeline.html layout test
to wait for the "seeked" event on the video instead of just the
"mouseup" event on the timeline to ensure that the video has updated
correctly to match the expected image.

Bug:  836241 
Change-Id: Ia9a846db3eaba1452be3c21205f815da8f29893e
Reviewed-on: https://chromium-review.googlesource.com/1038762
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555251}
[modify] https://crrev.com/a88eebcf319ecfb14cc2b8a788e6e1c7007609e2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a88eebcf319ecfb14cc2b8a788e6e1c7007609e2/third_party/WebKit/LayoutTests/fullscreen/video-controls-timeline-expected.txt
[modify] https://crrev.com/a88eebcf319ecfb14cc2b8a788e6e1c7007609e2/third_party/WebKit/LayoutTests/fullscreen/video-controls-timeline.html

Status: Fixed (was: Started)

Sign in to add a comment