New issue
Advanced search Search tips

Issue 836236 link

Starred by 1 user
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

URL bar background color does not animate

Project Member Reported by cjgrant@chromium.org, Apr 24 2018 
When moving from regular to incognito mode and back, the environment colors/brightness animate, but the URL bar snaps to its new color.

This was not previously the case, but it appears to have regressed (probably in one of the URL bar cleanup refactors).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8cc09911157bb9e6b29b07fa5666c0dbf96ca8

commit 9c8cc09911157bb9e6b29b07fa5666c0dbf96ca8
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Apr 24 17:16:14 2018

VR: Restore color animation on URL bar

The URL bar color should animate when switching to and from incognito
mode.

BUG= 836236 
R=asimjour

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I4bd0eda60d5bc0852dfc739e5fd20c5b6c970291
Reviewed-on: https://chromium-review.googlesource.com/1025955
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553184}
[modify] https://crrev.com/9c8cc09911157bb9e6b29b07fa5666c0dbf96ca8/chrome/browser/vr/ui_scene_creator.cc

Comment 2 by cjgrant@chromium.org, Apr 24 2018

Labels: Merge-Request-67
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab05830bb29b2b2a39172b338a57397e287205b5

commit ab05830bb29b2b2a39172b338a57397e287205b5
Author: Christopher Grant <cjgrant@chromium.org>
Date: Wed Apr 25 17:37:42 2018

VR: Restore color animation on URL bar

The URL bar color should animate when switching to and from incognito
mode.

BUG= 836236 
R=​asimjour

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I4bd0eda60d5bc0852dfc739e5fd20c5b6c970291
Reviewed-on: https://chromium-review.googlesource.com/1025955
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553184}(cherry picked from commit 9c8cc09911157bb9e6b29b07fa5666c0dbf96ca8)
Reviewed-on: https://chromium-review.googlesource.com/1028431
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#299}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/ab05830bb29b2b2a39172b338a57397e287205b5/chrome/browser/vr/ui_scene_creator.cc

Comment 5 by cjgrant@chromium.org, Apr 25 2018

Status: Fixed (was: Started)

Comment 6 by dougman@chromium.org, May 8 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Fix verified on build 67.0.3396.29 beta.  Looks good.
►

Sign in to add a comment