New issue
Advanced search Search tips

Issue 836225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Windows toolchain versioning is not available for 3rd parties

Project Member Reported by kkinnu...@nvidia.com, Apr 24 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(0) cd src
(1) set DEPOT_TOOLS_WIN_TOOLCHAIN=0
(2) set DEPOT_TOOLS_WIN_TOOLCHAIN_HTTP_BASE_URL=http://myinternal/win_toolchains/
(3) gclient runhooks

What is the expected result?

Succesfully downloaded MSVC toolchain that is packaged by the 3rd party and that roughly corresponds to the canonical Google-maintained toolchain.

What happens instead?

Tries to download MSVC toolchain from GS restricted location.





Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82979c0f0f248f2fe60dfa142c3c193ced1f7572

commit 82979c0f0f248f2fe60dfa142c3c193ced1f7572
Author: Kimmo Kinnunen <kkinnunen@nvidia.com>
Date: Wed Apr 25 07:28:57 2018

Support MSVC depot tools toolchains for 3rd parties

Third parties would construct toolchain packages on their own,
with the best of their abilities, based on the instructions
provided.

They could then accumulate <canonical hash> -> <their own hash> pairs
in their environment to support historical builds.

Example mapping:
set GYP_MSVS_HASH_1180cb75833ea365097e279efb2d5d7a42dee4b0=4181fce548fece344a85cb6898cf996692998531

Bug:  836225 
Change-Id: I4a46e51b09049340344c9717481b141a2a7c296b
Reviewed-on: https://chromium-review.googlesource.com/1025896
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#553476}
[modify] https://crrev.com/82979c0f0f248f2fe60dfa142c3c193ced1f7572/build/vs_toolchain.py

Owner: kkinnu...@nvidia.com
Status: Fixed (was: Untriaged)

Sign in to add a comment