New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836214 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Make the offline messaging consistent with Google products

Project Member Reported by edwardjung@chromium.org, Apr 24 2018

Issue description

Currently the offline interstitial title shows 'There is no internet connection', this should be change to the more succinct 'No internet' which is used across other Google apps when offline.
 
Screen Shot 2018-04-24 at 2.36.26 PM.png
47.3 KB View Download
Cc: srahim@chromium.org
Shimi, do we do lowercase or uppercase "internet"? Screenshot in #1 with lowercase, but in other screenshots we use uppercase. It was previously uppercase.

Comment 3 by mmenke@chromium.org, Apr 24 2018

Per https://sites.google.com/corp/google.com/yt-writing/word-list, Internet should always be capitalized.

Comment 4 by mmenke@chromium.org, Apr 24 2018

(Admittedly, that's youtube's list - not sure if there's a more general one)
I spoke to Shimi and now we use the AP style which is lowercase. 


Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d481772f21662975035ffdcb5659e3d5e607ce40

commit d481772f21662975035ffdcb5659e3d5e607ce40
Author: Edward Jung <edwardjung@chromium.org>
Date: Tue Apr 24 16:55:25 2018

Update title for offline interstitials

Makes the string consistent with other Google products.

Bug:  836214 
Change-Id: I28a3fa35be8c29960b93eed208acd934a4eb4787
Reviewed-on: https://chromium-review.googlesource.com/1025098
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553163}
[modify] https://crrev.com/d481772f21662975035ffdcb5659e3d5e607ce40/components/error_page_strings.grdp

Labels: TE-Verified-68.0.3406.0 TE-Verified-M68
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #68.0.3406.0 as per the comment #0 and #1.
Attaching screen shot for reference.
Observed that 'No internet' is seen when internet is disconnected.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Were able to see 'There is no internet connection' in older versions.

Thanks...!!
Status: Verified (was: Started)

Sign in to add a comment