No blur effect in the bottom toolbar on NTP |
|||||
Issue descriptionWith UI refresh flag enabled. What steps will reproduce the problem? (1) Open a NTP with some suggestions What is the expected result? The bottom toolbar should have a translucency effect and the suggested content should be visible below it. What happens instead? The toolbar background color is solid white. This is because the NTP frame isn't going below the toolbar. It probably has to do with the fact that the NTP is now contained in a new ViewController instead of being directly added to BVC.
,
Apr 24 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e43cdce441f815ec98afbe0589aad0181ff8ba97 commit e43cdce441f815ec98afbe0589aad0181ff8ba97 Author: Justin Cohen <justincohen@google.com> Date: Wed Apr 25 17:37:32 2018 [ios] Change content suggestions inset from a frame inset to a collectionView inset. crrev/c/989249 mistakenly inset the frame of native content the height of the bottom toolbar. Instead, native content should appear underneath the bottom toolbar, but set it's collection view inset so everything is visible on scroll. This way we can show a blur under the bottom toolbar. This CL reverts those changes to ios/web to inset native content, and instead moves the contentInset logic to BVC. This is somewhat similar to how this should work when NTP moves out of native content, although the method in which we set contentInset will change. Bug: 836205 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3518ad167f9f1ddcc9b65b087fad4869429747f8 Reviewed-on: https://chromium-review.googlesource.com/1026231 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#553629} [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/chrome/browser/prerender/preload_controller.mm [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/web/public/test/fakes/test_native_content_provider.mm [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/web/public/web_state/ui/crw_native_content_provider.h [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/web/web_state/ui/crw_web_controller_container_view.h [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/web/web_state/ui/crw_web_controller_container_view.mm [modify] https://crrev.com/e43cdce441f815ec98afbe0589aad0181ff8ba97/ios/web/web_state/ui/crw_web_controller_container_view_unittest.mm
,
Apr 25 2018
,
Apr 26 2018
,
May 1 2018
Verified in 68.0.3416.0 Canary, iPhone X iOS 11.4 beta 2, iPhone 6 iOS 10.3.3, iPhone 7 iOS11.4 beta 2, iPad Pro iOS11.3 https://drive.google.com/file/d/1MR-QdB92t4aqPqOzq2LmydVHG3UZM5ti/view |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by justincohen@chromium.org
, Apr 24 2018