New issue
Advanced search Search tips

Issue 836188 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

2 ExtensionRequestLimitingThrottleBrowserTests are flaky on Linux ChromiumOS MSan Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 24 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of clamy@google.com

ExtensionRequestLimitingThrottleBrowserTest.ThrottleRequest_RedirectCached and ExtensionRequestLimitingThrottleBrowserTest.ThrottleRequest_Redirect are flaky on Linux ChromiumOS MSan. I'm disabling the tests.
@rdevlin: can you investigate? Thanks!

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/140e3855b3c64993126f51f0da027452ec0ca65d

commit 140e3855b3c64993126f51f0da027452ec0ca65d
Author: clamy <clamy@chromium.org>
Date: Tue Apr 24 12:49:51 2018

Disable two flaky extensions tests on ChromeOS

This CL disable to extensions browser_tests that are flaky on ChromeOS
MSan bots.

TBR=thestig@chromium.org, xidachen@chromium.org
NOTRY=true

Bug: 836188
Change-Id: I0579a0129291a82a0818b31046cd946a469abd02
Reviewed-on: https://chromium-review.googlesource.com/1025755
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553061}
[modify] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/chrome/browser/extensions/extension_request_limiting_throttle_browsertest.cc

Comment 2 by clamy@chromium.org, Apr 24 2018

Labels: -Sheriff-Chromium
Components: Platform>Extensions
Labels: OS-Chrome Type-Bug
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6859%2F%2B%2Frecipes%2Fsteps%2Fmus_browser_tests%2F0%2Flogs%2FExtensionRequestLimitingThrottleBrowserTest.ThrottleRequest_Redirect%2F0

[ RUN      ] ExtensionRequestLimitingThrottleBrowserTest.ThrottleRequest_Redirect
[25967:26180:0424/052601.176870:ERROR:account_manager.cc(37)] Failed to read tokens file
[25967:25967:0424/052601.249698:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user.
[25967:25967:0424/052602.359691:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25967:25967:0424/052602.360582:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25967:25967:0424/052602.361476:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25967:25967:0424/052602.361689:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[25967:25967:0424/052606.868381:INFO:CONSOLE(0)] "[FAIL] (no test): API Test Error in (no test)
Actual: 4
Expected: 3
Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at Object.<anonymous> (extensions::test:243:18)
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at chrome-extension://jpcedhcpohjighbhhlhnjpjegfijjine/test_request_eventually_throttled.js:20:15
    at EventImpl.dispatchToListener (extensions::event_bindings:403:22)
Owner: cmumford@chromium.org
Status: Started (was: Available)
Refactoring as part of  issue 784576  and will test if this is still flakey as part of that effort.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0eda935338567fd3c770fd24b44a3af46a4b3b

commit 3f0eda935338567fd3c770fd24b44a3af46a4b3b
Author: Chris Mumford <cmumford@chromium.org>
Date: Mon Jul 23 14:51:17 2018

Implement Extension request throttling for network service.

This change introduces the ExtensionURLLoaderThrottle which
exists in the renderer and replaces ExtensionRequestLimitingThrottle
when the network service is both enabled and disabled.

Also re-enabled two extension throttle tests to speculatively
fix issue 836188. Hopefully now that the throttling is done in
the renderer they will no longer be flaky.

Bug:  784576 ,836188
Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib0c18f7b3fb17f4fbe47d79bf2f5bd7f1ebd6e06
Reviewed-on: https://chromium-review.googlesource.com/914589
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577168}
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/android_webview/renderer/aw_url_loader_throttle_provider.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/android_webview/renderer/aw_url_loader_throttle_provider.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/browser/chrome_content_browser_client.cc
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/browser/extensions/extension_url_loader_throttle_browsertest.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/common/chrome_switches.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/common/chrome_switches.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/renderer/url_loader_throttle_provider_impl.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/renderer/url_loader_throttle_provider_impl.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/test/BUILD.gn
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/test/data/extensions/extension_throttle/background.js
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/chrome/test/data/extensions/extension_throttle/test_request_eventually_throttled.html
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/chrome/test/data/extensions/extension_throttle/test_request_eventually_throttled.js
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/chrome/test/data/extensions/extension_throttle/test_request_not_throttled.html
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/chrome/test/data/extensions/extension_throttle/test_request_not_throttled.js
[add] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/test/data/extensions/extension_throttle/test_request_throttle.html
[add] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/chrome/test/data/extensions/extension_throttle/test_request_throttle.js
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/chrome/test/data/extensions/extension_throttle/test_request_throttled_on_first_try.html
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/chrome/test/data/extensions/extension_throttle/test_request_throttled_on_first_try.js
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/content/public/renderer/url_loader_throttle_provider.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/browser/BUILD.gn
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/extensions/browser/extension_request_limiting_throttle.cc
[delete] https://crrev.com/42f02d90384e3fb427379cd86880282c4dbcae5d/extensions/browser/extension_request_limiting_throttle.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/common/switches.cc
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/common/switches.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/BUILD.gn
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/DEPS
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_entry.cc
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_entry.h
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_entry_interface.h
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_manager.cc
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_manager.h
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_simulation_unittest.cc
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_test_support.cc
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_test_support.h
[rename] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_throttle_unittest.cc
[add] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_url_loader_throttle.cc
[add] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/extensions/renderer/extension_url_loader_throttle.h
[modify] https://crrev.com/3f0eda935338567fd3c770fd24b44a3af46a4b3b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/362d353a8e833c7f2c7e42e38623521beca16156

commit 362d353a8e833c7f2c7e42e38623521beca16156
Author: Chris Mumford <cmumford@google.com>
Date: Fri Oct 26 23:56:25 2018

Remove unused NetworkChangeManager interface handler.

GetNetworkChangeManager was incorrectly added in r577168 but was
never called. This change removes that vestigial code.

Bug: 836188
Change-Id: I618712829d04e94c1bb4e2c1d3fe5c16475daa6f
Reviewed-on: https://chromium-review.googlesource.com/c/1271556
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603261}
[modify] https://crrev.com/362d353a8e833c7f2c7e42e38623521beca16156/content/browser/renderer_host/render_process_host_impl.cc

Sign in to add a comment