In guest mode, browser process restarts when starting Settings or Files from launcher |
||||
Issue descriptionChrome Version: 68.0.3406.0 (commit 8f61186fceb772d626f6e38eeb632a4d5b0c119d) Chrome OS Version: 10611.0.0 (Ofiicial Build) dev-channel caroline test Chrome OS Platform: Samsung Chromebook Pro Network info: Not relevant (wired) Steps To Reproduce: (1) Enter the guest mode by "Browse as guest". (2) Clicking the circle icon at the bottom left corner of the desktop. See app launcher opens with recently used items. (3) Click either "Files" or "Settings" icon. Expected Result: Files app or Settings app opens. Actual Result: All the windows and tabs are closed. The screen freezes for a moment, then comes back with the single browser window containing 1 new tab. (I guess the browser process restarted, but not sure) How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always - This didn't happen when in a regular session with a Google account. - The Files app still worked in the dialog box mode (e.g. [ctrl]+[o] in the browser). - No repro on 68.0.3404.0 / 10611.0.0 (099ffc7ea181).
,
Apr 24 2018
I've finished bisecting. This happens since commit f8503ed204436b6a5d7f0fd5417f8263752acfc8. https://chromium-review.googlesource.com/1011485
,
Apr 24 2018
xiyuan@, will you take a look because timloh@ is absent until tomorrow?
,
Apr 24 2018
CrostiniRegistryServiceFactory uses the default setup hence no service for guest user [1]. And we crash here [2] because of that. I will fix the crash by null check |registry_service|, assuming that we don't want crostini for guest user. [1] https://cs.chromium.org/chromium/src/components/keyed_service/content/browser_context_keyed_service_factory.cc?rcl=2004f4bc6193b1115f1fff051c983f881c6fd2bd&l=61 [2] https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc?rcl=46a15abd9382ae51aabc3b16823b4724b7f93b50&l=207
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f077d19beabbb5ce4e6dc60eb23dce124ec18f56 commit f077d19beabbb5ce4e6dc60eb23dce124ec18f56 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Apr 25 19:17:56 2018 crostini: Fix crash in guest user session Bug: 836187 Change-Id: Id072e00ca0d6e4f278a43f34deea6880d2aa0536 Reviewed-on: https://chromium-review.googlesource.com/1026039 Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553694} [modify] https://crrev.com/f077d19beabbb5ce4e6dc60eb23dce124ec18f56/chrome/browser/ui/ash/launcher/launcher_context_menu.cc [modify] https://crrev.com/f077d19beabbb5ce4e6dc60eb23dce124ec18f56/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc
,
Apr 25 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90d409102910100cbcb3e3073e28fea283288944 commit 90d409102910100cbcb3e3073e28fea283288944 Author: Timothy Loh <timloh@chromium.org> Date: Fri Apr 27 03:46:13 2018 Avoid creating Crostini UI objects on guest and ephemeral profiles As Crostini is not supported on guest and ephemeral profiles, we change IsExperimentalCrostiniUIEnabled() into IsCrostiniUIAllowedForProfile() so we can avoid creating the various controllers and builders. This makes us less likely to assume a CrostiniRegistryService exists when one actually doesn't. Bug: 836187 Change-Id: I5a65ad250edcb16daf381dfd77d7a5df0a1de98f Reviewed-on: https://chromium-review.googlesource.com/1029934 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554294} [modify] https://crrev.com/90d409102910100cbcb3e3073e28fea283288944/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/90d409102910100cbcb3e3073e28fea283288944/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/90d409102910100cbcb3e3073e28fea283288944/chrome/browser/ui/app_list/app_list_syncable_service.cc [modify] https://crrev.com/90d409102910100cbcb3e3073e28fea283288944/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc [modify] https://crrev.com/90d409102910100cbcb3e3073e28fea283288944/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c593fad9d048268d2badfa7623e2125554eba0a commit 7c593fad9d048268d2badfa7623e2125554eba0a Author: Timothy Loh <timloh@chromium.org> Date: Fri Apr 27 04:05:05 2018 Revert "Avoid creating Crostini UI objects on guest and ephemeral profiles" This reverts commit 90d409102910100cbcb3e3073e28fea283288944. Reason for revert: Landed at the same time as https://chromium-review.googlesource.com/c/chromium/src/+/1013824 which used the old function. Original change's description: > Avoid creating Crostini UI objects on guest and ephemeral profiles > > As Crostini is not supported on guest and ephemeral profiles, we change > IsExperimentalCrostiniUIEnabled() into IsCrostiniUIAllowedForProfile() > so we can avoid creating the various controllers and builders. This > makes us less likely to assume a CrostiniRegistryService exists when > one actually doesn't. > > Bug: 836187 > Change-Id: I5a65ad250edcb16daf381dfd77d7a5df0a1de98f > Reviewed-on: https://chromium-review.googlesource.com/1029934 > Commit-Queue: Timothy Loh <timloh@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554294} TBR=xiyuan@chromium.org,timloh@chromium.org Change-Id: I76a977c63aaffdf4de5cc54c8cb02d9a345f2e43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836187 Reviewed-on: https://chromium-review.googlesource.com/1031993 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554296} [modify] https://crrev.com/7c593fad9d048268d2badfa7623e2125554eba0a/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/7c593fad9d048268d2badfa7623e2125554eba0a/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/7c593fad9d048268d2badfa7623e2125554eba0a/chrome/browser/ui/app_list/app_list_syncable_service.cc [modify] https://crrev.com/7c593fad9d048268d2badfa7623e2125554eba0a/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc [modify] https://crrev.com/7c593fad9d048268d2badfa7623e2125554eba0a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8971bda9cbd7895a35338f84621e9942baa799bd commit 8971bda9cbd7895a35338f84621e9942baa799bd Author: Timothy Loh <timloh@chromium.org> Date: Fri Apr 27 05:24:04 2018 Avoid creating Crostini UI objects on guest and ephemeral profiles As Crostini is not supported on guest and ephemeral profiles, we change IsExperimentalCrostiniUIEnabled() into IsCrostiniUIAllowedForProfile() so we can avoid creating the various controllers and builders, as well as not showing UI in the settings page. This makes us less likely to assume a CrostiniRegistryService exists when one actually doesn't. This is a reland of https://crrev.com/c/1029934, which happened to land at the same time as https://crrev.com/c/1013824 causing a compile fail. TBR=xiyuan Bug: 836187 Change-Id: Ifefe467d1135388fa1a25c2fed22d34c09108ddb Reviewed-on: https://chromium-review.googlesource.com/1032131 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554316} [modify] https://crrev.com/8971bda9cbd7895a35338f84621e9942baa799bd/chrome/browser/chromeos/crostini/crostini_util.cc [modify] https://crrev.com/8971bda9cbd7895a35338f84621e9942baa799bd/chrome/browser/chromeos/crostini/crostini_util.h [modify] https://crrev.com/8971bda9cbd7895a35338f84621e9942baa799bd/chrome/browser/ui/app_list/app_list_syncable_service.cc [modify] https://crrev.com/8971bda9cbd7895a35338f84621e9942baa799bd/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc [modify] https://crrev.com/8971bda9cbd7895a35338f84621e9942baa799bd/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/8971bda9cbd7895a35338f84621e9942baa799bd/chrome/browser/ui/webui/settings/md_settings_ui.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by yamaguchi@chromium.org
, Apr 24 2018