New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836172 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression: Glimpse of 'Shut down', temp..buttons at shelf is seen on clicking 'Accept and Continue' button of You're signed in screen

Project Member Reported by rkalavakuntla@chromium.org, Apr 24 2018

Issue description

Chrome Version:68.0.3404.0/10611.0.0 dev channel Daisy,Candy,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build, Sign into Chromebook
(2)You'Re signed screen >> click on 'Accept and Continue' button and observe weird glimpse of 'Shut down', temp..buttons at shelf

Actual :Glimpse of 'Shut down', temp..buttons at shelf is seen on clicking 'Accept and Continue' button
Expected: No such glimpse of unnecessary buttons should be seen

This is a Regression issue as same is working fine in 68.0.3400.0/10598.0.0 dev 

Note : Issue is not seen in Linux, Windows OS

Attached the screencast for reference..


 

 
Actual.mp4
2.5 MB View Download
Expected.mp4
3.7 MB View Download

Comment 1 by wzang@chromium.org, Apr 24 2018

Cc: jdufault@chromium.org
Components: -UI>SignIn UI>Shell>StartScreen
Owner: jdufault@chromium.org
Cc: r...@chromium.org
Labels: -M-68 M-69
Owner: qnnguyen@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4e7fd6427308b7a3f40259afc73d4f41ece144

commit fb4e7fd6427308b7a3f40259afc73d4f41ece144
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Aug 07 23:42:01 2018

Don't notify the shelf when OOBE dialog is destroyed.

This stops the shelf from updating its button visibility only to be deleted anyway due to a successful sign-in.

Bug:  836172 
Change-Id: I2a7f31610cd3317c87f06bce064cd0331a583d3c
Reviewed-on: https://chromium-review.googlesource.com/1166156
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581392}
[modify] https://crrev.com/fb4e7fd6427308b7a3f40259afc73d4f41ece144/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc

Status: Fixed (was: Assigned)

Sign in to add a comment