New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836139 link

Starred by 2 users
Status: Fixed
Owner:
mastiz@chromium.org
Closed: May 2018
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 681921



Sign in to add a comment

Sync integration tests don't wait properly for USS types

Project Member Reported by mastiz@chromium.org, Apr 24 2018 
ProfileSyncServiceHarness::AwaitQuiescence() and related functions are supposed to wait until changes have propagated from one client to another.

This relies on HasUnsyncedItems() being properly plumbed through, but the actual implementation currently honors directory-based types only.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aadfdf7b85f74c1127997097d5cdfea350c2c9a9

commit aadfdf7b85f74c1127997097d5cdfea350c2c9a9
Author: Mikel Astiz <mastiz@chromium.org>
Date: Tue Apr 24 15:11:46 2018

Fix ignoring pending local changes in USS tests

HasUnsyncedItems() now honors USS workers.

Bug:  836139 
Change-Id: Id46bcae5a8ed66474e13da3cafba5ef32560cfbe
Reviewed-on: https://chromium-review.googlesource.com/1025713
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553117}
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/chrome/browser/sync/test/integration/sessions_helper.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/chrome/browser/sync/test/integration/sync_auth_test.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/chrome/browser/sync/test/integration/updated_progress_marker_checker.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine/fake_sync_engine.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine/fake_sync_engine.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine/fake_sync_manager.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine/fake_sync_manager.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine/sync_engine.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine/sync_manager.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine_impl/model_type_registry.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine_impl/model_type_worker.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine_impl/model_type_worker.h
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/aadfdf7b85f74c1127997097d5cdfea350c2c9a9/components/sync/engine_impl/sync_manager_impl.h

Comment 2 by mastiz@chromium.org, May 3 2018

Status: Fixed (was: Started)
►

Sign in to add a comment