This bug tracks work to make a new platform for writing system apps (e.g the ChromeOS wallpaper picker).
This bug tracks work to make a new platform for writing system apps (e.g the ChromeOS wallpaper picker). Design Doc: https://docs.google.com/document/d/16CRTWFjU8Ohrn9aSTPuDJcbqh1z7E4wKwyEWstInRh0/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bed22da404a3447472b9b3cf74b59b7012c7dc03 commit bed22da404a3447472b9b3cf74b59b7012c7dc03 Author: Christopher Lam <calamity@chromium.org> Date: Tue May 22 07:22:30 2018 Add MojoWebUIBrowserTest. This CL adds a MojoWebUIBrowserTest for tests that only require Mojo interfaces, and do not need chrome.send. This is in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1025673 which removes chrome.send from Mojo-only WebUIs. Bug: 836128 Change-Id: I3d082fe9022cd03045a24e9d9ca118dbae9d2116 Reviewed-on: https://chromium-review.googlesource.com/1056455 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#560503} [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/browser/BUILD.gn [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/browser/ui/webui/web_ui_test_handler.cc [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/browser/ui/webui/web_ui_test_handler.h [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/BUILD.gn [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/javascript_browser_test.cc [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/js2gtest.gni [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/js2gtest.js [add] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/mojo_web_ui_browser_test.cc [add] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/mojo_web_ui_browser_test.h [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/web_ui_browser_test.cc [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/base/web_ui_browser_test.h [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/data/BUILD.gn [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/data/webui/OWNERS [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/data/webui/test_api.js [add] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/data/webui/web_ui_test.mojom [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/chrome/test/data/webui_test_resources.grd [modify] https://crrev.com/bed22da404a3447472b9b3cf74b59b7012c7dc03/content/public/browser/web_ui_message_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c61f983dbc38c3519a000ab7675095bb097f2725 commit c61f983dbc38c3519a000ab7675095bb097f2725 Author: Christopher Lam <calamity@chromium.org> Date: Thu Jun 14 05:55:50 2018 [snippets-internals] Fix Mojo Closure externs generation. This CL adds an Interface type for concrete implementations to @implement and makes the Mojo interface non-nullable to avoid needing an assert. Bug: 836128 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2f1d07966f734a47c8bc724a11641d0cab67daf Reviewed-on: https://chromium-review.googlesource.com/1088355 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567160} [modify] https://crrev.com/c61f983dbc38c3519a000ab7675095bb097f2725/chrome/browser/resources/snippets_internals/snippets_internals.js [modify] https://crrev.com/c61f983dbc38c3519a000ab7675095bb097f2725/mojo/public/tools/bindings/generators/js_templates/externs/interface_definition.tmpl
https://chromium-review.googlesource.com/c/chromium/src/+/1227865
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e66b7813fa12cca7b950a3b0387625b1271a5d8d commit e66b7813fa12cca7b950a3b0387625b1271a5d8d Author: Christopher Lam <calamity@chromium.org> Date: Wed Sep 26 01:49:24 2018 [System PWAs] Add about:flags entry. This CL adds an about:flags entry for the SystemWebApps feature. Bug: 836128 Change-Id: I83ae0dcd55885ca5e95fe10fb6384aa844ae25df Reviewed-on: https://chromium-review.googlesource.com/1240055 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#594181} [modify] https://crrev.com/e66b7813fa12cca7b950a3b0387625b1271a5d8d/chrome/browser/about_flags.cc [modify] https://crrev.com/e66b7813fa12cca7b950a3b0387625b1271a5d8d/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/e66b7813fa12cca7b950a3b0387625b1271a5d8d/chrome/browser/flag_descriptions.h [modify] https://crrev.com/e66b7813fa12cca7b950a3b0387625b1271a5d8d/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3f2bc970b4f7b4c1d1f4e2b2155440315797107 commit d3f2bc970b4f7b4c1d1f4e2b2155440315797107 Author: Christopher Lam <calamity@chromium.org> Date: Mon Oct 08 12:34:13 2018 [System PWAs] Hide location bar. This CL hides the location bar for System PWAs. It also plumbs better bookmark app manifest validation into ExtensionBrowserTest. Bug: 836128 Change-Id: Ife1ec3962edd57a0f5ea7c44ff359894a9d0d7cf Reviewed-on: https://chromium-review.googlesource.com/c/1256467 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597538} [modify] https://crrev.com/d3f2bc970b4f7b4c1d1f4e2b2155440315797107/chrome/browser/extensions/extension_browsertest.cc [modify] https://crrev.com/d3f2bc970b4f7b4c1d1f4e2b2155440315797107/chrome/browser/extensions/extension_browsertest.h [modify] https://crrev.com/d3f2bc970b4f7b4c1d1f4e2b2155440315797107/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/d3f2bc970b4f7b4c1d1f4e2b2155440315797107/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/d3f2bc970b4f7b4c1d1f4e2b2155440315797107/extensions/browser/extension_creator.cc [modify] https://crrev.com/d3f2bc970b4f7b4c1d1f4e2b2155440315797107/extensions/browser/extension_creator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/811c6675e5641e80b82b46ad626d93f95311f6da commit 811c6675e5641e80b82b46ad626d93f95311f6da Author: Christopher Lam <calamity@chromium.org> Date: Tue Oct 23 03:06:37 2018 [System PWAs] Allow System Web Apps to install as PWAs. This CL alters the System App installation pipeline in order to allow the full PWA setup experience to succeed for System Apps (mostly adding exceptions for chrome:// URLs), allowing System Apps to be installed with a scope. It also adds a browser test which installs a System PWA end to end. Bug: 836128 Change-Id: Ida32fa45484661d32a9607b44e06f28f272d4cc3 Reviewed-on: https://chromium-review.googlesource.com/c/1272636 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601837} [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/extensions/bookmark_app_helper.h [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/extensions/extension_browsertest.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/extensions/extension_browsertest.h [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/installable/installable_logging.h [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/installable/installable_manager.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/BUILD.gn [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/BUILD.gn [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.h [add] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_unittest.cc [add] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/test_system_web_app_manager.cc [add] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/bookmark_apps/test_system_web_app_manager.h [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/components/pending_app_manager.h [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/common/extensions/manifest_handlers/app_launch_info.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/test/BUILD.gn [add] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/chrome/test/data/banners/manifest_chrome_url.json [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/extensions/browser/extension_creator.cc [modify] https://crrev.com/811c6675e5641e80b82b46ad626d93f95311f6da/extensions/browser/extension_creator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4de0b24bf376488d4012b864b2ff9ef4e1054dbc commit 4de0b24bf376488d4012b864b2ff9ef4e1054dbc Author: Christopher Lam <calamity@chromium.org> Date: Mon Oct 29 05:50:59 2018 [System PWAs] Add Manifest for Settings. This CL adds the manifest.json for the Settings System Web App. It also adds a generic PWA installation page for all System Web Apps to use, which will be removed when installation directly from manifest URLs is available. Bug: 836128 Change-Id: I7cdebe6fde5851a3b90e46e39e3118eda1f2cf19 Reviewed-on: https://chromium-review.googlesource.com/c/1272780 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603422} [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/browser_resources.grd [add] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/resources/pwa.html [add] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/resources/settings/manifest.json [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/resources/settings/settings_resources_vulcanized.grd [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc [modify] https://crrev.com/4de0b24bf376488d4012b864b2ff9ef4e1054dbc/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adc1ec51e0c7d3ba1c251304373c18755dcc29e6 commit adc1ec51e0c7d3ba1c251304373c18755dcc29e6 Author: Christopher Lam <calamity@chromium.org> Date: Mon Oct 29 07:44:51 2018 [System PWAs] Add manifest for Discover App. This CL adds a manifest for the Discover App so that it installs as a System PWA with the correct icon, name, and theme color. Bug: 836128 Change-Id: Idd2d86671caa50a02474a1785972aa7f1d7b1fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1290051 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#603434} [modify] https://crrev.com/adc1ec51e0c7d3ba1c251304373c18755dcc29e6/chrome/browser/browser_resources.grd [modify] https://crrev.com/adc1ec51e0c7d3ba1c251304373c18755dcc29e6/chrome/browser/resources/chromeos/login/discover/discover_app.html [add] https://crrev.com/adc1ec51e0c7d3ba1c251304373c18755dcc29e6/chrome/browser/resources/chromeos/login/discover/manifest.json [modify] https://crrev.com/adc1ec51e0c7d3ba1c251304373c18755dcc29e6/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd commit 2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd Author: Christopher Lam <calamity@chromium.org> Date: Tue Oct 30 05:51:00 2018 [System PWAs] Make System PWAs update on Chrome launch. As a temporary measure, make System PWAs update on every Chrome launch. This allows developers to see changes when they update manifests. This will be replaced with a lighter, more robust system before consumer launch. Bug: 836128 Change-Id: I04e65a4a060a6e91c0f7d32bd44be51492e2fd4e Reviewed-on: https://chromium-review.googlesource.com/c/1282503 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#603800} [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/components/pending_app_manager.cc [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/components/pending_app_manager.h [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.cc [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.h [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc [modify] https://crrev.com/2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1162aa3486ce024351a93ad3991b88ba12c02ff commit b1162aa3486ce024351a93ad3991b88ba12c02ff Author: Ben Wells <benwells@chromium.org> Date: Thu Nov 08 03:26:12 2018 Revert "[System PWAs] Make System PWAs update on Chrome launch." This reverts commit 2dd14e92c4a161b8d97cbdf8a28315e3df27b6fd. Reason for revert: This changes the meaning of existing code. E.g. the default app installer now calls with require_manifest false and always_update true, instead of require_manifest true. Original change's description: > [System PWAs] Make System PWAs update on Chrome launch. > > As a temporary measure, make System PWAs update on every Chrome launch. > This allows developers to see changes when they update manifests. This > will be replaced with a lighter, more robust system before consumer > launch. > > Bug: 836128 > Change-Id: I04e65a4a060a6e91c0f7d32bd44be51492e2fd4e > Reviewed-on: https://chromium-review.googlesource.com/c/1282503 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603800} TBR=calamity@chromium.org,alancutter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836128 Change-Id: I997eed1e5154ee1cc4f40eed55c6d2ffdadb2cf1 Reviewed-on: https://chromium-review.googlesource.com/c/1322185 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#606314} [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/components/pending_app_manager.cc [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/components/pending_app_manager.h [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.cc [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.h [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc [modify] https://crrev.com/b1162aa3486ce024351a93ad3991b88ba12c02ff/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7 commit 1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7 Author: Christopher Lam <calamity@chromium.org> Date: Fri Nov 09 07:11:21 2018 [System PWAs] Hide the hosted app button container for System PWAs. System PWAs should not show the Hosted App Button Container UI. This CL hides it on all platforms for System Web Apps. Bug: 836128 Change-Id: I2dc87dea17aa77699f6d6639759645a1c184a2bd Reviewed-on: https://chromium-review.googlesource.com/c/1293294 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606758} [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/extensions/hosted_app_browser_controller.h [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/views/frame/hosted_app_button_container.cc [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/web_applications/bookmark_apps/BUILD.gn [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc [add] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.h [modify] https://crrev.com/1cb034ac8f91b42ea160e8fe0ef1f8f57b21fef7/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d9d864b8a66556f48114e44463dd861cbc375e6 commit 0d9d864b8a66556f48114e44463dd861cbc375e6 Author: Christopher Lam <calamity@chromium.org> Date: Wed Nov 14 08:14:06 2018 [System PWAs] Make System PWAs update on Chrome launch. As a temporary measure, make System PWAs update on every Chrome launch. This allows developers to see changes when they update manifests. This will be replaced with a lighter, more robust system before consumer launch. Bug: 836128 Change-Id: I82febcd9b0f7ae5f8be401bdedbe4846008562f4 Reviewed-on: https://chromium-review.googlesource.com/c/1325595 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#607933} [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_unittest.cc [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/components/pending_app_manager.cc [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/components/pending_app_manager.h [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.cc [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.h [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc [modify] https://crrev.com/0d9d864b8a66556f48114e44463dd861cbc375e6/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
Comment 1 by bugdroid1@chromium.org
, May 22 2018