New issue
Advanced search Search tips

Issue 836113 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-08
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CSS transitions with filter: blur cause element to briefly flash to end of transition

Reported by j...@onerabbit.com.au, Apr 24 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36

Example URL:
https://output.jsbin.com/dibexew

Steps to reproduce the problem:
1. Visit https://output.jsbin.com/dibexew
2. Hover the element
3. Observe a brief "flash" to the last frame of the transition before playing out the full transition correctly.

What is the expected behavior?
The element should smoothly animate the background color and blur from their non-hover state to the hovered state.

What went wrong?
The latest version of Chrome (M66) seems to have broken elements that use a transition on filter: blur().

Whether the transition is trigger via a hover, or via Javascript (eg. appending a class to the element) does not seem to affect the issue.

An even simpler reproduction of the issue is available here: https://jsbin.com/wisuhif.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? Yes Chrome 65

Does this work in other browsers? N/A

Chrome version: 66.0.3359.117  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 29.0 r0

This seems to be a further regression on issue 806293, which was a regression on earlier behavior with transitions and filter: blur().
 

Comment 1 by woxxom@gmail.com, Apr 24 2018

I can repro in Chrome 67/68, not in 66.

Bisect info: 550784 (good) - 550813 (bad)
https://chromium.googlesource.com/chromium/src/+log/dac26aba..59b0df2d?pretty=fuller

Suspecting 625dceb10fd7d7a620af93a0f362e0f541cc0a23 skia roll 21dfd8467..490aa59ce
skia log: https://skia.googlesource.com/skia.git/+log/21dfd846724a..490aa59ce2e9?pretty=fuller

Suspecting 28a142f213cf4d7dd4e6005a96cca6cb67a9887d 
"Don't try to readback from the GPU for small blur sigmas"
Landed in 68.0.3397.0
Merged in 67

Related:  issue 832838 .

Comment 2 by woxxom@gmail.com, Apr 24 2018

BTW I suspect that skia CL because the bug can be circumvented by increasing the blur radius to 20px.
I've just noticed now that under certain circumstances (still unknown) I can't reproduce the issue using the provided simple repro. That may be why you aren't able to see it in Chrome 66 as I have definitely reproduced it on two machines in my office with Chrome 66.0.3359.117.

Changing the blur radius to above 20px does prevent the issue from occurring on hover, but not when returning to the non-hover state (obviously).
Strange development. If I try to use the Nimbus Screen Capture extension for Chrome to try and record the issue, as soon as the screen capture begins, the issue disappears. Once I stop recording, and after closing and opening the repro, the issue occurs again.

Indication that Chrome takes a different code path that bypasses the issue when recording the screen/tab?
Labels: Needs-Bisect Needs-Triage-M66
Cc: phanindra.mandapaka@chromium.org
Components: Blink>CSS
Labels: -Pri-2 -Type-Compat -Needs-Bisect ReleaseBlock-Stable Triaged-ET M-67 Target-67 FoundIn-67 FoundIn-68 Target-68 hasbisect OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: robertphillips@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to reproduce the issue on reported version 66.0.3359.117, but issue is seen in latest dev 67.0.3396.18 and latest canary 68.0.3406.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.3. Hence providing bisect info.

Good Build: 67.0.3396.3
Bad Build: 67.0.3396.7

CL: https://chromium.googlesource.com/chromium/src/+log/67.0.3396.3..67.0.3396.7?pretty=fuller&n=10000

As we are unable to find suspect from above changelog assigning from cl mentioned in comment#1. Suspecting 28a142f213cf4d7dd4e6005a96cca6cb67a9887d 

@robertphillips: Please confirm the bug and help in re-assigning if this is not related to your change. Adding RB-Stable as this is recent regression, Please remove if not the case.

Thanks!

Attached is a video of the simple reproduction in Chrome 66.
blur-flash-bug.mp4
51.0 KB View Download

Comment 8 by cnardi@chromium.org, Apr 29 2018

 Issue 837985  has been merged into this issue.
*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/bd66caa7ac38b68487778064eab10d76bc1d2e48

commit bd66caa7ac38b68487778064eab10d76bc1d2e48
Author: Robert Phillips <robertphillips@google.com>
Date: Fri May 04 17:54:43 2018

Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1

Bug:  836113 
Change-Id: I1b2ed1d67648163571df6c497365d2a293b3b589
Reviewed-on: https://skia-review.googlesource.com/126020
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/bd66caa7ac38b68487778064eab10d76bc1d2e48/src/gpu/effects/GrMatrixConvolutionEffect.cpp

I haven't been able to repro this for M66 at all.

The CL in question (https://skia-review.googlesource.com/c/skia/+/121331 (Don't try to readback from the GPU for small blur sigmas)) was only cherry-picked back to M67 so that isn't all that surprising.

I have landed a fix in M68 and, if it sticks, will cherry-pick it back to M67. I don't know what to do about the bug report for M66.
Project Member

Comment 12 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f276c3b1588be8db84e1a7f7a3b2617f63ea0e6

commit 2f276c3b1588be8db84e1a7f7a3b2617f63ea0e6
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 04 20:48:32 2018

Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits)

https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c

$ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s'
2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice
2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs.
2018-05-04 bungeman Allow finer rotation in Viewer app.
2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)"
2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag
2018-05-04 bsalomon Remove could not invert matrix SkDebugfs
2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops.
2018-05-02 herb Remove android specific code
2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times.
2018-05-04 fmalita [skottie] Disable on Android Framework builds
2018-05-04 borenet [recipes] Remove core.setup()
2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1
2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)
2018-05-04 caryclark Revert "Reland "remove obsolete color defines""
2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer

Created with:
  roll-dep src/third_party/skia
BUG= chromium:836113 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec
Reviewed-on: https://chromium-review.googlesource.com/1044782
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556184}
[modify] https://crrev.com/2f276c3b1588be8db84e1a7f7a3b2617f63ea0e6/DEPS

Comment 13 by woxxom@gmail.com, May 5 2018

Something in the skia CL above seems to have broken font rendering, see  bug 840010 .

Project Member

Comment 14 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/672cc57f93fb23198daf242d123fb4686f47dbe9

commit 672cc57f93fb23198daf242d123fb4686f47dbe9
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon May 07 06:06:24 2018

Revert "Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits)"

This reverts commit 2f276c3b1588be8db84e1a7f7a3b2617f63ea0e6.

Reason for revert: Caused text rendering regression in Windows.  crbug.com/840010 

Original change's description:
> Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits)
> 
> https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c
> 
> $ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s'
> 2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice
> 2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs.
> 2018-05-04 bungeman Allow finer rotation in Viewer app.
> 2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)"
> 2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag
> 2018-05-04 bsalomon Remove could not invert matrix SkDebugfs
> 2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops.
> 2018-05-02 herb Remove android specific code
> 2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times.
> 2018-05-04 fmalita [skottie] Disable on Android Framework builds
> 2018-05-04 borenet [recipes] Remove core.setup()
> 2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1
> 2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)
> 2018-05-04 caryclark Revert "Reland "remove obsolete color defines""
> 2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer
> 
> Created with:
>   roll-dep src/third_party/skia
> BUG= chromium:836113 
> 
> 
> The AutoRoll server is located here: https://autoroll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=brianosman@chromium.org
> 
> Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec
> Reviewed-on: https://chromium-review.googlesource.com/1044782
> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#556184}

TBR=brianosman@google.com,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:836113 , chromium:840010 
Change-Id: Id9ab44b4ffe8b7bc3f3b267d2f27a732d97f5161
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1046286
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556381}
[modify] https://crrev.com/672cc57f93fb23198daf242d123fb4686f47dbe9/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, May 7 2018

Labels: merge-merged-3423
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ee938a5cf9359aadec8f88353b0d838b7c495b

commit b5ee938a5cf9359aadec8f88353b0d838b7c495b
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon May 07 15:43:27 2018

Revert "Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits)"

This reverts commit 2f276c3b1588be8db84e1a7f7a3b2617f63ea0e6.

Reason for revert: Caused text rendering regression in Windows.  crbug.com/840010 

Original change's description:
> Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits)
> 
> https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c
> 
> $ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s'
> 2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice
> 2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs.
> 2018-05-04 bungeman Allow finer rotation in Viewer app.
> 2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)"
> 2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag
> 2018-05-04 bsalomon Remove could not invert matrix SkDebugfs
> 2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops.
> 2018-05-02 herb Remove android specific code
> 2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times.
> 2018-05-04 fmalita [skottie] Disable on Android Framework builds
> 2018-05-04 borenet [recipes] Remove core.setup()
> 2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1
> 2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)
> 2018-05-04 caryclark Revert "Reland "remove obsolete color defines""
> 2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer
> 
> Created with:
>   roll-dep src/third_party/skia
> BUG= chromium:836113 
> 
> 
> The AutoRoll server is located here: https://autoroll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=brianosman@chromium.org
> 
> Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec
> Reviewed-on: https://chromium-review.googlesource.com/1044782
> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#556184}

TBR=brianosman@google.com,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:836113 , chromium:840010 
Change-Id: Id9ab44b4ffe8b7bc3f3b267d2f27a732d97f5161
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1046286
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556381}(cherry picked from commit 672cc57f93fb23198daf242d123fb4686f47dbe9)
Reviewed-on: https://chromium-review.googlesource.com/1047485
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Commit-Position: refs/branch-heads/3423@{#3}
Cr-Branched-From: 1ffee34835ac6f797de3d6e7f2160006059252c0-refs/heads/master@{#556364}
[modify] https://crrev.com/b5ee938a5cf9359aadec8f88353b0d838b7c495b/DEPS

*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Project Member

Comment 17 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba34164cc1ae8b5f6b1171634ba405f4a2d885fa

commit ba34164cc1ae8b5f6b1171634ba405f4a2d885fa
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon May 07 16:43:44 2018

Roll src/third_party/skia/ 05cfcff70..8a95244f6 (28 commits; 2 trivial rolls)

https://skia.googlesource.com/skia.git/+log/05cfcff70ced..8a95244f626c

$ git log 05cfcff70..8a95244f6 --date=short --no-merges --format='%ad %ae %s'
2018-05-07 egdaniel Revert "Avoid drawing BW clipped color glyphs many times."
2018-05-07 egdaniel Revert "Remove android specific code"
2018-05-06 egdaniel Revert "Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice"
2018-05-06 egdaniel Revert "Restore old SkBitmapDeviceFilteredSurfaceProps"
2018-05-04 liyuqian Restore old SkBitmapDeviceFilteredSurfaceProps
2018-05-04 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ e76163e3c..336cdd903 (1 commit)
2018-05-04 senorblanco Remove GR_TESSELLATOR_LEGACY_INVERSION_HANDLING (unused).
2018-05-04 halcanary SkSinglyLinkedList: use unique_ptr to manage ownership
2018-05-04 fmalita [skottie] Switch to RapidJSON
2018-05-04 fmalita Fuzz should observe the optional Skottie flag.
2018-05-04 herb Add missing header from core.gni
2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice
2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs.
2018-05-04 bungeman Allow finer rotation in Viewer app.
2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)"
2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag
2018-05-04 bsalomon Remove could not invert matrix SkDebugfs
2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops.
2018-05-02 herb Remove android specific code
2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times.
2018-05-04 fmalita [skottie] Disable on Android Framework builds
2018-05-04 borenet [recipes] Remove core.setup()
2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1
2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)
2018-05-04 caryclark Revert "Reland "remove obsolete color defines""
2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer

Created with:
  roll-dep src/third_party/skia
BUG= chromium:836113 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Ic6c1790f7f06de8205301449379701a24266cbff
Reviewed-on: https://chromium-review.googlesource.com/1047185
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556466}
[modify] https://crrev.com/ba34164cc1ae8b5f6b1171634ba405f4a2d885fa/DEPS

Labels: Merge-Approved-67
The fix (in #10) was reverted out of Chrome due to a different CL in the Skia DEPS roll. It is now back in.

It it sticks, it should be cherry-picked back to M67.
Labels: -Merge-Approved-67 Merge-Request-67
Let me try that again.
So is the M67 merge request is for CL listed at #10? 
How safe is the change to merge to M67? 
Also since this was regressed in M66 and M67 will be going to stable soon, how important it is to merge this change to M67?
Yes, the merge request is the for the CL in #10.

It is very safe to cherry-pick back to M67.

Wrt to the M66/M67 issue, I was never able to reproduce the bug in M66 but it does repro in M67 and ToT. So, it is pretty important to cherry-pick the fix back to M67.

To be clearer about what is going on:

https://skia-review.googlesource.com/c/skia/+/121331 (Don't try to readback from the GPU for small blur sigmas)) was cherry-picked back to M67 to fix one bug (brbug.com/832838) but it also revealed another bug.

That second bug (this one) is then fixed by: https://skia-review.googlesource.com/126020 (Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1)

Labels: -Merge-Request-67 Merge-Approved-67
Approving merge for CL listed at #10 to M67 branch 3396 based on comment #21. Please merge ASAP so we can pick it up for this week Beta release. Thank you.
NextAction: 2018-05-08
Pls merge tomorrow (05/08) morning if change listed at #10 continue to look in canary.
The NextAction date has arrived: 2018-05-08
Project Member

Comment 25 by bugdroid1@chromium.org, May 8 2018

Labels: merge-merged-m67
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/c097162d82fe7b13b349ed33bc17f1d2bafa7e82

commit c097162d82fe7b13b349ed33bc17f1d2bafa7e82
Author: Robert Phillips <robertphillips@google.com>
Date: Tue May 08 13:31:55 2018

[M67 cherry pick] Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1

No-Tree-Checks: true
No-Try: true
No-Presubmit: true
Bug:  836113 
Change-Id: I489af2fe5b45d4975a5c80a8a23947711618e648
Reviewed-on: https://skia-review.googlesource.com/126680
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

[modify] https://crrev.com/c097162d82fe7b13b349ed33bc17f1d2bafa7e82/src/gpu/effects/GrMatrixConvolutionEffect.cpp

Labels: -Merge-Approved-67
The fix for the issue found in M67 has been cherry-picked back to M67.

I still don't know what to do about the (original) reported issue in M66 that I haven't been able to repro.
Labels: TE-Verified-68.0.3424.0 TE-Verified-M68
Able to reproduce the issue on chrome reported version 66.0.3359.117 hence verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #68.0.3424.0 as per the comment#0
Attaching screen cast for reference.
Observed ""The element smoothly animated the background color and blur from their non-hover state to the hovered state.""
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
836113.mp4
495 KB View Download
Can this be marked as fixed if nothing else is pending?
Status: Fixed (was: Assigned)

Sign in to add a comment