New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836112 link

Starred by 2 users
Status: Fixed
Owner:
wzang@chromium.org
Closed: May 2018
Cc:
ajha@chromium.org
r...@chromium.org
█ brajkumar@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression: Wall paper change is seen after signing out

Project Member Reported by rkalavakuntla@chromium.org, Apr 24 2018 
Chrome Version:68.0.3404.0/10611.0.0 dev channel Daisy,Candy,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Set Wallpaper
(2)Sign out and observe the change in Wallpaper

Actual: Wallpaper change is seen after signing out
Expected: No such wallpaper change should be seen

This is a Regression issue as same is working fine in 68.0.3400.0/10598.0.0 dev 

Note : Issue is not seen in Linux, Windows OS

Attached the screencast for reference..

@wzang : Please confirm the issue.
Actual.mp4
11.4 MB View Download
Expected.mp4
7.6 MB View Download

Comment 1 by wzang@chromium.org, Apr 24 2018

Cc: jdufault@chromium.org wzang@chromium.org
Components: -UI>SignIn -UI>Shell>Wallpaper UI>Shell>StartScreen
Owner: ----
Status: Available (was: Assigned)
Maybe it's because ShowUserWallpaper is not called for the focused pod?

Comment 2 by jdufault@chromium.org, Apr 24 2018

Cc: r...@chromium.org
Labels: ReleaseBlock-Beta
Owner: jdufault@chromium.org

Comment 3 by r...@chromium.org, May 3 2018

Owner: wzang@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f969cabb63e489cc976e50c8ca33258519949e0b

commit f969cabb63e489cc976e50c8ca33258519949e0b
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri May 04 05:07:13 2018

cros: Request wallpaper for focused pod on views login

1) The focused pod on views login should request wallpaper, the same
   with web-ui login.

2) Views-based login calls |ShowGaiaScreenIfReady| to pre-load Gaia,
   before Gaia page is actually open, which results in the bug. We
   should move the wallpaper-related code to
   |UpdateGaiaDialogVisibility| which controls the actual visibility
   of Gaia page on views-login.

Bug:  836112 
Change-Id: Ide91ba2e7379b23bae94b40be022bfaa7da3c360
Reviewed-on: https://chromium-review.googlesource.com/1043264
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555991}
[modify] https://crrev.com/f969cabb63e489cc976e50c8ca33258519949e0b/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/f969cabb63e489cc976e50c8ca33258519949e0b/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/f969cabb63e489cc976e50c8ca33258519949e0b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Comment 5 by wzang@chromium.org, May 4 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment