New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Turn off floating keyboard flag on M-67.

Project Member Reported by yhanada@chromium.org, Apr 24 2018

Issue description

I turned on the floating keyboard flag by default for testing in crrev.com/c/954804.
Now M-67 is branching and the feature is not ready for stable release. Let's turn it off for M-67 branch.

Launch bug for the feature is crbug.com/771466
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01873a4e706364c83db6c88ec0443d88e848f230

commit 01873a4e706364c83db6c88ec0443d88e848f230
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Wed Apr 25 00:41:27 2018

Disable enable-floating-virtual-keyboard flag by default.

This feature is not ready for M-67 stable.
This CL will be reverted shortly after merging it to M-67 branch.

Bug: 771466,  836109 
Test: Manual testing on the device. Confirmed that the feature is disabled by default.
Change-Id: I295319b4bdd6ae2cec18b5690308df96cff669dd
Reviewed-on: https://chromium-review.googlesource.com/1025352
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553395}
[modify] https://crrev.com/01873a4e706364c83db6c88ec0443d88e848f230/ui/base/ui_base_features.cc

Labels: Merge-Request-67
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 26 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba1dfc9a90ed5c267e2861692a6ae4dd49cdbd5

commit cba1dfc9a90ed5c267e2861692a6ae4dd49cdbd5
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Apr 26 06:46:17 2018

Disable enable-floating-virtual-keyboard flag by default.

This feature is not ready for M-67 stable.
This CL will be reverted shortly after merging it to M-67 branch.

Bug: 771466,  836109 
Test: Manual testing on the device. Confirmed that the feature is disabled by default.
Change-Id: I295319b4bdd6ae2cec18b5690308df96cff669dd
Reviewed-on: https://chromium-review.googlesource.com/1025352
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553395}(cherry picked from commit 01873a4e706364c83db6c88ec0443d88e848f230)
Reviewed-on: https://chromium-review.googlesource.com/1029691
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#320}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/cba1dfc9a90ed5c267e2861692a6ae4dd49cdbd5/ui/base/ui_base_features.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e3fce612f9f179806b8856dab624d27543a2429

commit 2e3fce612f9f179806b8856dab624d27543a2429
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Apr 26 08:52:04 2018

Revert "Disable enable-floating-virtual-keyboard flag by default."

This reverts commit 01873a4e706364c83db6c88ec0443d88e848f230.

Reason for revert: This CL was cherry-picked to M-67 release branch. Let's revert this on master.

Original change's description:
> Disable enable-floating-virtual-keyboard flag by default.
> 
> This feature is not ready for M-67 stable.
> This CL will be reverted shortly after merging it to M-67 branch.
> 
> Bug: 771466,  836109 
> Test: Manual testing on the device. Confirmed that the feature is disabled by default.
> Change-Id: I295319b4bdd6ae2cec18b5690308df96cff669dd
> Reviewed-on: https://chromium-review.googlesource.com/1025352
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553395}

TBR=sadrul@chromium.org,yhanada@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 771466,  836109 
Change-Id: Ia0b300bd06d6ed0e25d8cb15dfe48013e611b592
Reviewed-on: https://chromium-review.googlesource.com/1029810
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553957}
[modify] https://crrev.com/2e3fce612f9f179806b8856dab624d27543a2429/ui/base/ui_base_features.cc

Status: Fixed (was: Started)

Sign in to add a comment