New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 836105 link

Starred by 2 users
Status: Verified
Owner: ----
Closed: Jun 2018
Cc:
█ sandeepkumars@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Overflow menu should not focus first element on mobile

Project Member Reported by fbeaufort@chromium.org, Apr 24 2018 
Chrome Version: Chrome Canary 68.0.3404.0
OS: Android 8.1.0; Pixel 2

What steps will reproduce the problem?
1. Enable New Media Controls flag at chrome://flags/#enable-modern-media-controls
2. Go to https://storage.googleapis.com/fbeaufort-test/sample-video.webm
3. Tap the three vertical dots icon to open overflow menu

What is the expected result?
The overflow menu should open and that's all

What happens instead?
"Cast" icon is grey and has orange border. It is focused basically ;(

This creates a weird first-state in my opinion. See screenshot attached
Screenshot (Apr 24, 2018 7_36_53 AM).png
581 KB View Download

Comment 1 by sandeepkumars@chromium.org, Apr 26 2018

Labels: Needs-triage-Mobile Triaged-Mobile Needs-Feedback
Tested the issue using #68.0.3404.0 on Android 8.1.0; Pixel 2 and could not reproduce the issue as per the steps mentioned below.

Steps:
1. Launched Browser
2. Enabled chrome://flags/#enable-modern-media-controls
3. Navigated to https://storage.googleapis.com/fbeaufort-test/sample-video.webm
4. Tapped on Customize and control Google Chrome menu
5. No such behavior is observed

@fbeaufort: Could you please find the above observations and let us know if we missed anything from our end?

Thanks!!

Comment 2 by fbeaufort@chromium.org, Apr 26 2018 

The three vertical dots icon to open overflow menu are part of the video not the main one to control Google Chrome menu.
Screenshot 2018-04-26 at 2.02.29 PM.png
41.7 KB View Download

Comment 3 by sandeepkumars@chromium.org, Apr 27 2018

Cc: sandeepkumars@chromium.org
Just to update

Clicked on 3 dot menu icon on the video and did not observe the cast icon over there.

@fbeaufort: Could you please let us know what to do to get the cast icon on menu? If possible attach a screencast as well for further triaging.

Thnks!!
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbc6a3d7bce0720f07ced7142a285adf162fda95

commit fbc6a3d7bce0720f07ced7142a285adf162fda95
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Wed May 30 15:23:54 2018

[Media Controls] Remove outline in focused overflow menu items.

As we already provide a focus style (changing the background color of
the focused item), this CL remove outline (blue ring) in modern media
controls.

Bug:  836105 
Change-Id: I84f74a2e6dce8f997108ef32a57541b455b79287
Reviewed-on: https://chromium-review.googlesource.com/1078307
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#562833}
[modify] https://crrev.com/fbc6a3d7bce0720f07ced7142a285adf162fda95/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Comment 5 by fbeaufort@chromium.org, Jun 1 2018

Status: Verified (was: Untriaged)
Verified in 69.0.3446.0.
►

Sign in to add a comment