New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836101 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

veyron_rialto should be excluded from audio tests

Project Member Reported by louiscollard@chromium.org, Apr 24 2018

Issue description

This device does not have a sound card, so should be excluded from audio autotests.
 
Cc: cychiang@chromium.org
Components: OS>Kernel>Audio
Owner: paulhsia@chromium.org
Status: Assigned (was: Untriaged)
Paul. Can you help with this?
Cc: ka...@chromium.org
Hi Kalin, do you know how to change the schedule of the tests ?
If we can remove veyron_rialto from testing, it will be much easier than adding "if board == veyron_rialto" in every test.

Thanks!

Comment 3 by ka...@chromium.org, May 3 2018

I guess we are talking about suite:audio, right?
If so, veyron_rialto should not be running these tests, as it is not part of the boards list at https://cs.corp.google.com/chromeos_public/infra/suite_scheduler/configs/suite_scheduler.ini?l=376

If not - it should be done either with a DEPENDENCY at test level(which also ) or pragmatically within the test(or a util) recognizing there is no sound card and just return.

Combined method will be to add an auto-label at host creation, and have a suite dependency either at the suite control athttps://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/test_suites/control.audio (or in scheduler) to run against devices labeled this way.
An idea - is audio_loopback_dongle such label, so it can be used? (I doubt rialto boards have dongles plugged)




Hi Kalin,
Do you know who on infra team can help checking why suite_scheduler does not do what is expected ?
If veyron_rialto is not on the list, it should not be scheduled.
Other methods seems not ideal to solve this problem.

Thanks!

Comment 5 by ka...@chromium.org, May 4 2018

Cc: cra...@chromium.org xixuan@chromium.org akes...@chromium.org
Components: Infra>Client>ChromeOS>Test
Labels: OS-Chrome
Adding few Infra folks to clarify.
+akeshet,craigb,xixuan

Problem: Device like veyron_rialto is running suite 'audio' tests despite it is not part of boards spec in the scheduler record for that suite at https://cs.corp.google.com/chromeos_public/infra/suite_scheduler/configs/suite_scheduler.ini?l=376.
I don't think veyron_rialto is running suite:audio. Suite scheduler logs of today's 4am are pasted here:


2018-05-04 04:09:08.847 PDT
Running audio on veyron_rialto-release/R67-10575.27.0 (/base/data/home/apps/s~google.com:suite-scheduler/20180320t145344.408446791459104174/task.py:408)
2018-05-04 04:09:08.847 PDT
Board veyron_rialto is not in supported board list: ['asuka', 'paine', 'banon', 'butterfly', 'cave', 'daisy', 'elm', 'kevin', 'lumpy', 'mccloud', 'nyan_big', 'parrot', 'peach_pit', 'peppy', 'rikku', 'samus', 'snappy', 'squawks', 'stout', 'veyron_jerry'] (/base/data/home/apps/s~google.com:suite-scheduler/20180320t145344.408446791459104174/task.py:411)

...


2018-05-04 04:09:08.918 PDT
Running audio on veyron_rialto-release/R68-10645.0.0 (/base/data/home/apps/s~google.com:suite-scheduler/20180320t145344.408446791459104174/task.py:408)
2018-05-04 04:09:08.918 PDT
Board veyron_rialto is not in supported board list: ['asuka', 'paine', 'banon', 'butterfly', 'cave', 'daisy', 'elm', 'kevin', 'lumpy', 'mccloud', 'nyan_big', 'parrot', 'peach_pit', 'peppy', 'rikku', 'samus', 'snappy', 'squawks', 'stout', 'veyron_jerry'] (/base/data/home/apps/s~google.com:suite-scheduler/20180320t145344.408446791459104174/task.py:411)

...

2018-05-04 04:09:08.931 PDT
Running audio on veyron_rialto-release/R66-10452.85.0 (/base/data/home/apps/s~google.com:suite-scheduler/20180320t145344.408446791459104174/task.py:408)
2018-05-04 04:09:08.932 PDT
Board veyron_rialto is not in supported board list: ['asuka', 'paine', 'banon', 'butterfly', 'cave', 'daisy', 'elm', 'kevin', 'lumpy', 'mccloud', 'nyan_big', 'parrot', 'peach_pit', 'peppy', 'rikku', 'samus', 'snappy', 'squawks', 'stout', 'veyron_jerry'] (/base/data/home/apps/s~google.com:suite-scheduler/20180320t145344.408446791459104174/task.py:411)

...
Xixuan, thank you for the help!

The suite is actually kernel_per-build_regression.

https://stainless.corp.google.com/search?view=matrix&row=board&col=build&first_date=2018-04-28&last_date=2018-05-04&test=audio&board=veyron_rialto&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false


Hi Paul,
I think we can add a helper function in audio_spec.py so audio_Aplay test can early return for board without any audio.
Thanks!


Re #8, if you want to whitelist some boards to run kernel_per-build_regression, you can modify https://cs.corp.google.com/chromeos_public/infra/suite_scheduler/configs/suite_scheduler.ini, to add:

boards: elm, kevin, bob, peach_pi, nyan_blaze,...  

in entry [KernelRegressionPerBuild], and don't put veyron_rialto in this board list.


It would be a nice feature to have - a filter to exclude specific boards (e.g. 'avoid_boards: '). It will be more usable than 'boards:'. xixuan@ do you think it is feasible to request?
Re #10, it's a pretty easy feature to add in implementation :) So if it really helps suite-scheduler's users, I'd like to welcome this entry.

@craigb, you want to give it a try or have other opinions of this idea?
xixuan, I'm hoping to spend some time on designing Torch and understanding Monitoring this week.  Can you find somewhere else for this one to land?

Re #12, sure, I can add this feature if required. @kalin, any deadline for this feature or will you frequently use this?

Sign in to add a comment