New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836100 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 820295

Blocking:
issue 782499
issue 836095
issue 836098


Participants' hotlists:
ML-Service


Sign in to add a comment

ML Service: Build TensorFlow Lite and its dependencies with Bazel

Project Member Reported by amoylan@chromium.org, Apr 24 2018

Issue description

Once the blocking issue (Bazel in toolchain) is complete we can work towards building TensorFlow and its dependencies that way.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/327546c2395fdccd24f3c3fc157c09eceaf077d3

commit 327546c2395fdccd24f3c3fc157c09eceaf077d3
Author: Michael Martis <martis@chromium.org>
Date: Wed Jun 13 16:19:33 2018

chromeos-base/tensorflow: Remove Chrome-OS-specific package

We are in the process of migrating to the existing upstream
TensorFlow package:
https://packages.gentoo.org/packages/sci-libs/tensorflow

BUG= chromium:836100 
TEST=None (package not yet used)

Change-Id: I1d8d246be71224dd193c2f5c15253c2578839dba
Reviewed-on: https://chromium-review.googlesource.com/1077108
Commit-Ready: Michael Martis <martis@chromium.org>
Tested-by: Michael Martis <martis@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>

[delete] https://crrev.com/d7a807d61971143a1519ddaf7bce3a42fc0e84af/chromeos-base/tensorflow/tensorflow-1.5.0.ebuild
[delete] https://crrev.com/d7a807d61971143a1519ddaf7bce3a42fc0e84af/chromeos-base/tensorflow/files/tensorflow-1.5.0-nsync-makefile-clang.patch
[delete] https://crrev.com/d7a807d61971143a1519ddaf7bce3a42fc0e84af/chromeos-base/tensorflow/Manifest
[delete] https://crrev.com/d7a807d61971143a1519ddaf7bce3a42fc0e84af/chromeos-base/tensorflow/files/tensorflow-1.5.0-tf-makefile-clang.patch
[delete] https://crrev.com/d7a807d61971143a1519ddaf7bce3a42fc0e84af/chromeos-base/tensorflow/tensorflow-1.5.0-r2.ebuild
[delete] https://crrev.com/d7a807d61971143a1519ddaf7bce3a42fc0e84af/chromeos-base/tensorflow/files/tensorflow-1.5.0-tf-lite-protos.patch

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4e11ac7df254c22d523cb3de43490a412f706e10

commit 4e11ac7df254c22d523cb3de43490a412f706e10
Author: Michael Martis <martis@chromium.org>
Date: Tue Jun 26 19:52:04 2018

sci-libs/tensorflow: pull 1.9.0_rc1 ebuild from upstream.

Pick the ebuild from Gentoo portage as of commit 782f1c18ce7a21f9d78097e48d7ff12d4c17e62a.

Only minor modifications:
  - Updated KEYWORD to allow for all architectures.
  - Removed some DEPENDS (that were only notional, since Bazel
    currently handles all dependencies monolithically).
  - Removed the empty PATCHES set (which was causing errors
    for me locally).
  - Added two compile flags that allow building with Clang.

BUG= chromium:836100 
TEST=sudo emerge tensorflow
CQ-DEPEND=CL:1107018

Change-Id: Ib5ee6aca8812c056e159d314331cd97ee6705160
Reviewed-on: https://chromium-review.googlesource.com/1107021
Commit-Ready: Michael Martis <martis@chromium.org>
Tested-by: Michael Martis <martis@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>

[add] https://crrev.com/4e11ac7df254c22d523cb3de43490a412f706e10/sci-libs/tensorflow/Manifest
[add] https://crrev.com/4e11ac7df254c22d523cb3de43490a412f706e10/sci-libs/tensorflow/tensorflow-1.9.0_rc1.ebuild

Summary: ML Service: Build TensorFlow Lite and its dependencies with Bazel (was: ML Service: Build TensorFlow and its dependencies with Bazel)
Per discussions: TensorFlow Lite rather than TensorFlow is now the first thing to target build-wise.
Cc: napper@chromium.org claudiomagni@chromium.org martis@chromium.org amoylan@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/86690e62ffdae2e28dfd245857669d0ba2801dd9

commit 86690e62ffdae2e28dfd245857669d0ba2801dd9
Author: Michael Martis <martis@chromium.org>
Date: Tue Jul 17 09:26:26 2018

sci-libs/tensorflow: fixed cross-compilation.

- Separated compiler flags into build ("host") and board flags.
- Added generation of CROSSTOOL targets using Portage build
  variables.

BUG= chromium:836100 
TEST=`USE="-python" emerge-chell tensorflow`

Change-Id: I5309303e45fbc5813b0c36b119dea17d67c145a1
Reviewed-on: https://chromium-review.googlesource.com/1113712
Commit-Ready: Michael Martis <martis@chromium.org>
Tested-by: Michael Martis <martis@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/86690e62ffdae2e28dfd245857669d0ba2801dd9/sci-libs/tensorflow/tensorflow-1.9.0_rc1.ebuild
[add] https://crrev.com/86690e62ffdae2e28dfd245857669d0ba2801dd9/sci-libs/tensorflow/files/tensorflow-1.9.0_rc1-CROSSTOOL.tpl
[add] https://crrev.com/86690e62ffdae2e28dfd245857669d0ba2801dd9/sci-libs/tensorflow/files/tensorflow-1.9.0_rc1-BUILD.tpl
[add] https://crrev.com/86690e62ffdae2e28dfd245857669d0ba2801dd9/sci-libs/tensorflow/tensorflow-1.9.0_rc1-r1.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c31f5e880c696484583241347ac6a168a9cb7541

commit c31f5e880c696484583241347ac6a168a9cb7541
Author: Michael Martis <martis@chromium.org>
Date: Wed Jul 18 11:08:08 2018

sci-libs/tensorflow: added a TF lite target.

TF lite is a much smaller-footprint variant of TensorFlow. Using
this variant will save on disk space and reduce the number of
dependencies we need to support.

TF lite is now always built as part of this package. Builds that
disable the "minimal" use-flag will also build full TensorFlow.

BUG= chromium:836100 
TEST=`USE="minimal" emerge-chell tensorflow`

Change-Id: I811c017930a4047810ffdc0ecda6a19cdded2be1
Reviewed-on: https://chromium-review.googlesource.com/1132273
Commit-Ready: Michael Martis <martis@chromium.org>
Tested-by: Michael Martis <martis@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>

[rename] https://crrev.com/c31f5e880c696484583241347ac6a168a9cb7541/sci-libs/tensorflow/tensorflow-1.9.0_rc1-r2.ebuild
[modify] https://crrev.com/c31f5e880c696484583241347ac6a168a9cb7541/sci-libs/tensorflow/tensorflow-1.9.0_rc1.ebuild
[add] https://crrev.com/c31f5e880c696484583241347ac6a168a9cb7541/sci-libs/tensorflow/files/tensorflow-1.9.0_rc1-lite-lib.patch
[modify] https://crrev.com/c31f5e880c696484583241347ac6a168a9cb7541/sci-libs/tensorflow/metadata.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1d221ecd488ed1c6716534afe2f6864927bc79d4

commit 1d221ecd488ed1c6716534afe2f6864927bc79d4
Author: Michael Martis <martis@chromium.org>
Date: Wed Aug 01 07:05:40 2018

sci-libs/tensorflow: reduced TF lite library size.

Reduced the size of the TF lite shared library by hiding symbols
we don't want to export.

BUG= 836100 
TEST=`USE="minimal" emerge-chell tensorflow`

Change-Id: I1c2a6f4aabc33797cf6a7cfe8bb8ca10b930799d
Reviewed-on: https://chromium-review.googlesource.com/1155269
Commit-Ready: Michael Martis <martis@chromium.org>
Tested-by: Michael Martis <martis@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>

[modify] https://crrev.com/1d221ecd488ed1c6716534afe2f6864927bc79d4/sci-libs/tensorflow/files/tensorflow-1.9.0_rc1-lite-lib.patch

Status: Fixed (was: Started)

Sign in to add a comment