Page info misaligned with hosted app menu button |
||
Issue descriptionChrome Version: 68 OS: chromeOS What steps will reproduce the problem? (1) Open hosted app page info dialog from hosted app menu. What is the expected result? Page info dialog should be aligned with the menu icon. What happens instead? The dialog is slightly to the right of the icon. See screenshots.
,
Apr 24 2018
Screenshots of view rects affected by WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1025592
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed2ae4a3e2943d902359c976b7fa1e94921a4238 commit ed2ae4a3e2943d902359c976b7fa1e94921a4238 Author: Alan Cutter <alancutter@chromium.org> Date: Tue Apr 24 21:38:10 2018 Fix hosted app menu button anchor point misalignment This CL fixes the misalignment of the hosted app menu button anchor point by updating its view bounds. Overriding CalculatePreferredSize() didn't update the behaviour of GetHeightForWidth() which caused it to be cropped by the container's BoxLayout. LabelButton::SetMinSize() exists and should be used instead. Before rects: https://bugs.chromium.org/p/chromium/issues/attachment?aid=335982&signed_aid=hz80AUGwixvyOI7d2jCIYQ==&inline=1 After rects: https://bugs.chromium.org/p/chromium/issues/attachment?aid=335983&signed_aid=9NLhUbDPYjh_YRMnsVABAw==&inline=1 Bug: 836099 Change-Id: I77ad668816df936bbb3129aa1253330382fe22c5 Reviewed-on: https://chromium-review.googlesource.com/1025592 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#553290} [modify] https://crrev.com/ed2ae4a3e2943d902359c976b7fa1e94921a4238/chrome/browser/ui/views/frame/hosted_app_menu_button.cc [modify] https://crrev.com/ed2ae4a3e2943d902359c976b7fa1e94921a4238/chrome/browser/ui/views/frame/hosted_app_menu_button.h
,
Apr 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by alancutter@chromium.org
, Apr 24 2018