ML Service: Implement model-loading part of Mojo service |
||||||||
Issue descriptionWhen a client of ML Service calls ModelProvider.LoadModel, we need to load the requested model (if possible), and return an instance of Model.
,
Apr 24 2018
,
Apr 24 2018
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0afc85c023029cbe3e08c329ce0e6705bc91d963 commit 0afc85c023029cbe3e08c329ce0e6705bc91d963 Author: Claudio M <claudiomagni@chromium.org> Date: Tue Jul 10 12:16:36 2018 chromeos-base/ml: Ebuild changes to install models for ML Service. We install both TFNative and TFLite models into rootfs. This is the first way to use models in ML Service that we are implementing. As this method does increase the storage in rootfs it will be used to service-critical models only. For now we want to test our first model (Tab Discarder). For more info, see go/cros-ml-service-models. BUG= chromium:836095 TEST=emerge chromeos-base/ml Change-Id: Ie0f6c86cab61de656916b3ad41e94f3306b2bdea Reviewed-on: https://chromium-review.googlesource.com/1125701 Commit-Ready: Claudio M <claudiomagni@chromium.org> Tested-by: Claudio M <claudiomagni@chromium.org> Reviewed-by: Tomasz Figa <tfiga@chromium.org> [modify] https://crrev.com/0afc85c023029cbe3e08c329ce0e6705bc91d963/chromeos-base/ml/ml-9999.ebuild
,
Jul 11
The above revision fixed crbug.com/836104 and (partially) unlocks this bug (some other blockers remain).
,
Jul 16
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/95379864d2953534abd4b10aed4d5629e07bcff0 commit 95379864d2953534abd4b10aed4d5629e07bcff0 Author: Claudio M <claudiomagni@chromium.org> Date: Wed Jul 18 08:40:10 2018 chromeos-base/ml: Small fix to ebuild of ML Service. I change http/https URI to gs://. BUG= chromium:836095 TEST=emerge chromeos-base/ml Change-Id: I158f6e86ed9b314e0a5ca072cc245028662c69ca Reviewed-on: https://chromium-review.googlesource.com/1140020 Commit-Ready: Claudio M <claudiomagni@chromium.org> Tested-by: Claudio M <claudiomagni@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/95379864d2953534abd4b10aed4d5629e07bcff0/chromeos-base/ml/ml-9999.ebuild
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/73f998485ed855a4d025144a007133690c70d779 commit 73f998485ed855a4d025144a007133690c70d779 Author: Claudio M <claudiomagni@chromium.org> Date: Mon Jul 23 09:17:35 2018 chromeos-base/ml: Add the manifest for remote files in ebuild I did not include the generated manifest file when I submitted the ebuild initially. See crrev.com/c/1125701. BUG= chromium:836095 TEST=emerge chromeos-base/ml Change-Id: Id9c7f4b2bae1ab078370588a0e9e6db26a8e812d Reviewed-on: https://chromium-review.googlesource.com/1142855 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Commit-Ready: Claudio M <claudiomagni@chromium.org> Tested-by: Claudio M <claudiomagni@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/73f998485ed855a4d025144a007133690c70d779/chromeos-base/ml/Manifest
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f34267057db0ff0589052f5a5d790bcd43b356cb commit f34267057db0ff0589052f5a5d790bcd43b356cb Author: Andrew Moylan <amoylan@chromium.org> Date: Fri Aug 03 01:11:29 2018 Remove ModelProvider Mojo interface We are collapsing the ModelProvider interface into the top-level MachineLearningService interface. ModelProvider's sole method LoadModel becomes a method of MachineLearningService. This reflects the corresponding Chromium OS change: crrev.com/c/1158091. (The changes are safe to perform simultaneously as no clients call this interface yet.) Bug: 836095 Change-Id: Ia30be3ff176a72f2873c589ad1bc8e5c53248031 Reviewed-on: https://chromium-review.googlesource.com/1160138 Reviewed-by: Michael Martis <martis@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580401} [modify] https://crrev.com/f34267057db0ff0589052f5a5d790bcd43b356cb/chromeos/services/machine_learning/public/cpp/service_connection.cc [modify] https://crrev.com/f34267057db0ff0589052f5a5d790bcd43b356cb/chromeos/services/machine_learning/public/cpp/service_connection.h [modify] https://crrev.com/f34267057db0ff0589052f5a5d790bcd43b356cb/chromeos/services/machine_learning/public/cpp/service_connection_unittest.cc [modify] https://crrev.com/f34267057db0ff0589052f5a5d790bcd43b356cb/chromeos/services/machine_learning/public/mojom/machine_learning_service.mojom
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e465a592ac6bfba5ffdd3907dc7146781fbcb245 commit e465a592ac6bfba5ffdd3907dc7146781fbcb245 Author: Andrew Moylan <amoylan@chromium.org> Date: Fri Aug 03 08:31:25 2018 ml: Remove ModelProvider Mojo interface We will collapse the ModelProvider interface into the top-level MachineLearningService interface. ModelProvider's sole method, LoadModel, becomes a method of MachineLearningService. The corresponding Chromium CL will be crrev.com/c/1160138. (The changes are safe to do simultaneously as no clients call this interface yet.) BUG= chromium:836095 TEST=push to test device Change-Id: Ic9ebeefce6c36ce6027c8ed2a347fa23194a7701 Reviewed-on: https://chromium-review.googlesource.com/1158091 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> [modify] https://crrev.com/e465a592ac6bfba5ffdd3907dc7146781fbcb245/ml/mojom/machine_learning_service.mojom [modify] https://crrev.com/e465a592ac6bfba5ffdd3907dc7146781fbcb245/ml/machine_learning_service_impl.h [modify] https://crrev.com/e465a592ac6bfba5ffdd3907dc7146781fbcb245/ml/machine_learning_service_impl.cc
,
Aug 10
,
Aug 13
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4a3db9882b7122423ccbe9f08b1d31860bd0237f commit 4a3db9882b7122423ccbe9f08b1d31860bd0237f Author: Michael Martis <martis@chromium.org> Date: Mon Sep 10 11:30:06 2018 chromeos-base/ml: support new logic and tests. The ML service codebase has been updated to include TF lite model loading and inference; this change builds and tests these updates. In particular, the following modifications are made: 1) A runtime dependency on TensorFlow is added, 2) The ML service test binary is executed in the testing phase, 3) Models are separated into "system" (i.e. rootfs) and "testing" categories, which lets us perform integration-style tests without polluting non-test system images. CQ-DEPEND=CL:1172236 BUG= chromium:836095 TEST=`emerge-chell ml` Change-Id: If4a5bc709dcf7a1e49f44547c437a9dc4b8fe14b Reviewed-on: https://chromium-review.googlesource.com/1201650 Commit-Ready: Michael Martis <martis@chromium.org> Tested-by: Michael Martis <martis@chromium.org> Reviewed-by: Tomasz Figa <tfiga@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/4a3db9882b7122423ccbe9f08b1d31860bd0237f/chromeos-base/ml/ml-9999.ebuild
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474 commit c2d2edaea821b30db18bb2ffff2a2b79ae1b9474 Author: Andrew Moylan <amoylan@chromium.org> Date: Fri Sep 14 02:53:57 2018 Update ML Service mojoms to match latest API in Chrome OS This syncs Chrome's version of the ML Service Mojo interface with Chrome OS's version in src/platform2/ml/mojom. The incorporated mojom changes introduce error/status responses from most of the mojom methods. No clients depend on this yet so the only required C++ change is an update to the LoadModel helper in the client library. Bug: 836095 Change-Id: I15a7ba831792290c7b68db889332efd356163d28 Reviewed-on: https://chromium-review.googlesource.com/1226650 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#591274} [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/cpp/service_connection.cc [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/cpp/service_connection.h [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/cpp/service_connection_unittest.cc [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/mojom/graph_executor.mojom [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/mojom/machine_learning_service.mojom [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/mojom/model.mojom [modify] https://crrev.com/c2d2edaea821b30db18bb2ffff2a2b79ae1b9474/chromeos/services/machine_learning/public/mojom/tensor.mojom
,
Sep 14
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by amoylan@chromium.org
, Apr 24 2018