chromeOS app list DCHECK when scrolling |
||||
Issue descriptionChrome Version: 68.0.3404.0 OS: chromeOS What steps will reproduce the problem? (1) Build chromeOS with assertions enabled. (2) Open app list. (3) Scroll twice (or more) What is the expected result? Scrolls to the end and stops. What happens instead? Scrolls to the end and crashes. [205955:205955:0424/150334.637245:FATAL:app_list_view.cc(1303)] Check failed: is_ignoring_scroll_events_ != is_ignoring (0 vs. 0) #0 0x7f1a4633b55c base::debug::StackTrace::StackTrace() #1 0x7f1a4628303b logging::LogMessage::~LogMessage() #2 0x7f1a3f838cb5 app_list::AppListView::SetIsIgnoringScrollEvents() #3 0x7f1a3f8445e7 app_list::AppsGridView::TransitionEnded() #4 0x7f1a3f82d20e app_list::PaginationModel::NotifyTransitionEnded() #5 0x7f1a3f82d308 app_list::PaginationModel::AnimationEnded() #6 0x7f1a4662a453 gfx::Animation::Stop() #7 0x7f1a4662be26 gfx::LinearAnimation::Step() #8 0x7f1a4662b38c gfx::AnimationContainer::Run() #9 0x7f1a46304ae6 base::Timer::RunScheduledTask() #10 0x7f1a462654a5 base::debug::TaskAnnotator::RunTask() #11 0x7f1a4628f429 base::internal::IncomingTaskQueue::RunTask() #12 0x7f1a4629291b base::MessageLoop::RunTask() #13 0x7f1a46292caa base::MessageLoop::DeferOrRunPendingTask() #14 0x7f1a462931f5 base::MessageLoop::DoDelayedWork() #15 0x7f1a4635058d base::MessagePumpLibevent::Run() #16 0x7f1a46292304 base::MessageLoop::Run() #17 0x7f1a462c4ab9 base::RunLoop::Run() #18 0x55c301ef0b77 ChromeBrowserMainParts::MainMessageLoopRun() #19 0x7f1a434706d7 content::BrowserMainLoop::RunMainMessageLoopParts() #20 0x7f1a434734f6 content::BrowserMainRunnerImpl::Run() #21 0x7f1a4346cb29 content::BrowserMain() #22 0x7f1a43e4aead content::ContentMainRunnerImpl::Run() #23 0x7f1a467ac292 service_manager::Main() #24 0x7f1a43e48b24 content::ContentMain() #25 0x55c301389723 ChromeMain #26 0x7f1a38c0f2b1 __libc_start_main #27 0x55c30138959a _start
,
Apr 24 2018
Does it exist in M67?
,
Apr 26 2018
Goes back to 66.
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a22fadf7e3ad386b0fcfb772f77a50efb27d5ba commit 0a22fadf7e3ad386b0fcfb772f77a50efb27d5ba Author: Weidong Guo <weidongg@chromium.org> Date: Fri Apr 27 19:11:21 2018 Fix dcheck failure for scrolling in app list Background: The dcheck in AppListView::SetIsIgnoringScrollEvents fails when user scroll up and down quickly. (The pagination transition starts again before ends). Changes: Do not make decision based on |is_ignoring_scroll_events_| which is set by state change animation or pagination transition. Instead, check the animator and pagination model directly to decide whether to ignore scroll events. BUG= 836088 Change-Id: Ic7aef13e53d299af3165082d7dfa2f89974e20c0 Reviewed-on: https://chromium-review.googlesource.com/1031207 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554438} [modify] https://crrev.com/0a22fadf7e3ad386b0fcfb772f77a50efb27d5ba/ui/app_list/views/app_list_view.cc [modify] https://crrev.com/0a22fadf7e3ad386b0fcfb772f77a50efb27d5ba/ui/app_list/views/app_list_view.h [modify] https://crrev.com/0a22fadf7e3ad386b0fcfb772f77a50efb27d5ba/ui/app_list/views/apps_grid_view.cc
,
Apr 28 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by alancutter@chromium.org
, Apr 24 2018