New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836076 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

root surface should be snapped to the physical pixel

Project Member Reported by osh...@chromium.org, Apr 24 2018

Issue description

Looks like it's not aligned and can become blurry with
fractional scale factor. I have a fix and will send out soon.



 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9225426bdc23969573e2b9f3ed7443865ef47539

commit 9225426bdc23969573e2b9f3ed7443865ef47539
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Apr 24 15:21:49 2018

Snap root surface to physical pixel

The root surface needs to be snapped if the shell surface uses chrome side caption.

This CL also removes "!allow_set_bounds_direct" check when
snapping the window in WindowState. This should have been removed
when we switched to relative surface hierarchy.

Bug:  836076 
Test: manually tested with fractional scale factor.

Change-Id: Iadc06572279dec42f8d792424cee76481a94fd55
Reviewed-on: https://chromium-review.googlesource.com/1025371
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553124}
[modify] https://crrev.com/9225426bdc23969573e2b9f3ed7443865ef47539/ash/wm/window_state.cc
[modify] https://crrev.com/9225426bdc23969573e2b9f3ed7443865ef47539/components/exo/shell_surface_base.cc

Comment 2 by osh...@chromium.org, Apr 24 2018

Labels: Merge-Rejected-67
Labels: -Merge-Rejected-67 Merge-Request-67
Did you mean merge requested?

Comment 4 by osh...@chromium.org, Apr 24 2018

yes, thanks.

Comment 5 by gov...@chromium.org, Apr 24 2018

Labels: OS-Chrome
Hi, is this a M67 regression / bug-fix?  Also, has the fix been tested against some number of boards?

Comment 7 by osh...@chromium.org, Apr 25 2018

This was probably regressed in 65 time frame. I didn't request for 66 because it's too late. I tested on caroline as well.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by osh...@chromium.org, Apr 25 2018

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17a78d01b1bf534791759caf259f8abffb4d0725

commit 17a78d01b1bf534791759caf259f8abffb4d0725
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Apr 25 16:34:23 2018

Snap root surface to physical pixel

The root surface needs to be snapped if the shell surface uses chrome side caption.

This CL also removes "!allow_set_bounds_direct" check when
snapping the window in WindowState. This should have been removed
when we switched to relative surface hierarchy.

Bug:  836076 
Test: manually tested with fractional scale factor.

Change-Id: Iadc06572279dec42f8d792424cee76481a94fd55
Reviewed-on: https://chromium-review.googlesource.com/1025371
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553124}(cherry picked from commit 9225426bdc23969573e2b9f3ed7443865ef47539)
Reviewed-on: https://chromium-review.googlesource.com/1028372
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#295}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/17a78d01b1bf534791759caf259f8abffb4d0725/ash/wm/window_state.cc
[modify] https://crrev.com/17a78d01b1bf534791759caf259f8abffb4d0725/components/exo/shell_surface_base.cc

Sign in to add a comment