root surface should be snapped to the physical pixel |
|||||||
Issue descriptionLooks like it's not aligned and can become blurry with fractional scale factor. I have a fix and will send out soon.
,
Apr 24 2018
,
Apr 24 2018
Did you mean merge requested?
,
Apr 24 2018
yes, thanks.
,
Apr 24 2018
,
Apr 24 2018
Hi, is this a M67 regression / bug-fix? Also, has the fix been tested against some number of boards?
,
Apr 25 2018
This was probably regressed in 65 time frame. I didn't request for 66 because it's too late. I tested on caroline as well.
,
Apr 25 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17a78d01b1bf534791759caf259f8abffb4d0725 commit 17a78d01b1bf534791759caf259f8abffb4d0725 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Apr 25 16:34:23 2018 Snap root surface to physical pixel The root surface needs to be snapped if the shell surface uses chrome side caption. This CL also removes "!allow_set_bounds_direct" check when snapping the window in WindowState. This should have been removed when we switched to relative surface hierarchy. Bug: 836076 Test: manually tested with fractional scale factor. Change-Id: Iadc06572279dec42f8d792424cee76481a94fd55 Reviewed-on: https://chromium-review.googlesource.com/1025371 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553124}(cherry picked from commit 9225426bdc23969573e2b9f3ed7443865ef47539) Reviewed-on: https://chromium-review.googlesource.com/1028372 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#295} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/17a78d01b1bf534791759caf259f8abffb4d0725/ash/wm/window_state.cc [modify] https://crrev.com/17a78d01b1bf534791759caf259f8abffb4d0725/components/exo/shell_surface_base.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 24 2018