Chrome Version: ToT OS: All but iOS Now #includes in many C++ files in out/$CONFIG/gen/third_party/blink/renderer/ does not start with "third_party/blink/renderer/". It violates the style guide.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36304eda7b3a59d740b4b6c0e3f62ce9cd3ffa7f commit 36304eda7b3a59d740b4b6c0e3f62ce9cd3ffa7f Author: Kent Tamura <tkent@chromium.org> Date: Tue Apr 24 23:20:00 2018 probe: Qualify #includes in generated code. * Add "third_party/blink/renderer/" to some values in CoreProbes.json5 and PlatformProbes.json5. * make_instrumenting_probes.py passes a directory name relative to out/$config/gen/, and a template uses it to generate #includes. Bug: 836071 Change-Id: I31ac5efaba5b96914e342d5c4f54a236b5c3fab1 Reviewed-on: https://chromium-review.googlesource.com/1025233 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553351} [modify] https://crrev.com/36304eda7b3a59d740b4b6c0e3f62ce9cd3ffa7f/third_party/blink/renderer/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/36304eda7b3a59d740b4b6c0e3f62ce9cd3ffa7f/third_party/blink/renderer/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl [modify] https://crrev.com/36304eda7b3a59d740b4b6c0e3f62ce9cd3ffa7f/third_party/blink/renderer/core/probe/CoreProbes.json5 [modify] https://crrev.com/36304eda7b3a59d740b4b6c0e3f62ce9cd3ffa7f/third_party/blink/renderer/platform/probe/PlatformProbes.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7eb29f451d2f10f7620d024b84d6257dd03a512 commit a7eb29f451d2f10f7620d024b84d6257dd03a512 Author: Kent Tamura <tkent@chromium.org> Date: Fri Apr 27 07:51:18 2018 make_names: Qualify #include for the primary header, and fix header guard. The main change of this CL is that MakeNamesWriter.__init__() sets a qualified header path and a correct include guard to _template_context. In order to do it, - json5_generator.Writer.__init__() takes output_dir argument, and stores a directory name relative to "gen/". - Introduce json5_generator.Writer.make_header_guard(). Bug: 836071 Change-Id: I75a8ce8849071cb5a32e19f4304dc070937a8554 Reviewed-on: https://chromium-review.googlesource.com/1025351 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#554336} [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/make_css_value_keywords.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/make_cssom_types.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/make_media_features.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/make_style_shorthands.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_base.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/core/style/make_computed_style_initial_values.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/json5_generator.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_computed_style_base.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_css_primitive_value_unit_trie.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_css_property_names.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_css_value_id_mappings.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_element_factory.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_element_lookup_trie.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_element_type_helpers.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_event_factory.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_internal_runtime_flags.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_internal_settings.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_names.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_origin_trials.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_qualified_names.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_runtime_features.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_settings.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/make_style_builder.py [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/templates/make_names.cc.tmpl [modify] https://crrev.com/a7eb29f451d2f10f7620d024b84d6257dd03a512/third_party/blink/renderer/build/scripts/templates/make_names.h.tmpl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4f0b4dcf1305706fdb04d445913a10c3a23bf6d commit b4f0b4dcf1305706fdb04d445913a10c3a23bf6d Author: Kent Tamura <tkent@chromium.org> Date: Tue May 01 02:39:11 2018 DevTools: Qualify #includes in files generated from inspector_protocol_config.json. Bug: 836071 Change-Id: I5d91b8afa805aed97113709ab33d30e4cad1799b Reviewed-on: https://chromium-review.googlesource.com/1032253 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#554978} [modify] https://crrev.com/b4f0b4dcf1305706fdb04d445913a10c3a23bf6d/third_party/blink/renderer/core/inspector/inspector_protocol_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f5387a82eef4b26738a0d8572e947be7728012b commit 1f5387a82eef4b26738a0d8572e947be7728012b Author: Kent Tamura <tkent@chromium.org> Date: Tue May 01 12:31:40 2018 Qualify #includes in CSS-related generated files and fix include guards. This CL has no behavior changes. Bug: 836071 Change-Id: Icd4a0c1caf8b760e8c6c02b1ed8eea35b9767982 Reviewed-on: https://chromium-review.googlesource.com/1036714 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555027} [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/parser/templates/at_rule_descriptors.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.cc.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_unresolved_property.cc.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_unresolved_property.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/core/style/templates/computed_style_initial_values.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/templates/computed_style_base.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/templates/computed_style_base_constants.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/templates/css_property_names.cc.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/templates/css_property_names.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/build/scripts/templates/css_value_id_mappings_generated.h.tmpl [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/core/css/CSSProperties.json5 [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/core/css/ComputedStyleExtraFields.json5 [modify] https://crrev.com/1f5387a82eef4b26738a0d8572e947be7728012b/third_party/blink/renderer/core/css/ComputedStyleFieldAliases.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66e7407fa8b5729ad380bd4c3e52cfc43b9a5db4 commit 66e7407fa8b5729ad380bd4c3e52cfc43b9a5db4 Author: Kent Tamura <tkent@chromium.org> Date: Wed May 02 02:24:08 2018 Qualify #includes in files generated by make_qualified_names.py. Also, fix include guards. This CL has no behavior changes. Bug: 836071 Change-Id: I21d78c16c302405e9fb375843388aaaaaf093500 Reviewed-on: https://chromium-review.googlesource.com/1037047 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555288} [modify] https://crrev.com/66e7407fa8b5729ad380bd4c3e52cfc43b9a5db4/third_party/blink/renderer/build/scripts/make_qualified_names.py [modify] https://crrev.com/66e7407fa8b5729ad380bd4c3e52cfc43b9a5db4/third_party/blink/renderer/build/scripts/templates/make_qualified_names.cc.tmpl [modify] https://crrev.com/66e7407fa8b5729ad380bd4c3e52cfc43b9a5db4/third_party/blink/renderer/build/scripts/templates/make_qualified_names.h.tmpl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d8c61f1819004aa9569602051576e6ea7fbb8c8 commit 6d8c61f1819004aa9569602051576e6ea7fbb8c8 Author: Kent Tamura <tkent@chromium.org> Date: Wed May 02 02:29:18 2018 Qualify #includes in generated event_factory.cc and event_modules_factory.cc. generate_event_interfaces.py should produce paths relative to the repository root. Bug: 836071 Change-Id: Ibcb9fbe2cdb1e6e0e8f46ad1c0caec11c23123f3 Reviewed-on: https://chromium-review.googlesource.com/1038984 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555290} [modify] https://crrev.com/6d8c61f1819004aa9569602051576e6ea7fbb8c8/third_party/blink/renderer/bindings/scripts/generate_event_interfaces.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bff7e1e94cb696378ebb983b05fa11ae62f74be2 commit bff7e1e94cb696378ebb983b05fa11ae62f74be2 Author: Kent Tamura <tkent@chromium.org> Date: Wed May 02 02:56:05 2018 Qualify #include in generated html_entity_table.cc. Bug: 836071 Change-Id: Icf7069a6c58d395edae8fddcdb84d07854e8d341 Reviewed-on: https://chromium-review.googlesource.com/1039103 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555292} [modify] https://crrev.com/bff7e1e94cb696378ebb983b05fa11ae62f74be2/third_party/blink/renderer/core/html/parser/create-html-entity-table
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6197b56a3513f23fdafbfe3856c1673b13826eb commit e6197b56a3513f23fdafbfe3856c1673b13826eb Author: Kent Tamura <tkent@chromium.org> Date: Wed May 02 04:01:57 2018 Qualify #includes in element-related generated source files. This CL fixes #includes and/or include guards of the following generated files: - html_element_factory.cc - html_element_factory.h - html_element_lookup_trie.cc - html_element_lookup_trie.h - html_element_type_helpers.cc - html_element_type_helpers.h - svg_element_factory.cc - svg_element_factory.h - svg_element_type_helpers.cc - svg_element_type_helpers.h Bug: 836071 Change-Id: Ie9cd4e4c937262f32e64c574903be4580281f3b1 Reviewed-on: https://chromium-review.googlesource.com/1038924 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#555304} [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/make_element_factory.py [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/make_element_type_helpers.py [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/templates/element_factory.cc.tmpl [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/templates/element_factory.h.tmpl [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/templates/element_lookup_trie.cc.tmpl [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/templates/element_lookup_trie.h.tmpl [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/templates/element_type_helpers.cc.tmpl [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/build/scripts/templates/element_type_helpers.h.tmpl [modify] https://crrev.com/e6197b56a3513f23fdafbfe3856c1673b13826eb/third_party/blink/renderer/core/html/html_tag_names.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f4f1890a720a50c50f20a12effe6a946767831c commit 7f4f1890a720a50c50f20a12effe6a946767831c Author: Kent Tamura <tkent@chromium.org> Date: Tue May 15 06:39:04 2018 Remove unnecessary include_dirs settings from BUILD.gn in Blink Now we have no Blink-relative #includes. Bug: 836071 Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b Reviewed-on: https://chromium-review.googlesource.com/1058876 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558629} [modify] https://crrev.com/7f4f1890a720a50c50f20a12effe6a946767831c/third_party/blink/public/BUILD.gn [modify] https://crrev.com/7f4f1890a720a50c50f20a12effe6a946767831c/third_party/blink/renderer/BUILD.gn [modify] https://crrev.com/7f4f1890a720a50c50f20a12effe6a946767831c/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/7f4f1890a720a50c50f20a12effe6a946767831c/third_party/blink/renderer/modules/exported/BUILD.gn [modify] https://crrev.com/7f4f1890a720a50c50f20a12effe6a946767831c/third_party/blink/renderer/platform/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ff88cac65b856bf93cf7e136760a69b2d300659 commit 1ff88cac65b856bf93cf7e136760a69b2d300659 Author: Bruce Dawson <brucedawson@chromium.org> Date: Tue May 15 12:56:39 2018 Revert "Remove unnecessary include_dirs settings from BUILD.gn in Blink" This reverts commit 7f4f1890a720a50c50f20a12effe6a946767831c. Reason for revert: This CL breaks non-goma builds (any build that uses precompiled header files) Original change's description: > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > Now we have no Blink-relative #includes. > > Bug: 836071 > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > Reviewed-on: https://chromium-review.googlesource.com/1058876 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558629} TBR=peria@chromium.org,tkent@chromium.org Change-Id: I087e3344be78d3cc3a764ae6536ede3f6f0b0563 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836071 Reviewed-on: https://chromium-review.googlesource.com/1059515 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558676} [modify] https://crrev.com/1ff88cac65b856bf93cf7e136760a69b2d300659/third_party/blink/public/BUILD.gn [modify] https://crrev.com/1ff88cac65b856bf93cf7e136760a69b2d300659/third_party/blink/renderer/BUILD.gn [modify] https://crrev.com/1ff88cac65b856bf93cf7e136760a69b2d300659/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/1ff88cac65b856bf93cf7e136760a69b2d300659/third_party/blink/renderer/modules/exported/BUILD.gn [modify] https://crrev.com/1ff88cac65b856bf93cf7e136760a69b2d300659/third_party/blink/renderer/platform/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/373af2643c32cd9b68f1195eb6466f6e1165d559 commit 373af2643c32cd9b68f1195eb6466f6e1165d559 Author: Kent Tamura <tkent@chromium.org> Date: Wed May 16 06:58:39 2018 Remove Blink-relative #includes in precompile_*.h. Also fixes include guard style. Bug: 836071 Change-Id: Ib6b268ee2b75e05aef2cec7220d90fa3779830eb Reviewed-on: https://chromium-review.googlesource.com/1059985 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#559003} [modify] https://crrev.com/373af2643c32cd9b68f1195eb6466f6e1165d559/third_party/blink/renderer/build/mac/prefix.h [modify] https://crrev.com/373af2643c32cd9b68f1195eb6466f6e1165d559/third_party/blink/renderer/build/win/precompile.h [modify] https://crrev.com/373af2643c32cd9b68f1195eb6466f6e1165d559/third_party/blink/renderer/core/precompile_core.h [modify] https://crrev.com/373af2643c32cd9b68f1195eb6466f6e1165d559/third_party/blink/renderer/platform/precompile_platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55d941b0b748bd667248166b7cb70d3716fd67ac commit 55d941b0b748bd667248166b7cb70d3716fd67ac Author: Kent Tamura <tkent@chromium.org> Date: Wed May 16 09:01:07 2018 Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink" This is a reland of 7f4f1890a720a50c50f20a12effe6a946767831c This CL has no differences from it. http://crrev.com/559003 should fix a build issue. Original change's description: > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > Now we have no Blink-relative #includes. > > Bug: 836071 > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > Reviewed-on: https://chromium-review.googlesource.com/1058876 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558629} TBR=peria@chromium.org Bug: 836071 Change-Id: I452a61199a31b6a6a617e2985331ab6a034c6c7c Reviewed-on: https://chromium-review.googlesource.com/1059636 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#559018} [modify] https://crrev.com/55d941b0b748bd667248166b7cb70d3716fd67ac/third_party/blink/public/BUILD.gn [modify] https://crrev.com/55d941b0b748bd667248166b7cb70d3716fd67ac/third_party/blink/renderer/BUILD.gn [modify] https://crrev.com/55d941b0b748bd667248166b7cb70d3716fd67ac/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/55d941b0b748bd667248166b7cb70d3716fd67ac/third_party/blink/renderer/modules/exported/BUILD.gn [modify] https://crrev.com/55d941b0b748bd667248166b7cb70d3716fd67ac/third_party/blink/renderer/platform/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a014bedd6ebfd86184750134978b873f69ed49b1 commit a014bedd6ebfd86184750134978b873f69ed49b1 Author: Nico Weber <thakis@chromium.org> Date: Wed May 16 15:39:32 2018 Revert "Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink"" This reverts commit 55d941b0b748bd667248166b7cb70d3716fd67ac. Reason for revert: Looks like this broke compile on Windows without goma. E.g. https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/603 error: error reading '../../third_party/blink/renderer/build/win/precompile.h' I'm guessing the precompile step needs a "-I." flag that it currently lacks. Original change's description: > Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink" > > This is a reland of 7f4f1890a720a50c50f20a12effe6a946767831c > This CL has no differences from it. http://crrev.com/559003 should > fix a build issue. > > Original change's description: > > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > > > Now we have no Blink-relative #includes. > > > > Bug: 836071 > > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > > Reviewed-on: https://chromium-review.googlesource.com/1058876 > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#558629} > > TBR=peria@chromium.org > > Bug: 836071 > Change-Id: I452a61199a31b6a6a617e2985331ab6a034c6c7c > Reviewed-on: https://chromium-review.googlesource.com/1059636 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559018} TBR=peria@chromium.org,tkent@chromium.org Change-Id: Idc752c3912c4e4e5a1f941990883693b112aed7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836071 Reviewed-on: https://chromium-review.googlesource.com/1061598 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559115} [modify] https://crrev.com/a014bedd6ebfd86184750134978b873f69ed49b1/third_party/blink/public/BUILD.gn [modify] https://crrev.com/a014bedd6ebfd86184750134978b873f69ed49b1/third_party/blink/renderer/BUILD.gn [modify] https://crrev.com/a014bedd6ebfd86184750134978b873f69ed49b1/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/a014bedd6ebfd86184750134978b873f69ed49b1/third_party/blink/renderer/modules/exported/BUILD.gn [modify] https://crrev.com/a014bedd6ebfd86184750134978b873f69ed49b1/third_party/blink/renderer/platform/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e695d4ed1baac46152bef7a57baeb03dc98785d6 commit e695d4ed1baac46152bef7a57baeb03dc98785d6 Author: Kent Tamura <tkent@chromium.org> Date: Thu May 17 06:48:13 2018 Windows: Fix base path for precompiled_header Change it from root_build_dir to "//". /FI flag argument produces #include virtually, and there is no reason to use a path relative to root_build_dir, which is //out/$config typically. We should use a path relative to the repository root as usual. This is a preparation to remove "." from include_dirs defined in the BUILD.gn. Bug: 836071 Change-Id: I19351b752957e85f9f1aee9fc981e0a8d0f31ff8 Reviewed-on: https://chromium-review.googlesource.com/1063510 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#559440} [modify] https://crrev.com/e695d4ed1baac46152bef7a57baeb03dc98785d6/third_party/blink/renderer/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e0f404d280e32502c7976de87d13ccfebff4c79 commit 0e0f404d280e32502c7976de87d13ccfebff4c79 Author: Kent Tamura <tkent@chromium.org> Date: Thu May 17 07:02:48 2018 Reland "Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink"" This is a reland of 55d941b0b748bd667248166b7cb70d3716fd67ac This CL has no diiferences from it. http://crrev.com/559440 should fixed a build issue on non-goma Windows. Original change's description: > Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink" > > This is a reland of 7f4f1890a720a50c50f20a12effe6a946767831c > This CL has no differences from it. http://crrev.com/559003 should > fix a build issue. > > Original change's description: > > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > > > Now we have no Blink-relative #includes. > > > > Bug: 836071 > > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > > Reviewed-on: https://chromium-review.googlesource.com/1058876 > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#558629} > > TBR=peria@chromium.org > > Bug: 836071 > Change-Id: I452a61199a31b6a6a617e2985331ab6a034c6c7c > Reviewed-on: https://chromium-review.googlesource.com/1059636 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559018} TBR=peria@chromium.org Bug: 836071 Change-Id: Iade8aebc34d13ac08b257e2c7451071064b8474b Reviewed-on: https://chromium-review.googlesource.com/1063411 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#559442} [modify] https://crrev.com/0e0f404d280e32502c7976de87d13ccfebff4c79/third_party/blink/public/BUILD.gn [modify] https://crrev.com/0e0f404d280e32502c7976de87d13ccfebff4c79/third_party/blink/renderer/BUILD.gn [modify] https://crrev.com/0e0f404d280e32502c7976de87d13ccfebff4c79/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/0e0f404d280e32502c7976de87d13ccfebff4c79/third_party/blink/renderer/modules/exported/BUILD.gn [modify] https://crrev.com/0e0f404d280e32502c7976de87d13ccfebff4c79/third_party/blink/renderer/platform/BUILD.gn
Comment 1 by tkent@chromium.org
, Apr 24 2018