Issue metadata
Sign in to add a comment
|
Use display zoom factors instead of ui scales for aura shell |
||||||||||||||||||||||
Issue descriptionThe new update for Crostini breaks when we enable display zoom factor. We need to fix this before we can enable it.
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c483e3b4559567ccdd1d11c7de29e6ce941da3e8 commit c483e3b4559567ccdd1d11c7de29e6ce941da3e8 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Apr 24 03:18:43 2018 Use display zoom factors instead of ui scales This patch replaces ui scales for zoom factors to allow the clients to compute the ideal content scale. This patch also adds more scale factor enums to aura shell interface. Bug: 835030 , 836054 Component: aura shell Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1024920 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552986} [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/clients/info.cc [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/public/aura-shell-client-protocol.h [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/server.cc
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
Is this a M67 regression, and/or in support of a new M67 feature? Has the change been tested and verified for some number of boards against ToT?
,
Apr 24 2018
The display zoom feature (Issue 790723) breaks the newer version of crostini set to release for dogfood soon. This patch resolves that breakage.
,
Apr 24 2018
Okay, thanks.. Didn't catch an update on testing, however. Sure it's good to go and not causing a new regression? Thanks
,
Apr 24 2018
This effects crostini primarily and android (maybe). - For crostini this was tested by @reveman - For android so far there have been no issues and there is none expected (@oshima).
,
Apr 25 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36412d77e4e8a7d5b6d06d8f2861412c007c65ef commit 36412d77e4e8a7d5b6d06d8f2861412c007c65ef Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 25 04:17:18 2018 (merge) Use display zoom factors instead of ui scales Merge to M67 This patch replaces ui scales for zoom factors to allow the clients to compute the ideal content scale. This patch also adds more scale factor enums to aura shell interface. Bug: 835030 , 836054 Component: aura shell Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1024920 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552986}(cherry picked from commit c483e3b4559567ccdd1d11c7de29e6ce941da3e8) TBR=reveman@chromium.org Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1027271 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#281} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/clients/info.cc [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/public/aura-shell-client-protocol.h [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/server.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by malaykeshav@chromium.org
, Apr 24 2018Cc: ovanieva@chromium.org reve...@chromium.org kaznacheev@chromium.org osh...@chromium.org
Labels: OS-Chrome