Issue metadata
Sign in to add a comment
|
[WPT] New failures introduced in external/wpt/webaudio by import https://crrev.com/c/1024300 |
||||||||||||||||||||||
Issue descriptionWPT import https://crrev.com/c/1024300 introduced new failures in external/wpt/webaudio: List of new failures: [ Mac10.12 ] external/wpt/webaudio/idlharness.https.html [ Timeout ] This import contains upstream changes from d858d20fec36b1699a869bc42127f6b45b4f14a1 to 231665bd24302754139718b48b96bdf502893953: Add acid/OWNERS and js/OWNERS: https://github.com/w3c/web-platform-tests/commit/231665bd24302754139718b48b96bdf502893953 [wptserve] Add substitution to calculate file hash: https://github.com/w3c/web-platform-tests/commit/e0ea063afe0759e5c4928b0ca0e2c6a561ef7eaa [wptserve] Expand syntax to support fn invocation: https://github.com/w3c/web-platform-tests/commit/dd3f71885bd5039f7ba6f357ac2a43fc510ee23f [wptserve] Correct typo in documentation: https://github.com/w3c/web-platform-tests/commit/18ee2b46ab4c3c25053a01ded402834b65b75565 [wptserve] Add tests: https://github.com/w3c/web-platform-tests/commit/cc236aa5904d4131ef725762a2f91f564de86615 Fix some layout tests that calls createPseudo: https://github.com/w3c/web-platform-tests/commit/c873caf7621a7376f976246eaa4921b13988e54a
,
Apr 24 2018
Interesting. I also wonder why it only fails on Mac10.12. Raymond, could you point me to your earlier CL that supposedly broke the test?
,
Apr 24 2018
Yeah, just noticed crbug.com/626703 for the timeone out Mac10.12. I didn't know about that either. And running ToT code today (that includes the new IDL attribute) on my linux box shows the webaudio idlharness test passes. Plus I can't find run-blink-wptserve anymore. The CL that added a new attribute: https://chromium-review.googlesource.com/c/chromium/src/+/945076
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63cd4dfaaf44489cb6614d27de3bc08e4056c57b commit 63cd4dfaaf44489cb6614d27de3bc08e4056c57b Author: Raymond Toy <rtoy@chromium.org> Date: Tue Apr 24 18:50:01 2018 Add AudioParam.automationRate to WebAudio IDL Update WebAudio interface to include the very recently added automationRate attribute for an AudioParam. Also remove idlharness time expectation (suggested by Robert Ma). And this doesn't actually resolve any of failures in the bug, but it's a convenient place to update the IDL that should have been done earlier. Bug: 836051 Test: webaudio/idlharness.https.html Change-Id: Icd535ee63f0a5f8772cb3445c762c89154fbda88 Reviewed-on: https://chromium-review.googlesource.com/1026199 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#553218} [modify] https://crrev.com/63cd4dfaaf44489cb6614d27de3bc08e4056c57b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/63cd4dfaaf44489cb6614d27de3bc08e4056c57b/third_party/WebKit/LayoutTests/external/wpt/interfaces/web-audio-api.idl [modify] https://crrev.com/63cd4dfaaf44489cb6614d27de3bc08e4056c57b/third_party/WebKit/LayoutTests/external/wpt/webaudio/idlharness.https-expected.txt
,
Apr 24 2018
I suspect the timeout was an unrelated, transient flake. The CL above doesn't actually "fix" anything, just removing the timeout expectation as there's really no reason for this IDL harness test to time out.
,
Apr 25 2018
I'm going to mark as fixed since the "issue" is probably a flake (c#5). If it's wrong, please reopen or file a new issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rtoy@chromium.org
, Apr 24 2018Owner: rtoy@chromium.org
Status: Started (was: Untriaged)