New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836031 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Accessibility

Blocked on:
issue 836549

Blocking:
issue 817592


Participants' hotlists:
media-controls-a11y

Show other hotlists

Other hotlists containing this issue:
Modern-Media-Controls
media-controls-a11y


Sign in to add a comment

Media Controls: can't access buttons via Voice Over

Project Member Reported by mlamouri@chromium.org, Apr 23 2018

Issue description

On Mac, using this page [1], it's impossible to access the individual buttons using Voice Over.

[1] https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html

This issue appears to not be specific to the new media controls. The old controls offered access to the "toolbar" but wouldn't allow each button to be accessed. At the end, it seems fairly similar.

+ellyjones@ to hear more about how Voice Over works and why this isn't working as we would expect.

Marking as P2 as it is not a regression but we intend to fix for M68.
 
Blocking: 817592
How does one trigger the new controls?
It's chrome://flags/#enable-modern-media-controls but the issue doesn't seem to be specific to them.
Owner: nek...@chromium.org
Status: Assigned (was: Available)
Huh. I can see the video controls in the a11y inspector, so they're *present*, but I can't navigate to them. In fact, the a11y hierarchy looks like this:

video video (group)
  <empty description> (group)
    video (toolbar)
    video (toolbar)
      video (toolbar)
        play (button)
        video (toolbar)
          0:00 (text)
          / 9:56 (text)
          mute (button)
          enter full screen (button)
          show more media controls (button)
        0:00 (slider)

This is a very confused a11y tree. It seems like the DOM from here: <https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc?type=cs&sq=package:chromium&l=429>. It probably needs some a11y annotations so that the actual tree is:

  video video (group)
    video (toolbar)
      play (button)
      0:00 / 9:56 (text)
      mute (button)
      enter full screen (button)
      show more media controls (button)

CC nektar@, who can give further guidance.
We have another bug filed to improve the annotations. It's out of scope to shave the tree but I agree that it would be great to do if we can. Though, just to confirm, this has nothing to do with the fact that VoiceOver can't access it, right?
Labels: -Pri-2 Pri-1
Owner: lethalantidote@chromium.org
I am able to access the buttons, although doing so isnt intuitive. I believe in order to access the individual buttons you have to control-option-shift-down once (says toolbar for the first time), then hit the right key, then control-option-shift-down twice
Actually I think you need to press right after each time u control-option-shift-down, not the just first time. 
Status: Started (was: Assigned)
I think this problem will be fixed by simplifying the tree. I'll look into it.
Blockedon: 836549
Cc: nek...@chromium.org
+nektar@

@ellyjones and nektar, do you have any pointers to the a11y annotations mentioned? What I'm understanding is that if I apply those annotations to the correct nodes, the tree will be vastly simplified, at least from the perspective of the a11y tools.
So I was able to get it to look like this. Is it crucial that we show that toolbar child?
a11ysimp.png
13.4 KB View Download
I can't immediately tell from the screenshot if this is what we want - if you have a Mac, can you try using it with VoiceOver and see if it's reasonable? (If you don't have a Mac but you do have a patch, I can patch it locally and try it)

Sign in to add a comment