New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836030 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Support loading generic traces in DevTools

Project Member Reported by alph@chromium.org, Apr 23 2018

Issue description

Allow generic traces recorded with e.g. trace-viewer be loaded into DevTools performance panel.

Provide a generic view of such traces showing all the processes and threads.
 

Comment 1 by alph@chromium.org, Apr 24 2018

Screenshot from 2018-04-24 11-26-09.png
200 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4141778eb03a31a20d9e109f74faf2f756b4a8c4

commit 4141778eb03a31a20d9e109f74faf2f756b4a8c4
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Apr 26 00:52:00 2018

DevTools: Support generic traces on Performance panel

Show all processes and threads for generic traces.

BUG= 836030 

Change-Id: Ib8486667328a726f771f888c0ccf6f2e269c37f8
Reviewed-on: https://chromium-review.googlesource.com/1025136
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553857}
[add] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/generic-trace-expected.txt
[add] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/generic-trace.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/main/Main.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/timeline/PerformanceModel.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/4141778eb03a31a20d9e109f74faf2f756b4a8c4/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d410ebf4ca97f812ca1c2da583397bd39813459

commit 2d410ebf4ca97f812ca1c2da583397bd39813459
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Apr 28 01:01:13 2018

DevTools: Do not show screenshots overview bar if there's no screenshots

BUG= 836030 

Change-Id: I8c01d3186568ac162cc1be118dd8faf06fcee074
Reviewed-on: https://chromium-review.googlesource.com/1033327
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554591}
[modify] https://crrev.com/2d410ebf4ca97f812ca1c2da583397bd39813459/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/2d410ebf4ca97f812ca1c2da583397bd39813459/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineFrameModel.js

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b79085234f1897b39abeb8632008f5dd91c3f0fe

commit b79085234f1897b39abeb8632008f5dd91c3f0fe
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Apr 28 01:02:31 2018

DevTools: Move visible events filter to TimelineModel

BUG= 836030 

Change-Id: I0a11b2dd04b21b06a33e0fd9e20c9cc299901c6f
Reviewed-on: https://chromium-review.googlesource.com/1032232
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554592}
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/performance_test_runner/TimelineTestRunner.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/EventsTimelineTreeView.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/PerformanceModel.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/TimelineDetailsView.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js
[modify] https://crrev.com/b79085234f1897b39abeb8632008f5dd91c3f0fe/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineProfileTree.js

Status: Fixed (was: Assigned)

Sign in to add a comment