Issue metadata
Sign in to add a comment
|
Clank data saver settings page issues with Talkback |
||||||||||||||||||||||||
Issue descriptionOS: Android Steps: - Open Clank - Open more options menu - Tap the last item around your data saved since X date - Try to use Talkback to navigate this page. Swipe one finger from left to right to move item by item on the screen to hear it verbalized. Expected result: You can navigate to all items on the page through swiping linearly (object by object). Actual result: I'm running into some issues using Talkback to navigate the Data Saver page of settings... I can't use Talkback linear navigation to get through a lot of the page (any items are being skipped, such as the dates on the graph, the actual table stats). Also, I can navigate to the Used and Saved buttons, but they are not verbalized as buttons, and it's not verbalized that this is how they are sorted (e.g. sorted down). Right now, that info is not communicated to the user at all. This page needs some work with Talkback on... let me know if you want to meet to chat more about this.
,
May 16 2018
Fyi Robert, here is a bug that Ben and I were wondering about handing to you.
,
May 25 2018
,
May 29 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3684f1d6d959818e944253c0f1e2653d408683f1 commit 3684f1d6d959818e944253c0f1e2653d408683f1 Author: Robert Ogden <robertogden@chromium.org> Date: Wed May 30 23:10:21 2018 Fix DataSaver TalkBack issues Also adds an option to sort by hostname on the DataSaver settings page so that the TalkBack navigation experience is consistent with the other table headers. Bug: 836018 Change-Id: Ic837d520ea613185398b0b2214640b80a41bcfa4 Reviewed-on: https://chromium-review.googlesource.com/1077588 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#563052} [modify] https://crrev.com/3684f1d6d959818e944253c0f1e2653d408683f1/chrome/android/java/res/layout/data_usage_breakdown.xml [modify] https://crrev.com/3684f1d6d959818e944253c0f1e2653d408683f1/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java [modify] https://crrev.com/3684f1d6d959818e944253c0f1e2653d408683f1/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java [modify] https://crrev.com/3684f1d6d959818e944253c0f1e2653d408683f1/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java [modify] https://crrev.com/3684f1d6d959818e944253c0f1e2653d408683f1/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/3684f1d6d959818e944253c0f1e2653d408683f1/tools/metrics/histograms/enums.xml
,
May 31 2018
,
May 31 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
May 31 2018
Laura, please verify the fix so I can request a merge to 68.
,
Jun 4 2018
,
Jun 4 2018
See video for fixed verification I'd like to merge this to M68 since this fixes important usability for users with TalkBack
,
Jun 4 2018
This bug requires manual review: There is .grd file changes and we are only 49 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76d3ad3c60395aececb79777f55b4c9f71cf4451 commit 76d3ad3c60395aececb79777f55b4c9f71cf4451 Author: Robert Ogden <robertogden@chromium.org> Date: Mon Jun 04 21:54:22 2018 Remove Net.HttpContentLengthDifference This histogram is no longer used. Bug: 836018 Change-Id: I6b450beb589247460fc54c9a6ccc6203a0f9306b Reviewed-on: https://chromium-review.googlesource.com/1082914 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#564253} [modify] https://crrev.com/76d3ad3c60395aececb79777f55b4c9f71cf4451/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc [modify] https://crrev.com/76d3ad3c60395aececb79777f55b4c9f71cf4451/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc [modify] https://crrev.com/76d3ad3c60395aececb79777f55b4c9f71cf4451/tools/metrics/histograms/histograms.xml
,
Jun 6 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc52b002b25d9d4cc8565fbe09aabf70fad88868 commit cc52b002b25d9d4cc8565fbe09aabf70fad88868 Author: Robert Ogden <robertogden@chromium.org> Date: Wed Jun 06 18:30:54 2018 Fix DataSaver TalkBack issues Also adds an option to sort by hostname on the DataSaver settings page so that the TalkBack navigation experience is consistent with the other table headers. Bug: 836018 Change-Id: Ic837d520ea613185398b0b2214640b80a41bcfa4 Reviewed-on: https://chromium-review.googlesource.com/1077588 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563052}(cherry picked from commit 3684f1d6d959818e944253c0f1e2653d408683f1) Reviewed-on: https://chromium-review.googlesource.com/1089250 Reviewed-by: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#214} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/cc52b002b25d9d4cc8565fbe09aabf70fad88868/chrome/android/java/res/layout/data_usage_breakdown.xml [modify] https://crrev.com/cc52b002b25d9d4cc8565fbe09aabf70fad88868/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionProxyUma.java [modify] https://crrev.com/cc52b002b25d9d4cc8565fbe09aabf70fad88868/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java [modify] https://crrev.com/cc52b002b25d9d4cc8565fbe09aabf70fad88868/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java [modify] https://crrev.com/cc52b002b25d9d4cc8565fbe09aabf70fad88868/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/cc52b002b25d9d4cc8565fbe09aabf70fad88868/tools/metrics/histograms/enums.xml |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bengr@chromium.org
, Apr 24 2018Labels: M-68