New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 836009 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We no longer need to defer commit

Project Member Reported by cblume@chromium.org, Apr 23 2018

Issue description

Previously, we would defer commit when the child didn't yet have a LocalSurfaceId. But now the child has the ability to allocate its own. This means we no longer need to defer commits.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8be47737dac4c9971c977ba4081db6e15db8e3fa

commit 8be47737dac4c9971c977ba4081db6e15db8e3fa
Author: Chris Blume <cblume@chromium.org>
Date: Tue Apr 24 21:06:56 2018

Remove early call to DidResizeOrRepaintAck()

Previously, we would defer commit when the child didn't yet have a
LocalSurfaceId. This meant we needed a special case to call
DidResizeOrRepaintAck() early when commit would be deferred.

But now the child has the ability to allocate its own
LocalSurfaceId. As a result, we no longer need to defer commit. And
thus, no longer need to call DidResizeOrRepaintAck() early.

BUG= 805073 , 811944 , 836009 

Change-Id: I4e85e926f217cf0fd2d4b5ed3854f09e7145e5a8
Reviewed-on: https://chromium-review.googlesource.com/1024739
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553276}
[modify] https://crrev.com/8be47737dac4c9971c977ba4081db6e15db8e3fa/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8be47737dac4c9971c977ba4081db6e15db8e3fa/content/renderer/render_widget.cc
[modify] https://crrev.com/8be47737dac4c9971c977ba4081db6e15db8e3fa/content/renderer/render_widget.h
[modify] https://crrev.com/8be47737dac4c9971c977ba4081db6e15db8e3fa/content/renderer/render_widget_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment