Dragging a tab into a window doesn't force it to the min active width |
||
Issue description(1) Create a Chrome window with enough tabs that inactive tabs become narrower than active ones (2) Drag a tab out of the window. This should automatically make a different tab active and set its width to the "active tab" width. You can either drop the tab somewhere, or keep holding the mouse button here; it doesn't matter. (3) Drag the tab back into the window. Ideally, this should make this tab the "active tab" width. Instead, the tab is drawn with the active color and showing the close button, but the "inactive tab" width. So, the bug is that the newly-activated tab needs to be set to the active tab width when dragged into the window. sangwoo108@, you've been looking at this stuff lately, want to take a stab at this?
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7 commit 20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7 Author: sangwoo.ko <sangwoo108@chromium.org> Date: Wed May 02 03:12:24 2018 Reorder a couple calls in TabDragController::Attach() In order to set proper bounds for active tab which is being dragged, TabStrin::StartedDraggingTabs() should be called after ResetSelection(). Bug: 836004 Change-Id: I7243bf75b1d3243e55892386f2a5debc092bf925 Reviewed-on: https://chromium-review.googlesource.com/1027590 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555295} [modify] https://crrev.com/20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h [modify] https://crrev.com/20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/20cf034c3cee0d0e6bb46b4cca0d8d2bd676eeb7/chrome/browser/ui/views/tabs/tab_strip_unittest.cc
,
May 2 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by sangwoo108@chromium.org
, Apr 24 2018