Add section annotation to the Autofill prediction title |
|||
Issue descriptionWhile debugging with the show-autofill-type-predictions flag, it would also be very useful to have the predicted section.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40d13ba16e12197c608ed31b075f4178585434c4 commit 40d13ba16e12197c608ed31b075f4178585434c4 Author: sebsg <sebsg@chromium.org> Date: Wed Apr 25 17:18:08 2018 [AF] Add section annotation to the Autofill prediction title. Bug: 835994 Change-Id: I817b6ced87513054339397f825f695019cd68a36 Reviewed-on: https://chromium-review.googlesource.com/1025043 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553620} [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/content/common/autofill_types.mojom [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/content/common/autofill_types_struct_traits.cc [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/content/common/autofill_types_struct_traits.h [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/content/common/autofill_types_struct_traits_unittest.cc [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/content/renderer/form_cache.cc [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/core/common/form_field_data_predictions.cc [modify] https://crrev.com/40d13ba16e12197c608ed31b075f4178585434c4/components/autofill/core/common/form_field_data_predictions.h
,
Apr 25 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54ecd00db27f643379da39837abb338bcda98cf1 commit 54ecd00db27f643379da39837abb338bcda98cf1 Author: sebsg <sebsg@chromium.org> Date: Tue May 01 20:50:14 2018 [AF] Update prediction title max length to reflect latest change. That data is used to reserve the size of the title string. It was not updated when I updated the title to add the section name. See bug for more information. Bug: 835994 Change-Id: I94c5f5d7c67325d86a638941b5cfb667b455bcd0 Reviewed-on: https://chromium-review.googlesource.com/1037924 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555178} [modify] https://crrev.com/54ecd00db27f643379da39837abb338bcda98cf1/components/autofill/content/renderer/form_cache.cc
,
May 2 2018
sebsg@ Request you to provide the steps to test this issue and verify the fix on the latest Canary 68.0.3417.0. Thanks..
,
May 2 2018
1. Enable the #show-autofill-type-predictions flag on chrome://flags 2. Navigate to https://rsolomakhin.github.io/autofill 3. Hover over a field, you should see a bunch of information popup like overall type, etc. You should see a section there too. Thanks |
|||
►
Sign in to add a comment |
|||
Comment 1 by se...@chromium.org
, Apr 23 2018