New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835988 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Ugly transition from boot splash screen to login screen

Project Member Reported by derat@chromium.org, Apr 23 2018

Issue description

In a ToT caroline build at r817688, the visual transition when booting is ugly, as seen in https://drive.google.com/file/d/1fPb9TNz-mA6U0Xh1UzbPovyzzn_OZLW2/view?usp=sharing.

After the boot splash logo, the user pods appear on top of a white background. Shortly after that, the wallpaper pops in.

Here's what boot looked like in M65: https://drive.google.com/file/d/1X3ZJDlflpXm3yjOPT0uHHCsq374LVMmK/view?usp=sharing

There, the background appeared in its blurred form first and then the user pods appeared on top. This feels less jarring to me.
 
Cc: r...@chromium.org
Views login is loading too quickly :)

iirc webui has some logic to defer display until after the wallpaper is loaded. My guess is that this was not ported; since views login instantiates very quickly we may just want to wait until after wallpaper is loaded before loading.

Comment 2 by r...@chromium.org, Apr 23 2018

Labels: -M-67 M-68
Moving milestone since views-login is turned on only in 68.

Comment 3 by wzang@chromium.org, Apr 27 2018

Cc: wzang@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 837567  has been merged into this issue.
Thanks, we can have views-login just hide itself until that callback is triggered and/or add a notification in ash itself.

Comment 6 by wzang@chromium.org, May 2 2018

Cc: jdufault@chromium.org x...@chromium.org
 Issue 838896  has been merged into this issue.

Comment 7 by r...@chromium.org, May 3 2018

Owner: wzang@chromium.org

Comment 8 by wzang@chromium.org, May 3 2018

 Issue 838857  has been merged into this issue.

Comment 9 by wzang@chromium.org, May 4 2018

Status: Started (was: Assigned)
Cc: zalcorn@chromium.org
 Issue 848468  has been merged into this issue.
Labels: -M-68 M-69
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73349728077e46a781c62bcfb20a7d3b59eb346e

commit 73349728077e46a781c62bcfb20a7d3b59eb346e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Jun 12 16:53:10 2018

cros: Smoothen the transition to views login screen

After showing the white splash screen, we should defer displaying the
login screen until the wallpaper is ready. Otherwise, there may be jank
when booting: currently the user pods often initially appear above a
white background.

Also set a fallback timer to ensure the login screen can be shown even
if the wallpaper never appears. This should never happen, so an extra
long time-out is specifically chosen to signal it's a bug. (It's safe
to have the timer considering the potential damage of the bug: users
can't use the device at all.)

Bug:  835988 
Change-Id: Iaa0c749ef5ac6620f6dd3b12cbfc04b7e9c6a683
Reviewed-on: https://chromium-review.googlesource.com/1094146
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566467}
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/login/login_screen_controller.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/login/login_screen_controller_unittest.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/login/ui/lock_screen.h
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/login/ui/login_keyboard_test_base.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/system/power/power_event_observer.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/wallpaper/wallpaper_widget_controller.cc
[modify] https://crrev.com/73349728077e46a781c62bcfb20a7d3b59eb346e/ash/wallpaper/wallpaper_widget_controller.h

Comment 13 by wzang@chromium.org, Jun 12 2018

Status: Fixed (was: Started)

Comment 14 by wzang@chromium.org, Jun 26 2018

Cc: mkarkada@chromium.org dhadd...@chromium.org sdantul...@chromium.org
 Issue 848868  has been merged into this issue.

Sign in to add a comment