[Autofill] rationalization for multiple address lines. |
|||||||||
Issue descriptionshop.bbc.com -> Billing Info -> Address and Address 2, must be detected as HOME_LINE_ADDRESS1 and 2. They have identical form and field signatures. The server detects them as ADDRESS_HOME_STREET_ADDRESS, and heuristics detect them as HOME_LINE_ADDRESS2 and 3.
,
Apr 24 2018
,
Jun 6 2018
,
Jun 6 2018
The same issue (two address lines with identical signatures): zumiez.com grasscity.com
,
Jun 6 2018
,
Jun 6 2018
,
Jun 6 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aea837d1a080f592ad0ddb3621bc58af11226131 commit aea837d1a080f592ad0ddb3621bc58af11226131 Author: sebsg <sebsg@chromium.org> Date: Thu Jun 07 18:06:19 2018 [AF] Rationalize forms with multiple street address predictions. Some forms have multiple sequential fields predicted as being the whole street address. We should rationalize those to a set of address lines 1, 2 and possibly 3 depending on the situation. Bug: 835975 Change-Id: I75b2fa891a9ca3006066df6ba418f3475ffe01b8 Reviewed-on: https://chromium-review.googlesource.com/1089804 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565344} [modify] https://crrev.com/aea837d1a080f592ad0ddb3621bc58af11226131/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/aea837d1a080f592ad0ddb3621bc58af11226131/components/autofill/core/browser/form_structure.h [modify] https://crrev.com/aea837d1a080f592ad0ddb3621bc58af11226131/components/autofill/core/browser/form_structure_unittest.cc
,
Jun 7 2018
,
Jun 11 2018
,
Jun 11 2018
We also need to consider multiple sections on a form. Two or more address fields on a form, may belong to different sections rather than being misidentified.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4581e9a6d96b6ff4bb8ba8cc9d1bc9ccdc6e6ef commit b4581e9a6d96b6ff4bb8ba8cc9d1bc9ccdc6e6ef Author: Parastoo Geranmayeh <parastoog@google.com> Date: Wed Jun 13 01:28:43 2018 [Autofill] Rationalize address fields based on sections. Multiple address fields may belong to multiple sections on a form, and may not mean different address lines, and thus may not need rationalization. Also, multiple address fields may be hidden/visible pairs, and not different lines. While rationalizing address fields, one should consider the sections identified by the heuristics (DetermineHeuristicTypes). These sections are based on the types predicted by heuristics. This way we are merging the two sources of type predictions. Examples are included in the tests. Bug: 835975 Change-Id: I9f3680e69162b6b7d01203bd89773a99e5ca8af7 Reviewed-on: https://chromium-review.googlesource.com/1093796 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#566675} [modify] https://crrev.com/b4581e9a6d96b6ff4bb8ba8cc9d1bc9ccdc6e6ef/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/b4581e9a6d96b6ff4bb8ba8cc9d1bc9ccdc6e6ef/components/autofill/core/browser/form_structure.h [modify] https://crrev.com/b4581e9a6d96b6ff4bb8ba8cc9d1bc9ccdc6e6ef/components/autofill/core/browser/form_structure_unittest.cc
,
Jun 13 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rogerm@chromium.org
, Apr 23 2018the voting system doesn't properly capture that they're separate fields, otherwise, we could adjust the pipeline to track fields by {signagure, ordinal} pairs and return different votes even through they have the same signature. :( I'm looking at fixing this.