New issue
Advanced search Search tips

Issue 835972 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 827649



Sign in to add a comment

add UMA for PictureBufferMechanism

Project Member Reported by liber...@chromium.org, Apr 23 2018

Issue description

see how often DXVA VDA uses each of the picture buffer mechanisms (e.g., "bind" or "copy to rgb").
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddaa30b6f4e207985fbbb03a9c8fd738285475d1

commit ddaa30b6f4e207985fbbb03a9c8fd738285475d1
Author: liberato@chromium.org <liberato@chromium.org>
Date: Tue Apr 24 19:45:48 2018

Add UMA for DXVA PictureBufferMechanism.

To help us figure out how to prioritize the various picture buffer
types in the new D3D11VideoDecoder, this UMA records how often
each is used in the DXVA VDA.

Bug:  835972 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I39b41000b54b932ce8cc592893bef1826f458308
Reviewed-on: https://chromium-review.googlesource.com/1024927
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553236}
[modify] https://crrev.com/ddaa30b6f4e207985fbbb03a9c8fd738285475d1/media/gpu/windows/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/ddaa30b6f4e207985fbbb03a9c8fd738285475d1/media/gpu/windows/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/ddaa30b6f4e207985fbbb03a9c8fd738285475d1/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ddaa30b6f4e207985fbbb03a9c8fd738285475d1/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-67
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Apr 26 2018

Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Beta release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf2cef8b49da3721dd716b3a3e749d0deed94b80

commit bf2cef8b49da3721dd716b3a3e749d0deed94b80
Author: liberato@chromium.org <liberato@chromium.org>
Date: Thu Apr 26 05:01:45 2018

Add UMA for DXVA PictureBufferMechanism.

To help us figure out how to prioritize the various picture buffer
types in the new D3D11VideoDecoder, this UMA records how often
each is used in the DXVA VDA.

Bug:  835972 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I39b41000b54b932ce8cc592893bef1826f458308
Reviewed-on: https://chromium-review.googlesource.com/1024927
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553236}(cherry picked from commit ddaa30b6f4e207985fbbb03a9c8fd738285475d1)
Reviewed-on: https://chromium-review.googlesource.com/1029632
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#319}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/bf2cef8b49da3721dd716b3a3e749d0deed94b80/media/gpu/windows/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/bf2cef8b49da3721dd716b3a3e749d0deed94b80/media/gpu/windows/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/bf2cef8b49da3721dd716b3a3e749d0deed94b80/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/bf2cef8b49da3721dd716b3a3e749d0deed94b80/tools/metrics/histograms/histograms.xml

Sign in to add a comment